From: Guo Ren <guoren@kernel.org> To: "Jernej Škrabec" <jernej.skrabec@gmail.com> Cc: "Andre Przywara" <andre.przywara@arm.com>, "Anup Patel" <anup.patel@wdc.com>, "Palmer Dabbelt" <palmerdabbelt@google.com>, "Arnd Bergmann" <arnd@arndb.de>, wens@csie.org, maxime@cerno.tech, "Drew Fustini" <drew@beagleboard.org>, liush@allwinnertech.com, "Wei Wu (吴伟)" <lazyparser@gmail.com>, wefu@redhat.com, linux-riscv <linux-riscv@lists.infradead.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, linux-sunxi@lists.linux.dev, "Maxime Ripard" <mripard@kernel.org>, "Corentin Labbe" <clabbe@baylibre.com>, "Samuel Holland" <samuel@sholland.org>, "Icenowy Zheng" <icenowy@aosc.io>, "LABBE Corentin" <clabbe.montjoie@gmail.com>, "Michael Walle" <michael@walle.cc>, "Guo Ren" <guoren@linux.alibaba.com> Subject: Re: [RFC PATCH v2 11/11] riscv: soc: Allwinner D1 GMAC driver only for temp use Date: Sun, 6 Jun 2021 23:41:48 +0800 [thread overview] Message-ID: <CAJF2gTR3nUYsFv5=29DbE=nrgDaqmcj3KRm8F-WKsdTXHX02sQ@mail.gmail.com> (raw) In-Reply-To: <49182865.cm8dGOVcTj@jernej-laptop> On Sun, Jun 6, 2021 at 11:39 PM Jernej Škrabec <jernej.skrabec@gmail.com> wrote: > > Hi! > > Dne nedelja, 06. junij 2021 ob 17:32:22 CEST je Guo Ren napisal(a): > > , > > > > On Sun, Jun 6, 2021 at 6:50 PM Andre Przywara <andre.przywara@arm.com> > wrote: > > > On Sun, 6 Jun 2021 09:04:09 +0000 > > > guoren@kernel.org wrote: > > > > > > Hi, > > > > > > > From: liush <liush@allwinnertech.com> > > > > > > > > This is a temporary driver, only guaranteed to work on allwinner > > > > D1. In order to ensure the developer's demand for network usage. > > > > > > That looks like some Allwinner BSP driver, please don't endorse code > > > of this quality (just look at all that commented code and the attempt > > > for compile-time configuration). > > > > > > > It only could work at 1Gps mode. > > > > > > > > The correct gmac driver should follow (I guess) > > > > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > > > > > > > > If anyone is familiar with it and can help porting, I would be > > > > very grateful. > > > > > > Have you tried compiling and using that driver? Ideally it should just > > > work, Linux drivers are meant to be portable, by design. And the driver > > > is already enabled by COMPILE_TEST. > > > > It still needs some work with dwmac-sun8i.c glue layer, eg: > > tx/rx-delay setting, clk & pinmux drivers. > > > > The patch is just to help people using D1 with GMAC temporarily with > > network function. > > It should be marked "DO NOT MERGE" or similar then. Yes, thx for reminding. I'll fix it next time. > > Best regards, > Jernej > > > > > > But I guess you need some extra care to make the non-coherent DMA work? > > > I haven't looked in detail, but are those new CMOs hooked into the > > > generic DMA framework? > > > > Yes, we have the simliar principle with arm & csky for non-coherent: > > - Using PTE attributes setting Using PTE attributes to support > > _PAGE_IOREMAP & _PAGE_WRITECOMBINE > > - Using CMO instructions deal SYNC_DMA_FOR_CPU/DEVICE. > > > > > Cheers, > > > Andre > > > > > > > Signed-off-by: Liu Shaohua <liush@allwinnertech.com> > > > > Tested-by: Guo Ren <guoren@kernel.org> > > > > Signed-off-by: Guo Ren <guoren@kernel.org> > > > > Cc: Maxime Ripard <mripard@kernel.org> > > > > Cc: Corentin Labbe <clabbe@baylibre.com> > > > > Cc: Samuel Holland <samuel@sholland.org> > > > > Cc: Icenowy Zheng <icenowy@aosc.io> > > > > Cc: LABBE Corentin <clabbe.montjoie@gmail.com> > > > > Cc: Michael Walle <michael@walle.cc> > > > > Cc: Chen-Yu Tsai <wens@csie.org> > > > > Cc: Maxime Ripard <maxime@cerno.tech> > > > > Cc: Wei Fu <wefu@redhat.com> > > > > Cc: Wei Wu <lazyparser@gmail.com> > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org> To: "Jernej Škrabec" <jernej.skrabec@gmail.com> Cc: "Andre Przywara" <andre.przywara@arm.com>, "Anup Patel" <anup.patel@wdc.com>, "Palmer Dabbelt" <palmerdabbelt@google.com>, "Arnd Bergmann" <arnd@arndb.de>, wens@csie.org, maxime@cerno.tech, "Drew Fustini" <drew@beagleboard.org>, liush@allwinnertech.com, "Wei Wu (吴伟)" <lazyparser@gmail.com>, wefu@redhat.com, linux-riscv <linux-riscv@lists.infradead.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, linux-sunxi@lists.linux.dev, "Maxime Ripard" <mripard@kernel.org>, "Corentin Labbe" <clabbe@baylibre.com>, "Samuel Holland" <samuel@sholland.org>, "Icenowy Zheng" <icenowy@aosc.io>, "LABBE Corentin" <clabbe.montjoie@gmail.com>, "Michael Walle" <michael@walle.cc>, "Guo Ren" <guoren@linux.alibaba.com> Subject: Re: [RFC PATCH v2 11/11] riscv: soc: Allwinner D1 GMAC driver only for temp use Date: Sun, 6 Jun 2021 23:41:48 +0800 [thread overview] Message-ID: <CAJF2gTR3nUYsFv5=29DbE=nrgDaqmcj3KRm8F-WKsdTXHX02sQ@mail.gmail.com> (raw) In-Reply-To: <49182865.cm8dGOVcTj@jernej-laptop> On Sun, Jun 6, 2021 at 11:39 PM Jernej Škrabec <jernej.skrabec@gmail.com> wrote: > > Hi! > > Dne nedelja, 06. junij 2021 ob 17:32:22 CEST je Guo Ren napisal(a): > > , > > > > On Sun, Jun 6, 2021 at 6:50 PM Andre Przywara <andre.przywara@arm.com> > wrote: > > > On Sun, 6 Jun 2021 09:04:09 +0000 > > > guoren@kernel.org wrote: > > > > > > Hi, > > > > > > > From: liush <liush@allwinnertech.com> > > > > > > > > This is a temporary driver, only guaranteed to work on allwinner > > > > D1. In order to ensure the developer's demand for network usage. > > > > > > That looks like some Allwinner BSP driver, please don't endorse code > > > of this quality (just look at all that commented code and the attempt > > > for compile-time configuration). > > > > > > > It only could work at 1Gps mode. > > > > > > > > The correct gmac driver should follow (I guess) > > > > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > > > > > > > > If anyone is familiar with it and can help porting, I would be > > > > very grateful. > > > > > > Have you tried compiling and using that driver? Ideally it should just > > > work, Linux drivers are meant to be portable, by design. And the driver > > > is already enabled by COMPILE_TEST. > > > > It still needs some work with dwmac-sun8i.c glue layer, eg: > > tx/rx-delay setting, clk & pinmux drivers. > > > > The patch is just to help people using D1 with GMAC temporarily with > > network function. > > It should be marked "DO NOT MERGE" or similar then. Yes, thx for reminding. I'll fix it next time. > > Best regards, > Jernej > > > > > > But I guess you need some extra care to make the non-coherent DMA work? > > > I haven't looked in detail, but are those new CMOs hooked into the > > > generic DMA framework? > > > > Yes, we have the simliar principle with arm & csky for non-coherent: > > - Using PTE attributes setting Using PTE attributes to support > > _PAGE_IOREMAP & _PAGE_WRITECOMBINE > > - Using CMO instructions deal SYNC_DMA_FOR_CPU/DEVICE. > > > > > Cheers, > > > Andre > > > > > > > Signed-off-by: Liu Shaohua <liush@allwinnertech.com> > > > > Tested-by: Guo Ren <guoren@kernel.org> > > > > Signed-off-by: Guo Ren <guoren@kernel.org> > > > > Cc: Maxime Ripard <mripard@kernel.org> > > > > Cc: Corentin Labbe <clabbe@baylibre.com> > > > > Cc: Samuel Holland <samuel@sholland.org> > > > > Cc: Icenowy Zheng <icenowy@aosc.io> > > > > Cc: LABBE Corentin <clabbe.montjoie@gmail.com> > > > > Cc: Michael Walle <michael@walle.cc> > > > > Cc: Chen-Yu Tsai <wens@csie.org> > > > > Cc: Maxime Ripard <maxime@cerno.tech> > > > > Cc: Wei Fu <wefu@redhat.com> > > > > Cc: Wei Wu <lazyparser@gmail.com> > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-06-06 15:42 UTC|newest] Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-06 9:03 [RFC PATCH v2 00/11] riscv: Add DMA_COHERENT support for Allwinner D1 guoren 2021-06-06 9:03 ` guoren 2021-06-06 9:03 ` [RFC PATCH v2 01/11] riscv: asid: Use global mappings for kernel pages guoren 2021-06-06 9:03 ` guoren 2021-06-06 9:03 ` [PATCH V5 1/3] riscv: " guoren 2021-06-06 9:03 ` guoren 2021-06-06 9:03 ` [PATCH V5 2/3] riscv: Add ASID-based tlbflushing methods guoren 2021-06-06 9:03 ` guoren 2021-06-06 14:38 ` Christoph Hellwig 2021-06-06 14:38 ` Christoph Hellwig 2021-06-06 9:03 ` [RFC PATCH v2 02/11] riscv: asid: " guoren 2021-06-06 9:03 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 03/11] riscv: asid: Optimize tlbflush coding convention guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [PATCH V5 3/3] riscv: tlbflush: Optimize " guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 04/11] riscv: pgtable: Fixup _PAGE_CHG_MASK usage guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 05/11] riscv: pgtable: Add custom protection_map init guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 06/11] riscv: pgtable: Add DMA_COHERENT with custom PTE attributes guoren 2021-06-06 9:04 ` guoren 2021-06-06 14:39 ` Christoph Hellwig 2021-06-06 14:39 ` Christoph Hellwig 2021-06-06 15:08 ` Guo Ren 2021-06-06 15:08 ` Guo Ren 2021-06-06 17:22 ` Nick Kossifidis 2021-06-06 17:22 ` Nick Kossifidis 2021-06-07 6:19 ` Christoph Hellwig 2021-06-07 6:19 ` Christoph Hellwig 2021-06-06 9:04 ` [RFC PATCH v2 07/11] riscv: cmo: Add dma-noncoherency support guoren 2021-06-06 9:04 ` guoren 2021-10-17 9:28 ` twd2 2021-10-17 9:28 ` twd2 2021-10-20 8:11 ` Guo Ren 2021-10-20 8:11 ` Guo Ren 2021-06-06 9:04 ` [RFC PATCH v2 08/11] riscv: cmo: Add vendor custom icache sync guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 09/11] riscv: soc: Initial DTS for Allwinner D1 NeZha board guoren 2021-06-06 9:04 ` guoren 2021-06-06 16:26 ` Jernej Škrabec 2021-06-06 16:26 ` Jernej Škrabec 2021-06-06 17:05 ` Guo Ren 2021-06-06 17:05 ` Guo Ren 2021-06-07 3:44 ` Guo Ren 2021-06-07 3:44 ` Guo Ren 2021-06-07 7:27 ` Maxime Ripard 2021-06-07 7:27 ` Maxime Ripard 2021-06-07 7:53 ` Guo Ren 2021-06-07 7:53 ` Guo Ren 2021-06-07 7:24 ` Maxime Ripard 2021-06-07 7:24 ` Maxime Ripard 2021-06-07 8:07 ` Guo Ren 2021-06-07 8:07 ` Guo Ren 2021-06-14 15:33 ` Maxime Ripard 2021-06-14 15:33 ` Maxime Ripard 2021-06-14 16:28 ` Guo Ren 2021-06-14 16:28 ` Guo Ren 2021-06-14 16:31 ` Jernej Škrabec 2021-06-14 16:31 ` Jernej Škrabec 2021-06-06 9:04 ` [RFC PATCH v2 10/11] riscv: soc: Add Allwinner SoC kconfig option guoren 2021-06-06 9:04 ` guoren 2021-06-07 7:19 ` Maxime Ripard 2021-06-07 7:19 ` Maxime Ripard 2021-06-07 7:27 ` Arnd Bergmann 2021-06-07 7:27 ` Arnd Bergmann 2021-06-07 7:27 ` Arnd Bergmann 2021-06-07 7:45 ` Guo Ren 2021-06-07 7:45 ` Guo Ren 2021-06-07 7:43 ` Guo Ren 2021-06-07 7:43 ` Guo Ren 2021-06-07 12:12 ` Maxime Ripard 2021-06-07 12:12 ` Maxime Ripard 2021-06-07 12:39 ` Guo Ren 2021-06-07 12:39 ` Guo Ren 2021-06-06 9:04 ` [RFC PATCH v2 11/11] riscv: soc: Allwinner D1 GMAC driver only for temp use guoren 2021-06-06 9:04 ` guoren 2021-06-06 10:50 ` Andre Przywara 2021-06-06 10:50 ` Andre Przywara 2021-06-06 15:32 ` Guo Ren 2021-06-06 15:32 ` Guo Ren 2021-06-06 15:39 ` Jernej Škrabec 2021-06-06 15:39 ` Jernej Škrabec 2021-06-06 15:41 ` Guo Ren [this message] 2021-06-06 15:41 ` Guo Ren 2021-06-06 16:16 ` Arnd Bergmann 2021-06-06 16:16 ` Arnd Bergmann 2021-06-06 16:16 ` Arnd Bergmann 2021-06-06 16:32 ` Jernej Škrabec 2021-06-06 16:32 ` Jernej Škrabec 2021-06-06 16:53 ` Guo Ren 2021-06-06 16:53 ` Guo Ren 2021-06-06 16:53 ` Guo Ren 2021-06-06 16:53 ` Guo Ren 2021-06-06 16:29 ` [RFC PATCH v2 00/11] riscv: Add DMA_COHERENT support for Allwinner D1 Jernej Škrabec 2021-06-06 16:29 ` Jernej Škrabec 2021-06-06 16:54 ` Guo Ren 2021-06-06 16:54 ` Guo Ren 2021-06-06 17:14 ` Jernej Škrabec 2021-06-06 17:14 ` Jernej Škrabec 2021-06-06 23:42 ` Guo Ren 2021-06-06 23:42 ` Guo Ren 2021-06-07 3:44 ` Anup Patel 2021-06-07 3:44 ` Anup Patel 2021-06-07 4:36 ` Guo Ren 2021-06-07 4:36 ` Guo Ren 2021-06-07 4:36 ` Guo Ren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJF2gTR3nUYsFv5=29DbE=nrgDaqmcj3KRm8F-WKsdTXHX02sQ@mail.gmail.com' \ --to=guoren@kernel.org \ --cc=andre.przywara@arm.com \ --cc=anup.patel@wdc.com \ --cc=arnd@arndb.de \ --cc=clabbe.montjoie@gmail.com \ --cc=clabbe@baylibre.com \ --cc=drew@beagleboard.org \ --cc=guoren@linux.alibaba.com \ --cc=icenowy@aosc.io \ --cc=jernej.skrabec@gmail.com \ --cc=lazyparser@gmail.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=liush@allwinnertech.com \ --cc=maxime@cerno.tech \ --cc=michael@walle.cc \ --cc=mripard@kernel.org \ --cc=palmerdabbelt@google.com \ --cc=samuel@sholland.org \ --cc=wefu@redhat.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.