From: Guo Ren <guoren@kernel.org> To: arnd@arndb.de, guoren@kernel.org, palmer@rivosinc.com, tglx@linutronix.de, peterz@infradead.org, luto@kernel.org, conor.dooley@microchip.com, heiko@sntech.de, jszhang@kernel.org, lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org, apatel@ventanamicro.com, atishp@atishpatra.org, palmer@dabbelt.com, paul.walmsley@sifive.com, mark.rutland@arm.com, zouyipeng@huawei.com, bigeasy@linutronix.de, David.Laight@aculab.com Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Guo Ren <guoren@linux.alibaba.com> Subject: Re: [PATCH V5 09/11] riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK Date: Tue, 20 Sep 2022 08:11:55 +0800 [thread overview] Message-ID: <CAJF2gTRtRzeDqr3=AUkGadPMmMA6kwU86+zSNn8+0qXSk8zmVQ@mail.gmail.com> (raw) In-Reply-To: <20220918155246.1203293-10-guoren@kernel.org> On Sun, Sep 18, 2022 at 11:53 PM <guoren@kernel.org> wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > Add the HAVE_SOFTIRQ_ON_OWN_STACK feature for the IRQ_STACKS config. The > irq and softirq use the same independent irq_stack of percpu by time > division multiplexing. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Signed-off-by: Guo Ren <guoren@kernel.org> > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > arch/riscv/Kconfig | 7 ++++--- > arch/riscv/kernel/irq.c | 16 ++++++++++++++++ > 2 files changed, 20 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 75db47a983f2..dfe600f3526c 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -434,12 +434,13 @@ config FPU > If you don't know what to do here, say Y. > > config IRQ_STACKS > - bool "Independent irq stacks" if EXPERT > + bool "Independent irq & softirq stacks" if EXPERT > default y > select HAVE_IRQ_EXIT_ON_IRQ_STACK > + select HAVE_SOFTIRQ_ON_OWN_STACK > help > - Add independent irq stacks for percpu to prevent kernel stack overflows. > - We may save some memory footprint by disabling IRQ_STACKS. > + Add independent irq & softirq stacks for percpu to prevent kernel stack > + overflows. We may save some memory footprint by disabling IRQ_STACKS. > > endmenu # "Platform type" > > diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c > index 5ad4952203c5..6dc9ccd01470 100644 > --- a/arch/riscv/kernel/irq.c > +++ b/arch/riscv/kernel/irq.c > @@ -11,6 +11,7 @@ > #include <linux/seq_file.h> > #include <asm/smp.h> > #include <asm/vmap_stack.h> > +#include <asm/softirq_stack.h> > > #ifdef CONFIG_IRQ_STACKS > static DEFINE_PER_CPU(ulong *, irq_stack_ptr); > @@ -38,6 +39,21 @@ static void init_irq_stacks(void) > per_cpu(irq_stack_ptr, cpu) = per_cpu(irq_stack, cpu); > } > #endif /* CONFIG_VMAP_STACK */ > + > +#ifdef CONFIG_SOFTIRQ_ON_OWN_STACK Sorry, it should be. If you compiled an error, please modify it manually, +#ifdef CONFIG_HAVE_SOFTIRQ_ON_OWN_STACK > +static void do_riscv_softirq(struct pt_regs *regs) > +{ > + __do_softirq(); > +} > + > +void do_softirq_own_stack(void) > +{ > + ulong *sp = per_cpu(irq_stack_ptr, smp_processor_id()); > + > + call_on_stack(NULL, sp, do_riscv_softirq, 0); > +} > +#endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */ > + > #else > static void init_irq_stacks(void) {} > #endif /* CONFIG_IRQ_STACKS */ > -- > 2.36.1 > -- Best Regards Guo Ren
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org> To: arnd@arndb.de, guoren@kernel.org, palmer@rivosinc.com, tglx@linutronix.de, peterz@infradead.org, luto@kernel.org, conor.dooley@microchip.com, heiko@sntech.de, jszhang@kernel.org, lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org, apatel@ventanamicro.com, atishp@atishpatra.org, palmer@dabbelt.com, paul.walmsley@sifive.com, mark.rutland@arm.com, zouyipeng@huawei.com, bigeasy@linutronix.de, David.Laight@aculab.com Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Guo Ren <guoren@linux.alibaba.com> Subject: Re: [PATCH V5 09/11] riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK Date: Tue, 20 Sep 2022 08:11:55 +0800 [thread overview] Message-ID: <CAJF2gTRtRzeDqr3=AUkGadPMmMA6kwU86+zSNn8+0qXSk8zmVQ@mail.gmail.com> (raw) In-Reply-To: <20220918155246.1203293-10-guoren@kernel.org> On Sun, Sep 18, 2022 at 11:53 PM <guoren@kernel.org> wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > Add the HAVE_SOFTIRQ_ON_OWN_STACK feature for the IRQ_STACKS config. The > irq and softirq use the same independent irq_stack of percpu by time > division multiplexing. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Signed-off-by: Guo Ren <guoren@kernel.org> > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > arch/riscv/Kconfig | 7 ++++--- > arch/riscv/kernel/irq.c | 16 ++++++++++++++++ > 2 files changed, 20 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 75db47a983f2..dfe600f3526c 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -434,12 +434,13 @@ config FPU > If you don't know what to do here, say Y. > > config IRQ_STACKS > - bool "Independent irq stacks" if EXPERT > + bool "Independent irq & softirq stacks" if EXPERT > default y > select HAVE_IRQ_EXIT_ON_IRQ_STACK > + select HAVE_SOFTIRQ_ON_OWN_STACK > help > - Add independent irq stacks for percpu to prevent kernel stack overflows. > - We may save some memory footprint by disabling IRQ_STACKS. > + Add independent irq & softirq stacks for percpu to prevent kernel stack > + overflows. We may save some memory footprint by disabling IRQ_STACKS. > > endmenu # "Platform type" > > diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c > index 5ad4952203c5..6dc9ccd01470 100644 > --- a/arch/riscv/kernel/irq.c > +++ b/arch/riscv/kernel/irq.c > @@ -11,6 +11,7 @@ > #include <linux/seq_file.h> > #include <asm/smp.h> > #include <asm/vmap_stack.h> > +#include <asm/softirq_stack.h> > > #ifdef CONFIG_IRQ_STACKS > static DEFINE_PER_CPU(ulong *, irq_stack_ptr); > @@ -38,6 +39,21 @@ static void init_irq_stacks(void) > per_cpu(irq_stack_ptr, cpu) = per_cpu(irq_stack, cpu); > } > #endif /* CONFIG_VMAP_STACK */ > + > +#ifdef CONFIG_SOFTIRQ_ON_OWN_STACK Sorry, it should be. If you compiled an error, please modify it manually, +#ifdef CONFIG_HAVE_SOFTIRQ_ON_OWN_STACK > +static void do_riscv_softirq(struct pt_regs *regs) > +{ > + __do_softirq(); > +} > + > +void do_softirq_own_stack(void) > +{ > + ulong *sp = per_cpu(irq_stack_ptr, smp_processor_id()); > + > + call_on_stack(NULL, sp, do_riscv_softirq, 0); > +} > +#endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */ > + > #else > static void init_irq_stacks(void) {} > #endif /* CONFIG_IRQ_STACKS */ > -- > 2.36.1 > -- Best Regards Guo Ren _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-20 0:12 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-18 15:52 [PATCH V5 00/11] riscv: Add GENERIC_ENTRY support and related features guoren 2022-09-18 15:52 ` guoren 2022-09-18 15:52 ` [PATCH V5 01/11] riscv: elf_kexec: Fixup compile warning guoren 2022-09-18 15:52 ` guoren 2022-09-18 15:52 ` [PATCH V5 02/11] riscv: compat_syscall_table: " guoren 2022-09-18 15:52 ` guoren 2022-09-18 15:52 ` [PATCH V5 03/11] riscv: ptrace: Remove duplicate operation guoren 2022-09-18 15:52 ` guoren 2022-09-18 15:52 ` [PATCH V5 04/11] compiler_types.h: Add __noinstr_section() for noinstr guoren 2022-09-18 15:52 ` guoren 2022-09-18 15:52 ` [PATCH V5 05/11] riscv: traps: Add noinstr to prevent instrumentation inserted guoren 2022-09-18 15:52 ` guoren 2022-09-18 15:52 ` [PATCH V5 06/11] entry: Prevent DEBUG_PREEMPT warning guoren 2022-09-18 15:52 ` guoren 2022-09-19 11:58 ` Peter Zijlstra 2022-09-19 11:58 ` Peter Zijlstra 2022-09-20 1:45 ` Guo Ren 2022-09-20 1:45 ` Guo Ren 2022-09-30 12:27 ` Guo Ren 2022-09-30 12:27 ` Guo Ren 2022-09-18 15:52 ` [PATCH V5 07/11] riscv: convert to generic entry guoren 2022-09-18 15:52 ` guoren 2022-09-19 13:34 ` Peter Zijlstra 2022-09-19 13:34 ` Peter Zijlstra 2022-09-20 6:36 ` Guo Ren 2022-09-20 6:36 ` Guo Ren 2022-09-20 7:22 ` Peter Zijlstra 2022-09-20 7:22 ` Peter Zijlstra 2022-09-30 11:28 ` Guo Ren 2022-09-30 11:28 ` Guo Ren 2022-09-18 15:52 ` [PATCH V5 08/11] riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK guoren 2022-09-18 15:52 ` guoren 2022-09-19 13:45 ` Peter Zijlstra 2022-09-19 13:45 ` Peter Zijlstra 2022-09-20 6:08 ` Guo Ren 2022-09-20 6:08 ` Guo Ren 2022-09-20 7:27 ` Peter Zijlstra 2022-09-20 7:27 ` Peter Zijlstra 2022-09-20 7:34 ` Peter Zijlstra 2022-09-20 7:34 ` Peter Zijlstra 2022-09-21 6:16 ` Guo Ren 2022-09-21 6:16 ` Guo Ren 2022-09-21 8:34 ` Chen Zhongjin 2022-09-21 8:34 ` Chen Zhongjin 2022-09-21 9:53 ` Guo Ren 2022-09-21 9:53 ` Guo Ren 2022-09-21 11:56 ` Chen Zhongjin 2022-09-21 11:56 ` Chen Zhongjin 2022-09-22 1:26 ` Guo Ren 2022-09-22 1:26 ` Guo Ren 2022-09-18 15:52 ` [PATCH V5 09/11] riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK guoren 2022-09-18 15:52 ` guoren 2022-09-20 0:11 ` Guo Ren [this message] 2022-09-20 0:11 ` Guo Ren 2022-09-18 15:52 ` [PATCH V5 10/11] riscv: Add config of thread stack size guoren 2022-09-18 15:52 ` guoren 2022-09-18 15:52 ` [PATCH V5 11/11] riscv: Add support for STACKLEAK gcc plugin guoren 2022-09-18 15:52 ` guoren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJF2gTRtRzeDqr3=AUkGadPMmMA6kwU86+zSNn8+0qXSk8zmVQ@mail.gmail.com' \ --to=guoren@kernel.org \ --cc=David.Laight@aculab.com \ --cc=apatel@ventanamicro.com \ --cc=arnd@arndb.de \ --cc=atishp@atishpatra.org \ --cc=bigeasy@linutronix.de \ --cc=chenhuacai@kernel.org \ --cc=conor.dooley@microchip.com \ --cc=falcon@tinylab.org \ --cc=guoren@linux.alibaba.com \ --cc=heiko@sntech.de \ --cc=jszhang@kernel.org \ --cc=lazyparser@gmail.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=luto@kernel.org \ --cc=mark.rutland@arm.com \ --cc=palmer@dabbelt.com \ --cc=palmer@rivosinc.com \ --cc=paul.walmsley@sifive.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=zouyipeng@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.