From: David Marchand <david.marchand@redhat.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
Sunil Pai G <sunil.pai.g@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning
Date: Mon, 10 May 2021 16:06:00 +0200 [thread overview]
Message-ID: <CAJFAV8yVNr7suYWM6Wm60km=yLu7EOdi57QuBLhjh1RZfzCvuQ@mail.gmail.com> (raw)
In-Reply-To: <20210510125514.12914-1-kevin.laatz@intel.com>
On Mon, May 10, 2021 at 2:55 PM Kevin Laatz <kevin.laatz@intel.com> wrote:
>
> In the function __idxd_completed_ops() we have a parameter shadow warning
> due to a local variable having the same name as one of the function
> parameters. This issue is fixed by simply renaming the local variable.
>
> This warning was discovered during an OVS build with DPDK 21.05-rc2. The
> OVS build passes the -Wshadow flag by default, allowing the warning to be
> seen.
A bit confusing.
-Wshadow only affects OVS code and there is no code calling this in
the OVS master branch.
I did not see this issue while updating my dpdk-latest OVS branch and
running builds in GHA.
So I guess Sunil caught it with his patch:
https://patchwork.ozlabs.org/project/openvswitch/patch/20201023094845.35652-2-sunil.pai.g@intel.com/
--
David Marchand
next prev parent reply other threads:[~2021-05-10 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 17:20 [dpdk-dev] [PATCH] raw/ioat: fix parameter shadow warning Kevin Laatz
2021-05-08 7:25 ` Pai G, Sunil
2021-05-10 9:02 ` Bruce Richardson
2021-05-10 11:07 ` Laatz, Kevin
2021-05-10 12:55 ` [dpdk-dev] [PATCH v2] " Kevin Laatz
2021-05-10 13:36 ` Bruce Richardson
2021-05-10 14:06 ` David Marchand [this message]
2021-05-10 14:48 ` Bruce Richardson
2021-05-11 20:49 ` Thomas Monjalon
2021-05-12 10:47 ` [dpdk-dev] [PATCH v3] " Kevin Laatz
2021-05-12 12:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yVNr7suYWM6Wm60km=yLu7EOdi57QuBLhjh1RZfzCvuQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=sunil.pai.g@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.