From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
Wolfram Sang <wolfram@the-dreams.de>,
Dong Aisheng <aisheng.dong@nxp.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties
Date: Thu, 3 Sep 2020 22:36:34 +0200 [thread overview]
Message-ID: <CAJKOXPc_abP=YU9cWFfPsFLrnb9N1PBEEbaSWPLLvYHZ_GmsGQ@mail.gmail.com> (raw)
In-Reply-To: <20200903164117.GA2922218@bogus>
On Thu, 3 Sep 2020 at 18:41, Rob Herring <robh@kernel.org> wrote:
>
> On Sat, Aug 29, 2020 at 01:17:59PM +0200, Krzysztof Kozlowski wrote:
> > Additional properties actually might appear (e.g. power-domains or child
> > nodes) so use unevaluatedProperties to fix dtbs_check warnings like:
> >
> > arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000:
> > '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
I can reference the generic i2c-controller schema and add missing
properties but what to do with children (pmic@25 and many other)? I
see that all of the other I2C controller dtschema files solve it by
skipping "additionalProperties: false". Is this the way to go with I2C
controllers?
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
devicetree@vger.kernel.org, Anson Huang <Anson.Huang@nxp.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-clk@vger.kernel.org, Wolfram Sang <wolfram@the-dreams.de>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties
Date: Thu, 3 Sep 2020 22:36:34 +0200 [thread overview]
Message-ID: <CAJKOXPc_abP=YU9cWFfPsFLrnb9N1PBEEbaSWPLLvYHZ_GmsGQ@mail.gmail.com> (raw)
In-Reply-To: <20200903164117.GA2922218@bogus>
On Thu, 3 Sep 2020 at 18:41, Rob Herring <robh@kernel.org> wrote:
>
> On Sat, Aug 29, 2020 at 01:17:59PM +0200, Krzysztof Kozlowski wrote:
> > Additional properties actually might appear (e.g. power-domains or child
> > nodes) so use unevaluatedProperties to fix dtbs_check warnings like:
> >
> > arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000:
> > '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
I can reference the generic i2c-controller schema and add missing
properties but what to do with children (pmic@25 and many other)? I
see that all of the other I2C controller dtschema files solve it by
skipping "additionalProperties: false". Is this the way to go with I2C
controllers?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-03 20:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 11:17 [PATCH 1/7] dt-bindings: clock: imx8m: Integrate duplicated i.MX 8M schemas Krzysztof Kozlowski
2020-08-29 11:17 ` Krzysztof Kozlowski
2020-08-29 11:17 ` [PATCH 2/7] dt-bindings: mailbox: fsl,mu: Fix i.MX 8QXP compatible matching Krzysztof Kozlowski
2020-08-29 11:17 ` [PATCH 2/7] dt-bindings: mailbox: fsl, mu: " Krzysztof Kozlowski
2020-08-29 11:17 ` [PATCH 3/7] dt-bindings: mailbox: fsl,mu: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-29 11:17 ` Krzysztof Kozlowski
2020-09-03 16:40 ` Rob Herring
2020-09-03 16:40 ` Rob Herring
2020-08-29 11:17 ` [PATCH 4/7] dt-bindings: i2c: imx-lpi2c: " Krzysztof Kozlowski
2020-08-29 11:17 ` Krzysztof Kozlowski
2020-09-03 16:40 ` Rob Herring
2020-09-03 16:40 ` Rob Herring
2020-08-29 11:17 ` [PATCH 5/7] dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QXP compatible matching Krzysztof Kozlowski
2020-08-29 11:17 ` Krzysztof Kozlowski
2020-08-29 11:17 ` [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-29 11:17 ` Krzysztof Kozlowski
2020-09-03 16:41 ` Rob Herring
2020-09-03 16:41 ` Rob Herring
2020-09-03 20:36 ` Krzysztof Kozlowski [this message]
2020-09-03 20:36 ` Krzysztof Kozlowski
2020-09-04 14:29 ` Rob Herring
2020-09-04 14:29 ` Rob Herring
2020-08-29 11:18 ` [PATCH 7/7] dt-bindings: i2c: imx: Fix i.MX 7 compatible matching Krzysztof Kozlowski
2020-08-29 11:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPc_abP=YU9cWFfPsFLrnb9N1PBEEbaSWPLLvYHZ_GmsGQ@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=wolfram@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.