* Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles
@ 2020-10-09 12:02 ` Thierry Reding
0 siblings, 0 replies; 12+ messages in thread
From: Thierry Reding @ 2020-10-09 12:02 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring
Cc: linux-pwm, Philipp Zabel, devicetree, Fabio Estevam,
Sascha Hauer, linux-kernel, NXP Linux Team,
Pengutronix Kernel Team, Uwe Kleine-König, Lee Jones,
Shawn Guo, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2845 bytes --]
On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote:
> On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > > warnings like:
> > >
> > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > ---
> > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> > > 1 file changed, 11 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > index 473863eb67e5..379d693889f6 100644
> > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > @@ -25,6 +25,17 @@ properties:
> > > - fsl,imx27-pwm
> > > - items:
> > > - enum:
> > > + - fsl,imx25-pwm
> >
> > The driver actually used fsl,imx27-pwm to bind ...
>
> Yes, most of i.MX drivers use only few compatibles but DTSes and
> bindings use multiple of them. I was convinced during various talks
> that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
> preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
> to the another level creating compatibles for absolutely every flavor of
> their CPU. And they mainlined it in DTSes...
>
> The PWM is this crazy examples where, as you say, only two compatibles
> are actually used for binding but DTSes uses more.
Yeah, these new compatible strings all seem to be used in the kernel, so
we might as well document them.
That said, I did want to apply this patch, but that fails. Am I missing
some other patch that you have sent out that touches this file? Actually
it looks like this is because you've based this patch on linux-next, or
perhaps the devicetree tree, because that contains commit d058717bdff4
("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that
adds a couple more compatible strings. Probably best for Rob to pick
this up, then:
Acked-by: Thierry Reding <treding@nvidia.com>
Rob, here's a patchwork link for you if you need one:
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/
Although, looking at the devicetree-bindings instance version of that
patch, I see that it's got a failing check attached (which looks like
it can be ignored) and it's marked "Changes Requested", but no comments
saying so.
Not sure if you want anything done here?
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles
2020-10-09 12:02 ` Thierry Reding
@ 2020-10-12 17:16 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-12 17:16 UTC (permalink / raw)
To: Thierry Reding
Cc: Rob Herring, Uwe Kleine-König, Lee Jones, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Philipp Zabel, linux-pwm, devicetree,
linux-arm-kernel, linux-kernel
On Fri, 9 Oct 2020 at 14:02, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote:
> > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > > > warnings like:
> > > >
> > > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> > > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> > > > 1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > index 473863eb67e5..379d693889f6 100644
> > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > @@ -25,6 +25,17 @@ properties:
> > > > - fsl,imx27-pwm
> > > > - items:
> > > > - enum:
> > > > + - fsl,imx25-pwm
> > >
> > > The driver actually used fsl,imx27-pwm to bind ...
> >
> > Yes, most of i.MX drivers use only few compatibles but DTSes and
> > bindings use multiple of them. I was convinced during various talks
> > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
> > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
> > to the another level creating compatibles for absolutely every flavor of
> > their CPU. And they mainlined it in DTSes...
> >
> > The PWM is this crazy examples where, as you say, only two compatibles
> > are actually used for binding but DTSes uses more.
>
> Yeah, these new compatible strings all seem to be used in the kernel, so
> we might as well document them.
>
> That said, I did want to apply this patch, but that fails. Am I missing
> some other patch that you have sent out that touches this file? Actually
> it looks like this is because you've based this patch on linux-next, or
> perhaps the devicetree tree, because that contains commit d058717bdff4
> ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that
> adds a couple more compatible strings. Probably best for Rob to pick
> this up, then:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
> Rob, here's a patchwork link for you if you need one:
>
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/
>
> Although, looking at the devicetree-bindings instance version of that
> patch, I see that it's got a failing check attached (which looks like
> it can be ignored) and it's marked "Changes Requested", but no comments
> saying so.
>
> Not sure if you want anything done here?
Thanks, I guess this will wait for the merge window to finish. It
should then apply to your tree. I can resend in two weeks.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles
@ 2020-10-12 17:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-12 17:16 UTC (permalink / raw)
To: Thierry Reding
Cc: linux-pwm, Fabio Estevam, Philipp Zabel, devicetree, Lee Jones,
Sascha Hauer, linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Uwe Kleine-König, Shawn Guo,
linux-arm-kernel
On Fri, 9 Oct 2020 at 14:02, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote:
> > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > > > warnings like:
> > > >
> > > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> > > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> > > > 1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > index 473863eb67e5..379d693889f6 100644
> > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > @@ -25,6 +25,17 @@ properties:
> > > > - fsl,imx27-pwm
> > > > - items:
> > > > - enum:
> > > > + - fsl,imx25-pwm
> > >
> > > The driver actually used fsl,imx27-pwm to bind ...
> >
> > Yes, most of i.MX drivers use only few compatibles but DTSes and
> > bindings use multiple of them. I was convinced during various talks
> > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
> > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
> > to the another level creating compatibles for absolutely every flavor of
> > their CPU. And they mainlined it in DTSes...
> >
> > The PWM is this crazy examples where, as you say, only two compatibles
> > are actually used for binding but DTSes uses more.
>
> Yeah, these new compatible strings all seem to be used in the kernel, so
> we might as well document them.
>
> That said, I did want to apply this patch, but that fails. Am I missing
> some other patch that you have sent out that touches this file? Actually
> it looks like this is because you've based this patch on linux-next, or
> perhaps the devicetree tree, because that contains commit d058717bdff4
> ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that
> adds a couple more compatible strings. Probably best for Rob to pick
> this up, then:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
> Rob, here's a patchwork link for you if you need one:
>
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/
>
> Although, looking at the devicetree-bindings instance version of that
> patch, I see that it's got a failing check attached (which looks like
> it can be ignored) and it's marked "Changes Requested", but no comments
> saying so.
>
> Not sure if you want anything done here?
Thanks, I guess this will wait for the merge window to finish. It
should then apply to your tree. I can resend in two weeks.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles
2020-10-09 12:02 ` Thierry Reding
@ 2020-10-12 18:14 ` Rob Herring
-1 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2020-10-12 18:14 UTC (permalink / raw)
To: Thierry Reding
Cc: Krzysztof Kozlowski, linux-pwm, Philipp Zabel, devicetree,
Fabio Estevam, Sascha Hauer, linux-kernel, NXP Linux Team,
Pengutronix Kernel Team, Uwe Kleine-König, Lee Jones,
Shawn Guo, linux-arm-kernel
On Fri, Oct 09, 2020 at 02:02:39PM +0200, Thierry Reding wrote:
> On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote:
> > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > > > warnings like:
> > > >
> > > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> > > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> > > > 1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > index 473863eb67e5..379d693889f6 100644
> > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > @@ -25,6 +25,17 @@ properties:
> > > > - fsl,imx27-pwm
> > > > - items:
> > > > - enum:
> > > > + - fsl,imx25-pwm
> > >
> > > The driver actually used fsl,imx27-pwm to bind ...
> >
> > Yes, most of i.MX drivers use only few compatibles but DTSes and
> > bindings use multiple of them. I was convinced during various talks
> > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
> > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
> > to the another level creating compatibles for absolutely every flavor of
> > their CPU. And they mainlined it in DTSes...
> >
> > The PWM is this crazy examples where, as you say, only two compatibles
> > are actually used for binding but DTSes uses more.
>
> Yeah, these new compatible strings all seem to be used in the kernel, so
> we might as well document them.
>
> That said, I did want to apply this patch, but that fails. Am I missing
> some other patch that you have sent out that touches this file? Actually
> it looks like this is because you've based this patch on linux-next, or
> perhaps the devicetree tree, because that contains commit d058717bdff4
> ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that
> adds a couple more compatible strings. Probably best for Rob to pick
> this up, then:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
> Rob, here's a patchwork link for you if you need one:
>
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/
>
> Although, looking at the devicetree-bindings instance version of that
> patch, I see that it's got a failing check attached (which looks like
> it can be ignored) and it's marked "Changes Requested", but no comments
> saying so.
I was assuming a rename at least.
> Not sure if you want anything done here?
I guess not, so I've applied it.
Rob
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles
@ 2020-10-12 18:14 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2020-10-12 18:14 UTC (permalink / raw)
To: Thierry Reding
Cc: linux-pwm, Pengutronix Kernel Team, devicetree, Lee Jones,
Sascha Hauer, linux-kernel, Krzysztof Kozlowski, NXP Linux Team,
Philipp Zabel, Uwe Kleine-König, Shawn Guo, Fabio Estevam,
linux-arm-kernel
On Fri, Oct 09, 2020 at 02:02:39PM +0200, Thierry Reding wrote:
> On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote:
> > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > > > warnings like:
> > > >
> > > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> > > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> > > > 1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > index 473863eb67e5..379d693889f6 100644
> > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > @@ -25,6 +25,17 @@ properties:
> > > > - fsl,imx27-pwm
> > > > - items:
> > > > - enum:
> > > > + - fsl,imx25-pwm
> > >
> > > The driver actually used fsl,imx27-pwm to bind ...
> >
> > Yes, most of i.MX drivers use only few compatibles but DTSes and
> > bindings use multiple of them. I was convinced during various talks
> > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
> > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
> > to the another level creating compatibles for absolutely every flavor of
> > their CPU. And they mainlined it in DTSes...
> >
> > The PWM is this crazy examples where, as you say, only two compatibles
> > are actually used for binding but DTSes uses more.
>
> Yeah, these new compatible strings all seem to be used in the kernel, so
> we might as well document them.
>
> That said, I did want to apply this patch, but that fails. Am I missing
> some other patch that you have sent out that touches this file? Actually
> it looks like this is because you've based this patch on linux-next, or
> perhaps the devicetree tree, because that contains commit d058717bdff4
> ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that
> adds a couple more compatible strings. Probably best for Rob to pick
> this up, then:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
> Rob, here's a patchwork link for you if you need one:
>
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/
>
> Although, looking at the devicetree-bindings instance version of that
> patch, I see that it's got a failing check attached (which looks like
> it can be ignored) and it's marked "Changes Requested", but no comments
> saying so.
I was assuming a rename at least.
> Not sure if you want anything done here?
I guess not, so I've applied it.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread