From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
leoyang.li@nxp.com, devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: dts: imx: add devicetree for Kobo Libra H2O
Date: Wed, 22 Sep 2021 09:41:39 +0200 [thread overview]
Message-ID: <CAJKOXPfQrfOm=LWh97tq6q16v6aGXazksYF+kYxj5ghd0x7LUg@mail.gmail.com> (raw)
Message-ID: <20210922074139.oijGI3bX6_oWVvHdGFfrE4I0L3g-mqQ5xJQN_oZ2Pv8@z> (raw)
In-Reply-To: <20210918141627.2142457-4-andreas@kemnade.info>
On Sat, 18 Sept 2021 at 16:55, Andreas Kemnade <andreas@kemnade.info> wrote:
>
> This adds a devicetree for the Kobo Libra H2O Ebook reader. It is based on
> boards called e70k02. It is equipped with an imx6sll SoC.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/Makefile | 3 +-
> arch/arm/boot/dts/imx6sll-kobo-librah2o.dts | 339 +++++++++++++++++++++
> 2 files changed, 341 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/imx6sll-kobo-librah2o.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7e0934180724..78fc26ff2cac 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -638,7 +638,8 @@ dtb-$(CONFIG_SOC_IMX6SL) += \
> imx6sl-warp.dtb
> dtb-$(CONFIG_SOC_IMX6SLL) += \
> imx6sll-evk.dtb \
> - imx6sll-kobo-clarahd.dtb
> + imx6sll-kobo-clarahd.dtb \
> + imx6sll-kobo-librah2o.dtb
> dtb-$(CONFIG_SOC_IMX6SX) += \
> imx6sx-nitrogen6sx.dtb \
> imx6sx-sabreauto.dtb \
> diff --git a/arch/arm/boot/dts/imx6sll-kobo-librah2o.dts b/arch/arm/boot/dts/imx6sll-kobo-librah2o.dts
> new file mode 100644
> index 000000000000..44522f6a54ca
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6sll-kobo-librah2o.dts
> @@ -0,0 +1,339 @@
> +// SPDX-License-Identifier: (GPL-2.0)
> +/*
> + * Device tree for the Kobo Libra H2O ebook reader
> + *
> + * Name on mainboard is: 37NB-E70K0M+6A3
> + * Serials start with: E70K02 (a number also seen in
> + * vendor kernel sources)
> + *
> + * This mainboard seems to be equipped with different SoCs.
> + * In the Kobo Libra H2O ebook reader it is an i.MX6SLL
> + *
> + * Copyright 2021 Andreas Kemnade
> + * based on works
> + * Copyright 2016 Freescale Semiconductor, Inc.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include "imx6sll.dtsi"
> +#include "e70k02.dtsi"
> +
> +/ {
> + model = "Kobo Libra H2O";
> + compatible = "kobo,librah2o", "fsl,imx6sll";
> +};
> +
> +&clks {
> + assigned-clocks = <&clks IMX6SLL_CLK_PLL4_AUDIO_DIV>;
> + assigned-clock-rates = <393216000>;
> +};
> +
> +&cpu0 {
> + arm-supply = <&dcdc3_reg>;
> + soc-supply = <&dcdc1_reg>;
> +};
> +
> +&gpio_keys {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_keys>;
> +};
> +
> +&i2c1 {
> + pinctrl-names = "default","sleep";
> + pinctrl-0 = <&pinctrl_i2c1>;
> + pinctrl-1 = <&pinctrl_i2c1_sleep>;
> +};
> +
> +&i2c2 {
> + pinctrl-names = "default","sleep";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + pinctrl-1 = <&pinctrl_i2c2_sleep>;
> +};
> +
> +&i2c3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c3>;
> +};
> +
> +&iomuxc {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hog>;
> +
> + pinctrl_gpio_keys: gpio-keysgrp {
> + fsl,pins = <
> + MX6SLL_PAD_GPIO4_IO25__GPIO4_IO25 0x17059 /* PWR_SW */
> + MX6SLL_PAD_GPIO4_IO23__GPIO4_IO23 0x17059 /* HALL_EN */
> + MX6SLL_PAD_KEY_COL4__GPIO4_IO00 0x17059 /* PAGE_UP */
> + MX6SLL_PAD_KEY_COL5__GPIO4_IO02 0x17059 /* PAGE_DOWN */
> + >;
> + };
> +
> + pinctrl_hog: hoggrp {
> + fsl,pins = <
> + MX6SLL_PAD_LCD_DATA01__GPIO2_IO21 0x79
> + MX6SLL_PAD_LCD_DATA04__GPIO2_IO24 0x79
> + MX6SLL_PAD_LCD_DATA05__GPIO2_IO25 0x79
> + MX6SLL_PAD_LCD_DATA06__GPIO2_IO26 0x79
> + MX6SLL_PAD_LCD_DATA07__GPIO2_IO27 0x79
> + MX6SLL_PAD_LCD_DATA08__GPIO2_IO28 0x79
> + MX6SLL_PAD_LCD_DATA09__GPIO2_IO29 0x79
> + MX6SLL_PAD_LCD_DATA10__GPIO2_IO30 0x79
> + MX6SLL_PAD_LCD_DATA11__GPIO2_IO31 0x79
> + MX6SLL_PAD_LCD_DATA12__GPIO3_IO00 0x79
> + MX6SLL_PAD_LCD_DATA13__GPIO3_IO01 0x79
> + MX6SLL_PAD_LCD_DATA14__GPIO3_IO02 0x79
> + MX6SLL_PAD_LCD_DATA15__GPIO3_IO03 0x79
> + MX6SLL_PAD_LCD_DATA16__GPIO3_IO04 0x79
> + MX6SLL_PAD_LCD_DATA17__GPIO3_IO05 0x79
> + MX6SLL_PAD_LCD_DATA18__GPIO3_IO06 0x79
> + MX6SLL_PAD_LCD_DATA19__GPIO3_IO07 0x79
> + MX6SLL_PAD_LCD_DATA20__GPIO3_IO08 0x79
> + MX6SLL_PAD_LCD_DATA21__GPIO3_IO09 0x79
> + MX6SLL_PAD_LCD_DATA22__GPIO3_IO10 0x79
> + MX6SLL_PAD_LCD_DATA23__GPIO3_IO11 0x79
> + MX6SLL_PAD_LCD_CLK__GPIO2_IO15 0x79
> + MX6SLL_PAD_LCD_ENABLE__GPIO2_IO16 0x79
> + MX6SLL_PAD_LCD_HSYNC__GPIO2_IO17 0x79
> + MX6SLL_PAD_LCD_VSYNC__GPIO2_IO18 0x79
> + MX6SLL_PAD_LCD_RESET__GPIO2_IO19 0x79
> + MX6SLL_PAD_GPIO4_IO21__GPIO4_IO21 0x79
> + MX6SLL_PAD_GPIO4_IO26__GPIO4_IO26 0x79
> + MX6SLL_PAD_KEY_COL3__GPIO3_IO30 0x79
> + MX6SLL_PAD_KEY_ROW7__GPIO4_IO07 0x79
> + MX6SLL_PAD_ECSPI2_MOSI__GPIO4_IO13 0x79
> + >;
> + };
> +
> + pinctrl_i2c1: i2c1grp {
> + fsl,pins = <
> + MX6SLL_PAD_I2C1_SCL__I2C1_SCL 0x4001f8b1
> + MX6SLL_PAD_I2C1_SDA__I2C1_SDA 0x4001f8b1
> + >;
> + };
> +
> + pinctrl_i2c1_sleep: i2c1grp-sleep {
> + fsl,pins = <
> + MX6SLL_PAD_I2C1_SCL__I2C1_SCL 0x400108b1
> + MX6SLL_PAD_I2C1_SDA__I2C1_SDA 0x400108b1
> + >;
> + };
> +
> + pinctrl_i2c2: i2c2grp {
> + fsl,pins = <
> + MX6SLL_PAD_I2C2_SCL__I2C2_SCL 0x4001f8b1
> + MX6SLL_PAD_I2C2_SDA__I2C2_SDA 0x4001f8b1
> + >;
> + };
> +
> + pinctrl_i2c2_sleep: i2c2grp-sleep {
> + fsl,pins = <
> + MX6SLL_PAD_I2C2_SCL__I2C2_SCL 0x400108b1
> + MX6SLL_PAD_I2C2_SDA__I2C2_SDA 0x400108b1
> + >;
> + };
> +
> + pinctrl_i2c3: i2c3grp {
> + fsl,pins = <
> + MX6SLL_PAD_REF_CLK_24M__I2C3_SCL 0x4001f8b1
> + MX6SLL_PAD_REF_CLK_32K__I2C3_SDA 0x4001f8b1
> + >;
> + };
> +
> + pinctrl_led: ledgrp {
> + fsl,pins = <
> + MX6SLL_PAD_GPIO4_IO17__GPIO4_IO17 0x10059
> + >;
> + };
> +
> + pinctrl_lm3630a_bl_gpio: lm3630a-bl-gpiogrp {
> + fsl,pins = <
> + MX6SLL_PAD_EPDC_PWR_CTRL3__GPIO2_IO10 0x10059 /* HWEN */
> + >;
> + };
> +
> + pinctrl_ricoh_gpio: ricoh-gpiogrp {
> + fsl,pins = <
> + MX6SLL_PAD_GPIO4_IO20__GPIO4_IO20 0x1b8b1 /* ricoh619 chg */
> + MX6SLL_PAD_GPIO4_IO19__GPIO4_IO19 0x1b8b1 /* ricoh619 irq */
> + MX6SLL_PAD_KEY_COL2__GPIO3_IO28 0x1b8b1 /* ricoh619 bat_low_int */
> + >;
> + };
> +
> + pinctrl_uart1: uart1grp {
> + fsl,pins = <
> + MX6SLL_PAD_UART1_TXD__UART1_DCE_TX 0x1b0b1
> + MX6SLL_PAD_UART1_RXD__UART1_DCE_RX 0x1b0b1
> + >;
> + };
> +
> + pinctrl_usbotg1: usbotg1grp {
> + fsl,pins = <
> + MX6SLL_PAD_EPDC_PWR_COM__USB_OTG1_ID 0x17059
> + >;
> + };
> +
> + pinctrl_usdhc1: usdhc1grp {
> + fsl,pins = <
> + MX6SLL_PAD_SD1_CMD__SD1_CMD 0x17059
> + MX6SLL_PAD_SD1_CLK__SD1_CLK 0x17059
> + MX6SLL_PAD_SD1_DATA0__SD1_DATA0 0x17059
> + MX6SLL_PAD_SD1_DATA1__SD1_DATA1 0x17059
> + MX6SLL_PAD_SD1_DATA2__SD1_DATA2 0x17059
> + MX6SLL_PAD_SD1_DATA3__SD1_DATA3 0x17059
> + MX6SLL_PAD_SD1_DATA4__SD1_DATA4 0x17059
> + MX6SLL_PAD_SD1_DATA5__SD1_DATA5 0x17059
> + MX6SLL_PAD_SD1_DATA6__SD1_DATA6 0x17059
> + MX6SLL_PAD_SD1_DATA7__SD1_DATA7 0x17059
> + >;
> + };
> +
> + pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {
Thanks for the patch.
This does not look like passing the schema validation. Please run
dtbs_check. The node names should use hyphens and end with "grp"
suffix. This remark applies to other cases below.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-22 7:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 14:16 [PATCH 0/4] ARM: dts: add E70K02 based eBook readers Andreas Kemnade
2021-09-18 14:16 ` Andreas Kemnade
2021-09-18 14:16 ` [PATCH 1/4] dt-bindings: arm: fsl: Add E70K02 based ebook readers Andreas Kemnade
2021-09-18 14:16 ` Andreas Kemnade
2021-09-22 20:51 ` Rob Herring
2021-09-22 20:51 ` Rob Herring
2021-09-18 14:16 ` [PATCH 2/4] ARM: dts: add Netronix E70K02 board common file Andreas Kemnade
2021-09-18 14:16 ` Andreas Kemnade
2021-09-18 14:16 ` [PATCH 3/4] ARM: dts: imx: add devicetree for Kobo Libra H2O Andreas Kemnade
2021-09-18 14:16 ` Andreas Kemnade
2021-09-22 7:41 ` Krzysztof Kozlowski [this message]
2021-09-22 7:41 ` Krzysztof Kozlowski
2021-09-22 20:38 ` Andreas Kemnade
2021-09-22 20:38 ` Andreas Kemnade
2021-09-23 6:26 ` Krzysztof Kozlowski
2021-09-23 6:26 ` Krzysztof Kozlowski
2021-09-23 10:54 ` Andreas Kemnade
2021-09-23 10:54 ` Andreas Kemnade
2021-09-18 14:16 ` [PATCH 4/4] ARM: dts: imx: add devicetree for Tolino Vision 5 Andreas Kemnade
2021-09-18 14:16 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPfQrfOm=LWh97tq6q16v6aGXazksYF+kYxj5ghd0x7LUg@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.