All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luming Yu <luming.yu@gmail.com>
To: Nick Piggin <npiggin@gmail.com>
Cc: Alex Shi <alex.shi@intel.com>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	arnd@arndb.de, rostedt@goodmis.org, fweisbec@gmail.com,
	jeremy@goop.org, riel@redhat.com, luto@mit.edu, avi@redhat.com,
	len.brown@intel.com, dhowells@redhat.com, fenghua.yu@intel.com,
	borislav.petkov@amd.com, yinghai@kernel.org, ak@linux.intel.com,
	cpw@sgi.com, steiner@sgi.com, akpm@linux-foundation.org,
	penberg@kernel.org, hughd@google.com, rientjes@google.com,
	kosaki.motohiro@jp.fujitsu.com, n-horiguchi@ah.jp.nec.com,
	tj@kernel.org, oleg@redhat.com, axboe@kernel.dk,
	jmorris@namei.org, a.p.zijlstra@chello.nl,
	kamezawa.hiroyu@jp.fujitsu.com, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, yongjie.ren@intel.com,
	linux-arch@vger.kernel.org, jcm@jonmasters.org
Subject: Re: [PATCH v5 6/7] x86/tlb: optimizing flush_tlb_mm
Date: Tue, 15 May 2012 20:58:54 +0800	[thread overview]
Message-ID: <CAJRGBZy0S_fg3GY4S5CG-2SWv5AG1jMrcMMqCiTg=7xyD1mrzQ@mail.gmail.com> (raw)
In-Reply-To: <CAPa8GCADw7cn+cGukfy6=gEJAqV2Ef3=YFcPriuPmhpE-xvX7A@mail.gmail.com>

On Tue, May 15, 2012 at 5:17 PM, Nick Piggin <npiggin@gmail.com> wrote:
> On 15 May 2012 19:15, Nick Piggin <npiggin@gmail.com> wrote:
>> So this should go to linux-arch...
>>
>> On 15 May 2012 18:55, Alex Shi <alex.shi@intel.com> wrote:
>>> Not every flush_tlb_mm execution moment is really need to evacuate all
>>> TLB entries, like in munmap, just few 'invlpg' is better for whole
>>> process performance, since it leaves most of TLB entries for later
>>> accessing.
>
> Did you have microbenchmarks for this like your mprotect numbers,
> by the way? Test munmap numbers and see how that looks. Also,

Might be off topic, but I just spent few minutes to test out the difference
between write CR3 vs. invlpg on a pretty old but still reliable P4 desktop
with my simple hardware latency and bandwidth test tool I posted for
RFC several weeks ago on LKML.

Both __native_flush_tlb() and __native_flush_tlb_single(...)
introduced roughly 1 ns  latency to tsc sampling executed in
stop_machine_context in two logical CPUs

Just to fuel the discussion. :-)

Cheers,
/l

  reply	other threads:[~2012-05-15 12:58 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15  8:55 [PATCH v5 0/7] tlb flush optimization for x86 Alex Shi
2012-05-15  8:55 ` [PATCH v5 1/7] x86/tlb: unify TLB_FLUSH_ALL definition Alex Shi
2012-05-15  8:55 ` [PATCH v5 2/7] x86/tlb_info: get last level TLB entry number of CPU Alex Shi
2012-05-15  8:55 ` [PATCH v5 3/7] x86/flush_tlb: try flush_tlb_single one by one in flush_tlb_range Alex Shi
2012-05-15  8:55 ` [PATCH v5 4/7] x86/tlb: fall back to flush all when meet a THP large page Alex Shi
2012-05-15  8:55 ` [PATCH v5 5/7] x86/tlb: add tlb_flushall_shift for specific CPU Alex Shi
2012-05-16  6:49   ` Alex Shi
2012-05-16 17:55     ` H. Peter Anvin
2012-05-17  1:46       ` Alex Shi
2012-05-15  8:55 ` [PATCH v5 6/7] x86/tlb: optimizing flush_tlb_mm Alex Shi
2012-05-15  9:11   ` Peter Zijlstra
2012-05-15  9:15   ` Nick Piggin
2012-05-15  9:17     ` Nick Piggin
2012-05-15 12:58       ` Luming Yu [this message]
2012-05-15 13:06         ` Peter Zijlstra
2012-05-15 13:27           ` Luming Yu
2012-05-15 13:28             ` Alex Shi
2012-05-15 13:33           ` Alex Shi
2012-05-15 13:39           ` Steven Rostedt
2012-05-15 14:04             ` Borislav Petkov
2012-05-15 13:08         ` Luming Yu
2012-05-15 14:07       ` Alex Shi
2012-05-15  9:18     ` Peter Zijlstra
2012-05-15  9:52       ` Nick Piggin
2012-05-15 10:00         ` Peter Zijlstra
2012-05-15 10:06           ` Nick Piggin
2012-05-15 10:13             ` Peter Zijlstra
2012-05-15 14:04       ` Alex Shi
2012-05-15 13:24     ` Alex Shi
2012-05-15 14:36       ` Peter Zijlstra
2012-05-15 14:57         ` Peter Zijlstra
2012-05-15 15:01           ` Alex Shi
2012-05-16  6:46           ` Alex Shi
2012-05-16  6:46             ` Alex Shi
2012-05-16  8:00             ` Peter Zijlstra
2012-05-16  8:04               ` Peter Zijlstra
2012-05-16  8:53                 ` Alex Shi
2012-05-16  8:58                   ` Peter Zijlstra
2012-05-16 10:58                     ` Alex Shi
2012-05-16 11:04                       ` Peter Zijlstra
2012-05-16 12:57                         ` Alex Shi
2012-05-16 13:34               ` Alex Shi
2012-05-16 13:34                 ` Alex Shi
2012-05-16 21:09                 ` Peter Zijlstra
2012-05-17  0:43                   ` Alex Shi
2012-05-17  2:07                     ` Steven Rostedt
2012-05-17  8:04                       ` Alex Shi
2012-05-17  2:14                   ` Paul Mundt
2012-05-16 13:44               ` Alex Shi
2012-05-15  8:55 ` [PATCH v5 7/7] x86/tlb: add tlb_flushall_shift knob into debugfs Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJRGBZy0S_fg3GY4S5CG-2SWv5AG1jMrcMMqCiTg=7xyD1mrzQ@mail.gmail.com' \
    --to=luming.yu@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@intel.com \
    --cc=arnd@arndb.de \
    --cc=avi@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=borislav.petkov@amd.com \
    --cc=cpw@sgi.com \
    --cc=dhowells@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=jcm@jonmasters.org \
    --cc=jeremy@goop.org \
    --cc=jmorris@namei.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=len.brown@intel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mingo@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=npiggin@gmail.com \
    --cc=oleg@redhat.com \
    --cc=penberg@kernel.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yinghai@kernel.org \
    --cc=yongjie.ren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.