All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Alex Shi <alex.shi@intel.com>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	arnd@arndb.de, rostedt@goodmis.org, fweisbec@gmail.com,
	jeremy@goop.org, riel@redhat.com, luto@mit.edu, avi@redhat.com,
	len.brown@intel.com, dhowells@redhat.com, fenghua.yu@intel.com,
	borislav.petkov@amd.com, yinghai@kernel.org, ak@linux.intel.com,
	cpw@sgi.com, steiner@sgi.com, akpm@linux-foundation.org,
	penberg@kernel.org, hughd@google.com, rientjes@google.com,
	kosaki.motohiro@jp.fujitsu.com, n-horiguchi@ah.jp.nec.com,
	tj@kernel.org, oleg@redhat.com, axboe@kernel.dk,
	jmorris@namei.org, kamezawa.hiroyu@jp.fujitsu.com,
	viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
	yongjie.ren@intel.com, linux-arch@vger.kernel.org
Subject: Re: [PATCH v5 6/7] x86/tlb: optimizing flush_tlb_mm
Date: Tue, 15 May 2012 19:52:58 +1000	[thread overview]
Message-ID: <CAPa8GCBaQhksvVT9DAgwzPPkCMrhcYnSdCtUHEe=cQS8_Cm7DQ@mail.gmail.com> (raw)
In-Reply-To: <1337073529.27694.8.camel@twins>

On 15 May 2012 19:18, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Tue, 2012-05-15 at 19:15 +1000, Nick Piggin wrote:
>> So this should go to linux-arch...
>>
>> On 15 May 2012 18:55, Alex Shi <alex.shi@intel.com> wrote:
>> > Not every flush_tlb_mm execution moment is really need to evacuate all
>> > TLB entries, like in munmap, just few 'invlpg' is better for whole
>> > process performance, since it leaves most of TLB entries for later
>> > accessing.
>> >
>> > This patch is changing flush_tlb_mm(mm) to flush_tlb_mm(mm, start, end)
>> > in cases.
>>
>> What happened with Peter's comment about using flush_tlb_range for this?
>>
>> flush_tlb_mm() API should just stay unchanged AFAIKS.
>>
>> Then you need to work out the best way to give range info to the tlb/mmu gather
>> API. Possibly passing in the rage for that guy is OK, which x86 can
>> then implement
>> as flush range.
>
> Right, most archs that have tlb_flush_range() do range tracking in
> mmu_gather. Our TLB ops fully support that, there's absolutely no need
> to go change the interface for thos.

It could be warranted to change tlb_flush_mmu to a range API to
avoid doing the per-entry tracking which those architectures do?

The callers have range available easily, so ignoring those could be
noop for generic helpers.

  reply	other threads:[~2012-05-15  9:53 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15  8:55 [PATCH v5 0/7] tlb flush optimization for x86 Alex Shi
2012-05-15  8:55 ` [PATCH v5 1/7] x86/tlb: unify TLB_FLUSH_ALL definition Alex Shi
2012-05-15  8:55 ` [PATCH v5 2/7] x86/tlb_info: get last level TLB entry number of CPU Alex Shi
2012-05-15  8:55 ` [PATCH v5 3/7] x86/flush_tlb: try flush_tlb_single one by one in flush_tlb_range Alex Shi
2012-05-15  8:55 ` [PATCH v5 4/7] x86/tlb: fall back to flush all when meet a THP large page Alex Shi
2012-05-15  8:55 ` [PATCH v5 5/7] x86/tlb: add tlb_flushall_shift for specific CPU Alex Shi
2012-05-16  6:49   ` Alex Shi
2012-05-16 17:55     ` H. Peter Anvin
2012-05-17  1:46       ` Alex Shi
2012-05-15  8:55 ` [PATCH v5 6/7] x86/tlb: optimizing flush_tlb_mm Alex Shi
2012-05-15  9:11   ` Peter Zijlstra
2012-05-15  9:15   ` Nick Piggin
2012-05-15  9:17     ` Nick Piggin
2012-05-15 12:58       ` Luming Yu
2012-05-15 13:06         ` Peter Zijlstra
2012-05-15 13:27           ` Luming Yu
2012-05-15 13:28             ` Alex Shi
2012-05-15 13:33           ` Alex Shi
2012-05-15 13:39           ` Steven Rostedt
2012-05-15 14:04             ` Borislav Petkov
2012-05-15 13:08         ` Luming Yu
2012-05-15 14:07       ` Alex Shi
2012-05-15  9:18     ` Peter Zijlstra
2012-05-15  9:52       ` Nick Piggin [this message]
2012-05-15 10:00         ` Peter Zijlstra
2012-05-15 10:06           ` Nick Piggin
2012-05-15 10:13             ` Peter Zijlstra
2012-05-15 14:04       ` Alex Shi
2012-05-15 13:24     ` Alex Shi
2012-05-15 14:36       ` Peter Zijlstra
2012-05-15 14:57         ` Peter Zijlstra
2012-05-15 15:01           ` Alex Shi
2012-05-16  6:46           ` Alex Shi
2012-05-16  6:46             ` Alex Shi
2012-05-16  8:00             ` Peter Zijlstra
2012-05-16  8:04               ` Peter Zijlstra
2012-05-16  8:53                 ` Alex Shi
2012-05-16  8:58                   ` Peter Zijlstra
2012-05-16 10:58                     ` Alex Shi
2012-05-16 11:04                       ` Peter Zijlstra
2012-05-16 12:57                         ` Alex Shi
2012-05-16 13:34               ` Alex Shi
2012-05-16 13:34                 ` Alex Shi
2012-05-16 21:09                 ` Peter Zijlstra
2012-05-17  0:43                   ` Alex Shi
2012-05-17  2:07                     ` Steven Rostedt
2012-05-17  8:04                       ` Alex Shi
2012-05-17  2:14                   ` Paul Mundt
2012-05-16 13:44               ` Alex Shi
2012-05-15  8:55 ` [PATCH v5 7/7] x86/tlb: add tlb_flushall_shift knob into debugfs Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPa8GCBaQhksvVT9DAgwzPPkCMrhcYnSdCtUHEe=cQS8_Cm7DQ@mail.gmail.com' \
    --to=npiggin@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@intel.com \
    --cc=arnd@arndb.de \
    --cc=avi@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=borislav.petkov@amd.com \
    --cc=cpw@sgi.com \
    --cc=dhowells@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=jeremy@goop.org \
    --cc=jmorris@namei.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=len.brown@intel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mingo@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=oleg@redhat.com \
    --cc=penberg@kernel.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yinghai@kernel.org \
    --cc=yongjie.ren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.