[PATCH 0/8] Remove all use of fedorahosted SRC_URI [YOCTO #11226]

[PATCH 0/8] Remove all use of fedorahosted SRC_URI [YOCTO #11226]

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

Fedorahosted.org was retired on March 1st, 2017.
Replace all fedorahosted.org SRC_URI with source
yoctoproject.org, pagure.io and github.com.

Choong YinThong (8):
  selftest/recipetool: replace fedorahosted.org SRC_URI with
    yoctoproject.org source
  xmlto: replace fedorahosted.org SRC_URI with pagure.io source
  libuser: replace fedorahosted.org SRC_URI with pagure.io source
  logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org
    source
  libnewt: replace fedorahosted.org SRC_URI with pagure.io source
  liberation-fonts: replace fedorahosted.org SRC_URI with pagure.io
    source
  chkconfig: replace fedorahosted.org SRC_URI with github.com source
  cronie: replace fedorahosted.org SRC_URI with github.com source

 meta/lib/oeqa/selftest/recipetool.py                     | 4 ++--
 meta/recipes-devtools/xmlto/xmlto_0.0.28.bb              | 4 ++--
 meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb      | 4 ++--
 meta/recipes-extended/cronie/cronie_1.5.1.bb             | 6 ++++--
 meta/recipes-extended/libuser/libuser_0.62.bb            | 6 +++---
 meta/recipes-extended/logrotate/logrotate_3.9.1.bb       | 4 ++--
 meta/recipes-extended/newt/libnewt_0.52.19.bb            | 4 ++--
 meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb | 4 ++--
 8 files changed, 19 insertions(+), 17 deletions(-)

-- 
2.7.4

[PATCH 1/8] selftest/recipetool: replace fedorahosted.org SRC_URI with yoctoproject.org source

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

fedorahosted.org was retired on March 1st, 2017. This is to
update the SRC_URI to point to yoctoproject.org.

[YOCTO #11226]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/lib/oeqa/selftest/recipetool.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/lib/oeqa/selftest/recipetool.py b/meta/lib/oeqa/selftest/recipetool.py
index d62c8bb..a3667dc 100644
--- a/meta/lib/oeqa/selftest/recipetool.py
+++ b/meta/lib/oeqa/selftest/recipetool.py
@@ -369,13 +369,13 @@ class RecipetoolTests(RecipetoolBase):
         tempsrc = os.path.join(self.tempdir, 'srctree')
         os.makedirs(tempsrc)
         recipefile = os.path.join(self.tempdir, 'logrotate_3.8.7.bb')
-        srcuri = 'https://fedorahosted.org/releases/l/o/logrotate/logrotate-3.8.7.tar.gz'
+        srcuri = 'http://downloads.yoctoproject.org/mirror/sources/logrotate-3.8.7.tar.gz'
         result = runCmd('recipetool create -o %s %s -x %s' % (recipefile, srcuri, tempsrc))
         self.assertTrue(os.path.isfile(recipefile))
         checkvars = {}
         checkvars['LICENSE'] = 'GPLv2'
         checkvars['LIC_FILES_CHKSUM'] = 'file://COPYING;md5=18810669f13b87348459e611d31ab760'
-        checkvars['SRC_URI'] = 'https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.gz'
+        checkvars['SRC_URI'] = 'http://downloads.yoctoproject.org/mirror/sources/logrotate-${PV}.tar.gz'
         checkvars['SRC_URI[md5sum]'] = '99e08503ef24c3e2e3ff74cc5f3be213'
         checkvars['SRC_URI[sha256sum]'] = 'f6ba691f40e30e640efa2752c1f9499a3f9738257660994de70a45fe00d12b64'
         self._test_recipe_contents(recipefile, checkvars, [])
-- 
2.7.4

[PATCH 2/8] xmlto: replace fedorahosted.org SRC_URI with pagure.io source

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

fedorahosted.org was retired on March 1st, 2017. This is to
update the SRC_URI to point to pagure.io. pagure.io is a
replacement for fedorahosted.

[YOCTO #11226]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/recipes-devtools/xmlto/xmlto_0.0.28.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/xmlto/xmlto_0.0.28.bb b/meta/recipes-devtools/xmlto/xmlto_0.0.28.bb
index ce5d1e0..6216d77 100644
--- a/meta/recipes-devtools/xmlto/xmlto_0.0.28.bb
+++ b/meta/recipes-devtools/xmlto/xmlto_0.0.28.bb
@@ -1,11 +1,11 @@
 SUMMARY = "A shell-script tool for converting XML files to various formats"
-HOMEPAGE = "https://fedorahosted.org/xmlto/"
+HOMEPAGE = "https://releases.pagure.org/xmlto/"
 SECTION = "docs/xmlto"
 LICENSE = "GPLv2"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
 
-SRC_URI = "https://fedorahosted.org/releases/x/m/xmlto/xmlto-${PV}.tar.gz \
+SRC_URI = "https://releases.pagure.org/xmlto/xmlto-${PV}.tar.gz \
            file://configure.in-drop-the-test-of-xmllint-and-xsltproc.patch \
            file://catalog.xml \
 "
-- 
2.7.4

[PATCH 3/8] libuser: replace fedorahosted.org SRC_URI with pagure.io source

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

fedorahosted.org was retired on March 1st, 2017. This is to
update the SRC_URI to point to pagure.io. pagure.io is a
replacement for fedorahosted.

[YOCTO #11226]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/recipes-extended/libuser/libuser_0.62.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-extended/libuser/libuser_0.62.bb b/meta/recipes-extended/libuser/libuser_0.62.bb
index 6960d71..1765346 100644
--- a/meta/recipes-extended/libuser/libuser_0.62.bb
+++ b/meta/recipes-extended/libuser/libuser_0.62.bb
@@ -1,8 +1,8 @@
 SUMMARY = "user and group account administration library"
 DESCRIPTION = "The libuser library implements a standardized interface for manipulating and administering user \
 and group accounts"
-HOMEPAGE = "https://fedorahosted.org/libuser/"
-BUGTRACKER = "https://fedorahosted.org/libuser/newticket"
+HOMEPAGE = "https://pagure.io/libuser"
+BUGTRACKER = "https://pagure.io/libuser/issues"
 
 LICENSE = "LGPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=5f30f0716dfdd0d91eb439ebec522ec2 \
@@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=5f30f0716dfdd0d91eb439ebec522ec2 \
 
 SECTION = "base"
 
-SRC_URI = "https://fedorahosted.org/releases/l/i/libuser/libuser-${PV}.tar.xz \
+SRC_URI = "https://releases.pagure.org/libuser/libuser-${PV}.tar.xz \
            file://0001-Check-for-issetugid.patch \
            file://0002-remove-unused-execinfo.h.patch \
            file://0001-modules-files.c-parse_field-fix-string-formating-in-.patch \
-- 
2.7.4

[PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

fedorahosted.org was retired on March 1st, 2017. This is to
update the SRC_URI to point to yoctoproject.org/mirror.

[YOCTO #11226]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
index 9c2dfe0..386c01b 100644
--- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
+++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
@@ -1,6 +1,6 @@
 SUMMARY = "Rotates, compresses, removes and mails system log files"
 SECTION = "console/utils"
-HOMEPAGE = "https://fedorahosted.org/logrotate/"
+HOMEPAGE = "http://downloads.yoctoproject.org"
 LICENSE = "GPLv2"
 
 # TODO: logrotate 3.8.8 adds autotools/automake support, update recipe to use it.
@@ -10,7 +10,7 @@ DEPENDS="coreutils popt"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
 
-SRC_URI = "https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.gz \
+SRC_URI = "http://downloads.yoctoproject.org/mirror/sources/logrotate-${PV}.tar.gz \
            file://act-as-mv-when-rotate.patch \
            file://update-the-manual.patch \
            file://disable-check-different-filesystems.patch \
-- 
2.7.4

[PATCH 5/8] libnewt: replace fedorahosted.org SRC_URI with pagure.io source

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

fedorahosted.org was retired on March 1st, 2017. This is to
update the SRC_URI to point to pagure.io. pagure.io is a
replacement for fedorahosted.

[YOCTO #11226]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/recipes-extended/newt/libnewt_0.52.19.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-extended/newt/libnewt_0.52.19.bb b/meta/recipes-extended/newt/libnewt_0.52.19.bb
index a26ce1f..de76ce2 100644
--- a/meta/recipes-extended/newt/libnewt_0.52.19.bb
+++ b/meta/recipes-extended/newt/libnewt_0.52.19.bb
@@ -8,7 +8,7 @@ shared library needed by programs built with newt, as well as a \
 /usr/bin/dialog replacement called whiptail.  Newt is based on the \
 slang library."
 
-HOMEPAGE = "https://fedorahosted.org/newt/"
+HOMEPAGE = "https://releases.pagure.org/newt/"
 SECTION = "libs"
 
 LICENSE = "LGPLv2"
@@ -17,7 +17,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=5f30f0716dfdd0d91eb439ebec522ec2"
 # slang needs to be >= 2.2
 DEPENDS = "slang popt"
 
-SRC_URI = "https://fedorahosted.org/releases/n/e/newt/newt-${PV}.tar.gz \
+SRC_URI = "https://releases.pagure.org/newt/newt-${PV}.tar.gz \
            file://fix_SHAREDDIR.patch \
            file://cross_ar.patch \
            file://Makefile.in-Add-tinfo-library-to-the-linking-librari.patch \
-- 
2.7.4

[PATCH 6/8] liberation-fonts: replace fedorahosted.org SRC_URI with pagure.io source

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

fedorahosted.org was retired on March 1st, 2017. This is to
update the SRC_URI to point to pagure.io. pagure.io is a
replacement for fedorahosted.

[YOCTO #11226]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb b/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
index bda82e7..74212e7 100644
--- a/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
+++ b/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
@@ -2,7 +2,7 @@ SUMMARY = "Liberation(tm) Fonts"
 DESCRIPTION = "The Liberation(tm) Fonts is a font family originally \
 created by Ascender(c) which aims at metric compatibility with \
 Arial, Times New Roman, Courier New."
-HOMEPAGE = "https://fedorahosted.org/liberation-fonts/"
+HOMEPAGE = "https://releases.pagure.org/liberation-fonts/"
 BUGTRACKER = "https://bugzilla.redhat.com/"
 
 RECIPE_NO_UPDATE_REASON = "2.x depends on fontforge package, which is not yet provided in oe-core"
@@ -17,7 +17,7 @@ inherit allarch fontcache
 
 FONT_PACKAGES = "${PN}"
 
-SRC_URI = "https://fedorahosted.org/releases/l/i/liberation-fonts/liberation-fonts-${PV}.tar.gz \
+SRC_URI = "https://releases.pagure.org/liberation-fonts/liberation-fonts-${PV}.tar.gz \
            file://30-liberation-aliases.conf"
 
 SRC_URI[md5sum] = "4846797ef0fc70b0cbaede2514677c58"
-- 
2.7.4

[PATCH 7/8] chkconfig: replace fedorahosted.org SRC_URI with github.com source

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

fedorahosted.org was retired on March 1st, 2017. This is to update
the SRC_URI to point to github.com.

[YOCTO #11226]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb b/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
index e839026..275388b 100644
--- a/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
+++ b/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
@@ -6,7 +6,7 @@ of the drudgery of manually editing the symbolic links."
 
 RECIPE_NO_UPDATE_REASON = "Version 1.5 requires selinux"
 
-HOMEPAGE = "http://fedorahosted.org/releases/c/h/chkconfig"
+HOMEPAGE = "http://downloads.yoctoproject.org/mirror/sources/"
 
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=5574c6965ae5f583e55880e397fbb018"
@@ -16,7 +16,7 @@ PROVIDES += "virtual/update-alternatives"
 
 PR = "r7"
 
-SRC_URI = "http://fedorahosted.org/releases/c/h/chkconfig/${BPN}-${PV}.tar.bz2 \
+SRC_URI = "http://downloads.yoctoproject.org/mirror/sources/${BPN}-${PV}.tar.bz2 \
            file://replace_caddr_t.patch \
           "
 
-- 
2.7.4

[PATCH 8/8] cronie: replace fedorahosted.org SRC_URI with github.com source

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

fedorahosted.org was retired on March 1st, 2017. This is to
update the SRC_URI to point to github.com.

[YOCTO #11226]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/recipes-extended/cronie/cronie_1.5.1.bb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-extended/cronie/cronie_1.5.1.bb b/meta/recipes-extended/cronie/cronie_1.5.1.bb
index ad616d5..cfb8c21 100644
--- a/meta/recipes-extended/cronie/cronie_1.5.1.bb
+++ b/meta/recipes-extended/cronie/cronie_1.5.1.bb
@@ -3,7 +3,7 @@ DESCRIPTION = "Cronie contains the standard UNIX daemon crond that runs \
 specified programs at scheduled times and related tools. It is based on the \
 original cron and has security and configuration enhancements like the \
 ability to use pam and SELinux."
-HOMEPAGE = "https://fedorahosted.org/cronie/"
+HOMEPAGE = "https://github.com/cronie-crond/cronie/"
 BUGTRACKER = "https://bugzilla.redhat.com"
 
 # Internet Systems Consortium License
@@ -14,7 +14,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=dd2a592170760e1386c769e1043b3722 \
 
 SECTION = "utils"
 
-SRC_URI = "https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz \
+UPSTREAM_CHECK_URI = "https://github.com/cronie-crond/${BPN}/releases/"
+
+SRC_URI = "https://github.com/cronie-crond/cronie/releases/download/cronie-${PV}/cronie-${PV}.tar.gz \
            file://crond.init \
            file://crontab \
            file://crond.service \
-- 
2.7.4

Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 1927 bytes --]

On 3 April 2017 at 05:51, <yin.thong.choong@intel.com> wrote:
>
> From: Choong YinThong <yin.thong.choong@intel.com>
>
> fedorahosted.org was retired on March 1st, 2017. This is to
> update the SRC_URI to point to yoctoproject.org/mirror.

Hi,

Is there a reason not to use https://github.com/logrotate/logrotate ?

Same question applies to the selftest patch as well.

Thanks,
  Jussi

>
>
> [YOCTO #11226]
>
> Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
> ---
>  meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> index 9c2dfe0..386c01b 100644
> --- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> +++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> @@ -1,6 +1,6 @@
>  SUMMARY = "Rotates, compresses, removes and mails system log files"
>  SECTION = "console/utils"
> -HOMEPAGE = "https://fedorahosted.org/logrotate/"
> +HOMEPAGE = "http://downloads.yoctoproject.org"
>  LICENSE = "GPLv2"
>
>  # TODO: logrotate 3.8.8 adds autotools/automake support, update recipe
to use it.
> @@ -10,7 +10,7 @@ DEPENDS="coreutils popt"
>
>  LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
>
> -SRC_URI = "
https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.gz \
> +SRC_URI = "
http://downloads.yoctoproject.org/mirror/sources/logrotate-${PV}.tar.gz \
>             file://act-as-mv-when-rotate.patch \
>             file://update-the-manual.patch \
>             file://disable-check-different-filesystems.patch \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 3244 bytes --]

Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Choong, Yin Thong]

[-- Attachment #1: Type: text/plain, Size: 3021 bytes --]

Hi,
The link seem like create by an individual, no a company or group. Therefore, we decide to drop this link and go for yoctoproject.org/mirror.

Thanks and Regards
Choong YinThong

From: Jussi Kukkonen [mailto:jussi.kukkonen@intel.com]
Sent: Monday, April 3, 2017 3:46 PM
To: Choong, Yin Thong <yin.thong.choong@intel.com>
Cc: Patches and discussions about the oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source



On 3 April 2017 at 05:51, <yin.thong.choong@intel.com<mailto:yin.thong.choong@intel.com>> wrote:
>
> From: Choong YinThong <yin.thong.choong@intel.com<mailto:yin.thong.choong@intel.com>>
>
> fedorahosted.org<http://fedorahosted.org> was retired on March 1st, 2017. This is to
> update the SRC_URI to point to yoctoproject.org/mirror<http://yoctoproject.org/mirror>.

Hi,

Is there a reason not to use https://github.com/logrotate/logrotate ?

Same question applies to the selftest patch as well.

Thanks,
  Jussi

>
>
> [YOCTO #11226]
>
> Signed-off-by: Choong YinThong <yin.thong.choong@intel.com<mailto:yin.thong.choong@intel.com>>
> ---
>  meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb> | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb> b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb>
> index 9c2dfe0..386c01b 100644
> --- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb>
> +++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb>
> @@ -1,6 +1,6 @@
>  SUMMARY = "Rotates, compresses, removes and mails system log files"
>  SECTION = "console/utils"
> -HOMEPAGE = "https://fedorahosted.org/logrotate/"
> +HOMEPAGE = "http://downloads.yoctoproject.org"
>  LICENSE = "GPLv2"
>
>  # TODO: logrotate 3.8.8 adds autotools/automake support, update recipe to use it.
> @@ -10,7 +10,7 @@ DEPENDS="coreutils popt"
>
>  LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760<file:///\\COPYING;md5=18810669f13b87348459e611d31ab760>"
>
> -SRC_URI = "https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.gz<https://fedorahosted.org/releases/l/o/logrotate/logrotate-$%7bPV%7d.tar.gz> \
> +SRC_URI = "http://downloads.yoctoproject.org/mirror/sources/logrotate-${PV}.tar.gz<http://downloads.yoctoproject.org/mirror/sources/logrotate-$%7bPV%7d.tar.gz> \
>             file://act-as-mv-when-rotate.patch \
>             file://update-the-manual.patch \
>             file://disable-check-different-filesystems.patch \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 7228 bytes --]

Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On 3 April 2017 at 10:53, Choong, Yin Thong <yin.thong.choong@intel.com>
wrote:

> Hi,
>
> The link seem like create by an individual, no a company or group.
> Therefore, we decide to drop this link and go for yoctoproject.org/mirror.
>

This is true, there's not that much in the repo itself to create trust. The
major show of trust is here though:
http://pkgs.fedoraproject.org/cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f441454e351
Fedora/Red Hat themselves changed to use this repo when the fedorahosted
repos were EOL'd (see also Red Hat folks working on the github issues in
January).

If the release tarballs have been re-generated and the hashes no longer
match, I'd still prefer modifying the recipe to use github (after manually
diffing to make sure they are the same source release of course) but I can
understand a differing viewpoint in this case.

It would be good to mention the issue in the commit message, whichever way
this is solved.

Thanks,
  Jussi

[-- Attachment #2: Type: text/html, Size: 2041 bytes --]

Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Alexander Kanavin]

On 04/03/2017 11:30 AM, Jussi Kukkonen wrote:

> This is true, there's not that much in the repo itself to create trust.
> The major show of trust is here though:
> http://pkgs.fedoraproject.org/cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f441454e351
> Fedora/Red Hat themselves changed to use this repo when the fedorahosted
> repos were EOL'd (see also Red Hat folks working on the github issues in
> January).
>
> If the release tarballs have been re-generated and the hashes no longer
> match, I'd still prefer modifying the recipe to use github (after
> manually diffing to make sure they are the same source release of
> course) but I can understand a differing viewpoint in this case.
>
> It would be good to mention the issue in the commit message, whichever
> way this is solved.

If github is not trustworthy, I'd say taking the tarball from Debian 
should be good enough. Same applies to chkconfig - we just shouldn't 
self-host these things, as that guarantees support headaches.


Alex

Re: [PATCH 7/8] chkconfig: replace fedorahosted.org SRC_URI with github.com source

[Alexander Kanavin]

On 04/03/2017 05:51 AM, yin.thong.choong@intel.com wrote:

> -SRC_URI = "http://fedorahosted.org/releases/c/h/chkconfig/${BPN}-${PV}.tar.bz2 \
> +SRC_URI = "http://downloads.yoctoproject.org/mirror/sources/${BPN}-${PV}.tar.bz2 \

Where does Fedora take this package from nowadays? Self-hosting these 
things is not a good idea.

Alex

Re: [PATCH 7/8] chkconfig: replace fedorahosted.org SRC_URI with github.com source

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

On 3 April 2017 at 03:51, <yin.thong.choong@intel.com> wrote:
>
> fedorahosted.org was retired on March 1st, 2017. This is to update
> the SRC_URI to point to github.com.
>

Here you say github.com.


> -HOMEPAGE = "http://fedorahosted.org/releases/c/h/chkconfig"
> +HOMEPAGE = "http://downloads.yoctoproject.org/mirror/sources/"
>

HOMEPAGE is optional and this isn't the homepage, so we might as well
delete this.


> -SRC_URI = "http://fedorahosted.org/releases/c/h/chkconfig/${BPN}-
> ${PV}.tar.bz2 \
> +SRC_URI = "http://downloads.yoctoproject.org/mirror/
> sources/${BPN}-${PV}.tar.bz2 \


This isn't github.

Ross

[-- Attachment #2: Type: text/html, Size: 1947 bytes --]

Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

On 3 April 2017 at 09:30, Jussi Kukkonen <jussi.kukkonen@intel.com> wrote:

> This is true, there's not that much in the repo itself to create trust.
> The major show of trust is here though: http://pkgs.fedoraproject.org/
> cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f
> 441454e351
> Fedora/Red Hat themselves changed to use this repo when the fedorahosted
> repos were EOL'd (see also Red Hat folks working on the github issues in
> January).
>

So logrotate was originally hosted on Fedora infrastructure that is then
shut down, a github repository appears and Fedora fetch from that github
repository.  Also the commit in the github repository to change the README
from fedorahosted to github (
https://github.com/logrotate/logrotate/commit/09c4fa8bc6cf2c01bad24d33c3ea69371030c014)
was committed by a Red Hat employee (https://github.com/kdudka).

Whilst there are many official-looking forks on github that are just Some
Guy, this is clearly the new canonical home.

Ross

[-- Attachment #2: Type: text/html, Size: 1805 bytes --]

Re: [PATCH 7/8] chkconfig: replace fedorahosted.org SRC_URI with github.com source

[Choong, Yin Thong]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

Ops. I will fix this as PATCH V2 as what comment from Jussi (on logrotate). I will resubmit the entire changes with PATCH V2 again.

Thanks and Regards
Choong YinThong

From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Monday, April 3, 2017 5:13 PM
To: Choong, Yin Thong <yin.thong.choong@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 7/8] chkconfig: replace fedorahosted.org SRC_URI with github.com source


On 3 April 2017 at 03:51, <yin.thong.choong@intel.com<mailto:yin.thong.choong@intel.com>> wrote:
fedorahosted.org<http://fedorahosted.org> was retired on March 1st, 2017. This is to update
the SRC_URI to point to github.com<http://github.com>.

Here you say github.com<http://github.com>.

-HOMEPAGE = "http://fedorahosted.org/releases/c/h/chkconfig"
+HOMEPAGE = "http://downloads.yoctoproject.org/mirror/sources/"

HOMEPAGE is optional and this isn't the homepage, so we might as well delete this.

-SRC_URI = "http://fedorahosted.org/releases/c/h/chkconfig/${BPN}-${PV}.tar.bz2<http://fedorahosted.org/releases/c/h/chkconfig/$%7bBPN%7d-$%7bPV%7d.tar.bz2> \
+SRC_URI = "http://downloads.yoctoproject.org/mirror/sources/${BPN}-${PV}.tar.bz2<http://downloads.yoctoproject.org/mirror/sources/$%7bBPN%7d-$%7bPV%7d.tar.bz2> \

This isn't github.

Ross

[-- Attachment #2: Type: text/html, Size: 5722 bytes --]

Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Choong, Yin Thong]

[-- Attachment #1.1: Type: text/plain, Size: 3695 bytes --]

Hi,
Once I change to github.com below error pop out. Seem like it miss align with the patch compare with github.com logrotate source. Both package seem got miss align on the version. When I compare yoctoproject logrotate.c and github logrotate.c it has big different (as attached), there even got different parameter count on some API function. Let’s stick with yoctoproject.org/mirror 1st ? Or I check back the github to get for suitable version? Then I may need to rename bbrecipe filename base on the github version? Suggestion?

https://downloads.yoctoproject.org/mirror/sources/logrotate-3.9.1.tar.gz
https://github.com/logrotate/logrotate/archive/r3-9-1.tar.gz

ERROR: logrotate-3.9.1-r0 do_patch: Command Error: 'quilt --quiltrc /home/yinthong/rebeccapoky/build/tmp/work/i586-poky-linux/logrotate/3.9.1-r0/recipe-sysroot-native/etc/quiltrc push' exited with 0  Output:
Applying patch act-as-mv-when-rotate.patch
can't find file to patch at input line 20
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|From 68f29ab490cf987aa34b5f4caf1784b58a021308 Mon Sep 17 00:00:00 2001
|From: Robert Yang <liezhi.yang@windriver.com>
|Date: Tue, 17 Feb 2015 21:08:07 -0800
|Subject: [PATCH] Act as the "mv" command when rotate log
|
|Act as the "mv" command when rotate log, first rename, if failed, then
|read and write.
|
|Upstream-Status: Pending
|
|Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
|---
| logrotate.c |   71 +++++++++++++++++++++++++++++++++++++++++++++++++----------
| 1 file changed, 59 insertions(+), 12 deletions(-)
|
|diff --git a/logrotate.c b/logrotate.c
|index d3deb6a..cf8bf2c 100644
|--- a/logrotate.c
|+++ b/logrotate.c
--------------------------
No file to patch.  Skipping patch.
6 out of 6 hunks ignored
Patch act-as-mv-when-rotate.patch does not apply (enforce with -f)
ERROR: logrotate-3.9.1-r0 do_patch: Function failed: patch_do_patch
ERROR: Logfile of failure stored in: /home/yinthong/rebeccapoky/build/tmp/work/i586-poky-linux/logrotate/3.9.1-r0/temp/log.do_patch.130676
ERROR: Task (/home/yinthong/rebeccapoky/meta/recipes-extended/logrotate/logrotate_3.9.1.bb:do_patch) failed with exit code '1'

Thanks and Regards
Choong YinThong

From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Monday, April 3, 2017 5:17 PM
To: Kukkonen, Jussi <jussi.kukkonen@intel.com>
Cc: Choong, Yin Thong <yin.thong.choong@intel.com>; Patches and discussions about the oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source


On 3 April 2017 at 09:30, Jussi Kukkonen <jussi.kukkonen@intel.com<mailto:jussi.kukkonen@intel.com>> wrote:
This is true, there's not that much in the repo itself to create trust. The major show of trust is here though: http://pkgs.fedoraproject.org/cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f441454e351
Fedora/Red Hat themselves changed to use this repo when the fedorahosted repos were EOL'd (see also Red Hat folks working on the github issues in January).

So logrotate was originally hosted on Fedora infrastructure that is then shut down, a github repository appears and Fedora fetch from that github repository.  Also the commit in the github repository to change the README from fedorahosted to github (https://github.com/logrotate/logrotate/commit/09c4fa8bc6cf2c01bad24d33c3ea69371030c014) was committed by a Red Hat employee (https://github.com/kdudka).

Whilst there are many official-looking forks on github that are just Some Guy, this is clearly the new canonical home.

Ross

[-- Attachment #1.2: Type: text/html, Size: 14167 bytes --]

[-- Attachment #2: 1styocto_2ndgithub_logrotate.diff --]
[-- Type: application/octet-stream, Size: 3102 bytes --]

1159a1160,1206
> /* Act as the "mv" command, if rename failed, then read the old file and
>  * write to new file. The function which invokes the mvFile will use
>  * the strerror(errorno) to handle the error message, so we don't have
>  * to print the error message here */
> 
> int mvFile (char *oldName, char *newName, struct logInfo *log, acl_type acl)
> {
>     struct stat sbprev;
>     int fd_old, fd_new, n;
>     char buf[BUFSIZ];
> 
>     /* Do the rename first */
>     if (!rename(oldName, newName))
>         return 0;
> 
>     /* If the errno is EXDEV, then read old file, write newfile and
>      * remove the oldfile */
>     if (errno == EXDEV) {
>         /* Open the old file to read */
>         if ((fd_old = open(oldName, O_RDONLY)) < 0)
>             return 1;
> 
>         /* Create the file to write, keep the same attribute as the old file */
>         if (stat(oldName, &sbprev))
>             return 1;
>         else {
>             if ((fd_new = createOutputFile(newName,
>                 O_WRONLY | O_CREAT | O_TRUNC, &sbprev, acl, 0)) < 0 )
>                 return 1;
>         }
> 
>         /* Read and write */
>         while ((n = read(fd_old, buf, BUFSIZ)) > 0)
>             if (write(fd_new, buf, n) != n)
>                 return 1;
> 
>         if ((close(fd_old) < 0) ||
>             removeLogFile(oldName, log) ||
>             (close(fd_new) < 0))
>             return 1;
> 
>         return 0;
>     }
> 
>     return 1;
> }
> 
1526c1573
< 		    "renaming %s to %s (rotatecount %d, logstart %d, i %d), \n",
---
> 		    "moving %s to %s (rotatecount %d, logstart %d, i %d), \n",
1529c1576
< 	    if (!debug && rename(oldName, newName)) {
---
> 	    if (!debug && mvFile(oldName, newName, log, prev_acl)) {
1534c1581
< 		    message(MESS_ERROR, "error renaming %s to %s: %s\n",
---
> 		    message(MESS_ERROR, "error moving %s to %s: %s\n",
1672c1719
< 			message(MESS_DEBUG, "renaming %s to %s\n", log->files[logNum],
---
> 			message(MESS_DEBUG, "moving %s to %s\n", log->files[logNum],
1674,1675c1721,1722
< 			if (!debug && !hasErrors && rename(log->files[logNum], tmpFilename)) {
< 			message(MESS_ERROR, "failed to rename %s to %s: %s\n",
---
> 			if (!debug && !hasErrors && mvFile(log->files[logNum], rotNames->finalName, log, prev_acl)) {
> 			message(MESS_ERROR, "failed to move %s to %s: %s\n",
1682c1729
< 			message(MESS_DEBUG, "renaming %s to %s\n", log->files[logNum],
---
> 			message(MESS_DEBUG, "moving %s to %s\n", log->files[logNum],
1685,1686c1732,1733
< 			rename(log->files[logNum], rotNames->finalName)) {
< 				message(MESS_ERROR, "failed to rename %s to %s: %s\n",
---
> 			mvFile(log->files[logNum], rotNames->finalName, log, prev_acl)) {
> 				message(MESS_ERROR, "failed to move %s to %s: %s\n",
2066c2113
< static int writeState(char *stateFilename)
---
> static int writeState(struct logInfo *log, char *stateFilename)
2230c2277
< 		if (rename(tmpFilename, stateFilename)) {
---
> 		if (mvFile(tmpFilename, stateFilename, log, prev_acl)) {
2528c2575
< 		rc |= writeState(stateFile);
---
> 		rc |= writeState(log, stateFile);

Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

On 3 April 2017 at 12:00, Choong, Yin Thong <yin.thong.choong@intel.com>
wrote:

> https://downloads.yoctoproject.org/mirror/sources/logrotate-3.9.1.tar.gz
>
> https://github.com/logrotate/logrotate/archive/r3-9-1.tar.gz
>
>
Annoyingly the /archive/ links on github are generated on demand by 'git
archive' so only contain the exact contents of the git archive and will not
be identical to the tarballs.

As the maintainer has been uploading generated tarballs for new releases
(3.9.2, etc) it's probably work asking him if he'd be willing to upload the
older tarballs too.

Ross

[-- Attachment #2: Type: text/html, Size: 1713 bytes --]

Re: [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

On 3 April 2017 at 14:00, Choong, Yin Thong <yin.thong.choong@intel.com>
wrote:
>
> Hi,
> Once I change to github.com below error pop out. Seem like it miss align
with the patch compare with github.com logrotate source. Both package seem
got miss align on the version. When I compare yoctoproject logrotate.c and
github logrotate.c it has big different (as attached), there even got
different parameter count on some API function


Ross's  suggestion of asking the maintainer is good but I'll note that
there does not seem to be any difference in the actual source files: you're
maybe looking at a different version.

The patching error is a result of the top level source directory name
changing. This could be worked around with
  S = "${WORKDIR}/logrotate-r3-9-1"

Jussi

[-- Attachment #2: Type: text/html, Size: 1010 bytes --]