[PATCH] PM / devfreq: passive: Return non-error when not-supported event is required

[PATCH] PM / devfreq: passive: Return non-error when not-supported event is required

[Chanwoo Choi]

Each devfreq governor specifies the supported governor event
such as GOV_START and GOV_STOP. When not-supported event is required,
just return non-error. But, commit ce9a0d88d97a ("PM / devfreq: Add
cpu based scaling support to passive governor") returned the error
value. So that return non-error value when not-supported event is required.

Fixes: ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
Dear Rafael,

This patch fixes the issue of the pull request[1].
I'd like you to apply it to linux-pm.git direclty.
[1] https://patchwork.kernel.org/project/linux-pm/patch/3acd6c32-6e78-dfc2-3e45-84f69a7d5f36@samsung.com/

Best Regards,
Chanwoo Choi

 drivers/devfreq/governor_passive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
index 7306e943a234..72c67979ebe1 100644
--- a/drivers/devfreq/governor_passive.c
+++ b/drivers/devfreq/governor_passive.c
@@ -402,7 +402,7 @@ static int devfreq_passive_event_handler(struct devfreq *devfreq,
 {
 	struct devfreq_passive_data *p_data
 			= (struct devfreq_passive_data *)devfreq->data;
-	int ret = -EINVAL;
+	int ret = 0;
 
 	if (!p_data)
 		return -EINVAL;
-- 
2.17.1

Re: [PATCH] PM / devfreq: passive: Return non-error when not-supported event is required

[Rafael J. Wysocki]

On Thu, May 19, 2022 at 2:42 AM Chanwoo Choi <cw00.choi@samsung.com> wrote:
>
> Each devfreq governor specifies the supported governor event
> such as GOV_START and GOV_STOP. When not-supported event is required,
> just return non-error. But, commit ce9a0d88d97a ("PM / devfreq: Add
> cpu based scaling support to passive governor") returned the error
> value. So that return non-error value when not-supported event is required.
>
> Fixes: ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor")
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Dear Rafael,
>
> This patch fixes the issue of the pull request[1].
> I'd like you to apply it to linux-pm.git direclty.
> [1] https://patchwork.kernel.org/project/linux-pm/patch/3acd6c32-6e78-dfc2-3e45-84f69a7d5f36@samsung.com/
>
> Best Regards,
> Chanwoo Choi
>
>  drivers/devfreq/governor_passive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
> index 7306e943a234..72c67979ebe1 100644
> --- a/drivers/devfreq/governor_passive.c
> +++ b/drivers/devfreq/governor_passive.c
> @@ -402,7 +402,7 @@ static int devfreq_passive_event_handler(struct devfreq *devfreq,
>  {
>         struct devfreq_passive_data *p_data
>                         = (struct devfreq_passive_data *)devfreq->data;
> -       int ret = -EINVAL;
> +       int ret = 0;
>
>         if (!p_data)
>                 return -EINVAL;
> --

Applied, thanks!