* [PATCH] PM / devfreq: passive: Return non-error when not-supported event is required [not found] <CGME20220519004138epcas1p1cb026c559dacbf3f8525910293b2de89@epcas1p1.samsung.com> @ 2022-05-19 1:07 ` Chanwoo Choi 2022-05-19 17:33 ` Rafael J. Wysocki 0 siblings, 1 reply; 2+ messages in thread From: Chanwoo Choi @ 2022-05-19 1:07 UTC (permalink / raw) To: rjw Cc: linux-pm, linux-kernel, m.szyprowski, cw00.choi, chanwoo, myungjoo.ham, kyungmin.park Each devfreq governor specifies the supported governor event such as GOV_START and GOV_STOP. When not-supported event is required, just return non-error. But, commit ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor") returned the error value. So that return non-error value when not-supported event is required. Fixes: ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor") Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- Dear Rafael, This patch fixes the issue of the pull request[1]. I'd like you to apply it to linux-pm.git direclty. [1] https://patchwork.kernel.org/project/linux-pm/patch/3acd6c32-6e78-dfc2-3e45-84f69a7d5f36@samsung.com/ Best Regards, Chanwoo Choi drivers/devfreq/governor_passive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c index 7306e943a234..72c67979ebe1 100644 --- a/drivers/devfreq/governor_passive.c +++ b/drivers/devfreq/governor_passive.c @@ -402,7 +402,7 @@ static int devfreq_passive_event_handler(struct devfreq *devfreq, { struct devfreq_passive_data *p_data = (struct devfreq_passive_data *)devfreq->data; - int ret = -EINVAL; + int ret = 0; if (!p_data) return -EINVAL; -- 2.17.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / devfreq: passive: Return non-error when not-supported event is required 2022-05-19 1:07 ` [PATCH] PM / devfreq: passive: Return non-error when not-supported event is required Chanwoo Choi @ 2022-05-19 17:33 ` Rafael J. Wysocki 0 siblings, 0 replies; 2+ messages in thread From: Rafael J. Wysocki @ 2022-05-19 17:33 UTC (permalink / raw) To: Chanwoo Choi Cc: Rafael J. Wysocki, Linux PM, Linux Kernel Mailing List, Marek Szyprowski, Chanwoo Choi (samsung.com), Myungjoo Ham, Kyungmin Park On Thu, May 19, 2022 at 2:42 AM Chanwoo Choi <cw00.choi@samsung.com> wrote: > > Each devfreq governor specifies the supported governor event > such as GOV_START and GOV_STOP. When not-supported event is required, > just return non-error. But, commit ce9a0d88d97a ("PM / devfreq: Add > cpu based scaling support to passive governor") returned the error > value. So that return non-error value when not-supported event is required. > > Fixes: ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor") > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > Dear Rafael, > > This patch fixes the issue of the pull request[1]. > I'd like you to apply it to linux-pm.git direclty. > [1] https://patchwork.kernel.org/project/linux-pm/patch/3acd6c32-6e78-dfc2-3e45-84f69a7d5f36@samsung.com/ > > Best Regards, > Chanwoo Choi > > drivers/devfreq/governor_passive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c > index 7306e943a234..72c67979ebe1 100644 > --- a/drivers/devfreq/governor_passive.c > +++ b/drivers/devfreq/governor_passive.c > @@ -402,7 +402,7 @@ static int devfreq_passive_event_handler(struct devfreq *devfreq, > { > struct devfreq_passive_data *p_data > = (struct devfreq_passive_data *)devfreq->data; > - int ret = -EINVAL; > + int ret = 0; > > if (!p_data) > return -EINVAL; > -- Applied, thanks! ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-19 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220519004138epcas1p1cb026c559dacbf3f8525910293b2de89@epcas1p1.samsung.com>
2022-05-19 1:07 ` [PATCH] PM / devfreq: passive: Return non-error when not-supported event is required Chanwoo Choi
2022-05-19 17:33 ` Rafael J. Wysocki
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.