All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: uwe@kleine-koenig.org
Cc: Nishanth Menon <nm@ti.com>, Linux PM <linux-pm@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Kevin Hilman <khilman@kernel.org>
Subject: Re: [PATCH] PM / AVS: SmartReflex: Fix module licence specification
Date: Tue, 9 Oct 2018 09:56:52 +0200	[thread overview]
Message-ID: <CAJZ5v0jEHcPKchOmzd9AewGCT0zkXnRgL=QGZTW-xWcJ12HNoA@mail.gmail.com> (raw)
In-Reply-To: <20181008091818.1145-1-uwe@kleine-koenig.org>

On Mon, Oct 8, 2018 at 11:23 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
>
> The header of this file claims "version 2" and not "or later". So adapt
> the module licence specification accordingly.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
>  drivers/power/avs/smartreflex.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index d29b6313cafc..9ed30b5d32c2 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
>  module_exit(sr_exit);
>
>  MODULE_DESCRIPTION("OMAP Smartreflex Driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:" DRIVER_NAME);
>  MODULE_AUTHOR("Texas Instruments Inc");
> --

While you are at it, why don't you add a proper SPDX license ID to
this file and drop the license bolierplate from the heading comment?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: rafael@kernel.org (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PM / AVS: SmartReflex: Fix module licence specification
Date: Tue, 9 Oct 2018 09:56:52 +0200	[thread overview]
Message-ID: <CAJZ5v0jEHcPKchOmzd9AewGCT0zkXnRgL=QGZTW-xWcJ12HNoA@mail.gmail.com> (raw)
In-Reply-To: <20181008091818.1145-1-uwe@kleine-koenig.org>

On Mon, Oct 8, 2018 at 11:23 AM Uwe Kleine-K?nig <uwe@kleine-koenig.org> wrote:
>
> The header of this file claims "version 2" and not "or later". So adapt
> the module licence specification accordingly.
>
> Signed-off-by: Uwe Kleine-K?nig <uwe@kleine-koenig.org>
> ---
>  drivers/power/avs/smartreflex.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index d29b6313cafc..9ed30b5d32c2 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
>  module_exit(sr_exit);
>
>  MODULE_DESCRIPTION("OMAP Smartreflex Driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:" DRIVER_NAME);
>  MODULE_AUTHOR("Texas Instruments Inc");
> --

While you are at it, why don't you add a proper SPDX license ID to
this file and drop the license bolierplate from the heading comment?

  reply	other threads:[~2018-10-09  7:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  9:18 [PATCH] PM / AVS: SmartReflex: Fix module licence specification Uwe Kleine-König
2018-10-08  9:18 ` Uwe Kleine-König
2018-10-09  7:56 ` Rafael J. Wysocki [this message]
2018-10-09  7:56   ` Rafael J. Wysocki
2018-12-04 20:15   ` Uwe Kleine-König
2018-12-04 20:15     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0jEHcPKchOmzd9AewGCT0zkXnRgL=QGZTW-xWcJ12HNoA@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.