* [PATCH] PM / AVS: SmartReflex: Fix module licence specification
@ 2018-10-08 9:18 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2018-10-08 9:18 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Nishanth Menon, linux-arm-kernel, linux-pm
The header of this file claims "version 2" and not "or later". So adapt
the module licence specification accordingly.
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
drivers/power/avs/smartreflex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
index d29b6313cafc..9ed30b5d32c2 100644
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
module_exit(sr_exit);
MODULE_DESCRIPTION("OMAP Smartreflex Driver");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:" DRIVER_NAME);
MODULE_AUTHOR("Texas Instruments Inc");
--
2.19.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] PM / AVS: SmartReflex: Fix module licence specification
@ 2018-10-08 9:18 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2018-10-08 9:18 UTC (permalink / raw)
To: linux-arm-kernel
The header of this file claims "version 2" and not "or later". So adapt
the module licence specification accordingly.
Signed-off-by: Uwe Kleine-K?nig <uwe@kleine-koenig.org>
---
drivers/power/avs/smartreflex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
index d29b6313cafc..9ed30b5d32c2 100644
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
module_exit(sr_exit);
MODULE_DESCRIPTION("OMAP Smartreflex Driver");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:" DRIVER_NAME);
MODULE_AUTHOR("Texas Instruments Inc");
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] PM / AVS: SmartReflex: Fix module licence specification
2018-10-08 9:18 ` Uwe Kleine-König
@ 2018-10-09 7:56 ` Rafael J. Wysocki
-1 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2018-10-09 7:56 UTC (permalink / raw)
To: uwe; +Cc: Nishanth Menon, Linux PM, Linux ARM, Kevin Hilman
On Mon, Oct 8, 2018 at 11:23 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
>
> The header of this file claims "version 2" and not "or later". So adapt
> the module licence specification accordingly.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> drivers/power/avs/smartreflex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index d29b6313cafc..9ed30b5d32c2 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
> module_exit(sr_exit);
>
> MODULE_DESCRIPTION("OMAP Smartreflex Driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:" DRIVER_NAME);
> MODULE_AUTHOR("Texas Instruments Inc");
> --
While you are at it, why don't you add a proper SPDX license ID to
this file and drop the license bolierplate from the heading comment?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] PM / AVS: SmartReflex: Fix module licence specification
@ 2018-10-09 7:56 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2018-10-09 7:56 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 8, 2018 at 11:23 AM Uwe Kleine-K?nig <uwe@kleine-koenig.org> wrote:
>
> The header of this file claims "version 2" and not "or later". So adapt
> the module licence specification accordingly.
>
> Signed-off-by: Uwe Kleine-K?nig <uwe@kleine-koenig.org>
> ---
> drivers/power/avs/smartreflex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index d29b6313cafc..9ed30b5d32c2 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
> module_exit(sr_exit);
>
> MODULE_DESCRIPTION("OMAP Smartreflex Driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:" DRIVER_NAME);
> MODULE_AUTHOR("Texas Instruments Inc");
> --
While you are at it, why don't you add a proper SPDX license ID to
this file and drop the license bolierplate from the heading comment?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PM / AVS: SmartReflex: Fix module licence specification
2018-10-09 7:56 ` Rafael J. Wysocki
@ 2018-12-04 20:15 ` Uwe Kleine-König
-1 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2018-12-04 20:15 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Nishanth Menon, Kevin Hilman, Linux ARM, Linux PM
Hello Rafael,
On Tue, Oct 09, 2018 at 09:56:52AM +0200, Rafael J. Wysocki wrote:
> On Mon, Oct 8, 2018 at 11:23 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
> >
> > The header of this file claims "version 2" and not "or later". So adapt
> > the module licence specification accordingly.
> >
> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> > ---
> > drivers/power/avs/smartreflex.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> > index d29b6313cafc..9ed30b5d32c2 100644
> > --- a/drivers/power/avs/smartreflex.c
> > +++ b/drivers/power/avs/smartreflex.c
> > @@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
> > module_exit(sr_exit);
> >
> > MODULE_DESCRIPTION("OMAP Smartreflex Driver");
> > -MODULE_LICENSE("GPL");
> > +MODULE_LICENSE("GPL v2");
> > MODULE_ALIAS("platform:" DRIVER_NAME);
> > MODULE_AUTHOR("Texas Instruments Inc");
> > --
>
> While you are at it, why don't you add a proper SPDX license ID to
> this file and drop the license bolierplate from the heading comment?
That would be a separate patch, right? And in contrast to this one
(which is a fix IMHO) it would only be an "improvement".
As this was just a drive-by change I won't follow up on this one. Take
it as is or don't.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PM / AVS: SmartReflex: Fix module licence specification
@ 2018-12-04 20:15 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2018-12-04 20:15 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Nishanth Menon, Kevin Hilman, Linux ARM, Linux PM
Hello Rafael,
On Tue, Oct 09, 2018 at 09:56:52AM +0200, Rafael J. Wysocki wrote:
> On Mon, Oct 8, 2018 at 11:23 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
> >
> > The header of this file claims "version 2" and not "or later". So adapt
> > the module licence specification accordingly.
> >
> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> > ---
> > drivers/power/avs/smartreflex.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> > index d29b6313cafc..9ed30b5d32c2 100644
> > --- a/drivers/power/avs/smartreflex.c
> > +++ b/drivers/power/avs/smartreflex.c
> > @@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
> > module_exit(sr_exit);
> >
> > MODULE_DESCRIPTION("OMAP Smartreflex Driver");
> > -MODULE_LICENSE("GPL");
> > +MODULE_LICENSE("GPL v2");
> > MODULE_ALIAS("platform:" DRIVER_NAME);
> > MODULE_AUTHOR("Texas Instruments Inc");
> > --
>
> While you are at it, why don't you add a proper SPDX license ID to
> this file and drop the license bolierplate from the heading comment?
That would be a separate patch, right? And in contrast to this one
(which is a fix IMHO) it would only be an "improvement".
As this was just a drive-by change I won't follow up on this one. Take
it as is or don't.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-04 20:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-08 9:18 [PATCH] PM / AVS: SmartReflex: Fix module licence specification Uwe Kleine-König
2018-10-08 9:18 ` Uwe Kleine-König
2018-10-09 7:56 ` Rafael J. Wysocki
2018-10-09 7:56 ` Rafael J. Wysocki
2018-12-04 20:15 ` Uwe Kleine-König
2018-12-04 20:15 ` Uwe Kleine-König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.