From: "Clément Péron" <peron.clem@gmail.com> To: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>, Jagan Teki <jagan@amarulasolutions.com>, Jernej Skrabec <jernej.skrabec@siol.net>, devicetree <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-sunxi <linux-sunxi@googlegroups.com> Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible Date: Mon, 15 Apr 2019 18:30:10 +0200 [thread overview] Message-ID: <CAJiuCcdrQ64jC8UH1eDKKhFdcOtk=bkWTAzoYOQ1ut3He+j2GQ@mail.gmail.com> (raw) In-Reply-To: <20190415145135.fjbcaldwy7w3eqcs@flea> Hi, On Mon, 15 Apr 2019 at 16:51, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Mon, Apr 15, 2019 at 10:30:38AM +0200, Clément Péron wrote: > > On Mon, 15 Apr 2019 at 10:18, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > On Mon, Apr 15, 2019 at 10:09:11AM +0200, Clément Péron wrote: > > > > Hi, > > > > > > > > On Mon, 15 Apr 2019 at 10:04, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > > > > > Hi, > > > > > > > > > > On Thu, Apr 11, 2019 at 11:44:19PM +0200, Clément Péron wrote: > > > > > > Allwinner H6 has a SPDIF controller with an increase of the fifo > > > > > > size and the possibility to output the master clock. > > > > > > However it's still compatible with the already existing driver for > > > > > > Allwiner H3. > > > > > > > > > > > > Add this compatible in the device-tree bindings documentation. > > > > > > > > > > How was this tested? > > > > > > > > Using Alsa utils on a Beelink GS1 and I check correct output sound on > > > > my home cinema. > > > > > > > > > After looking at the datasheet, it looks like it's still significantly > > > > > different. In particular: > > > > > > > > > > - The MCLK divider isn't at the same offset > > > > > > > > We don't use the MCLK > > > > > > > > > - The bits to flush the FIFO aren't at the same offset > > > > > - The FIFO trigger levels aren't at the same offset > > > > > - The FIFO status register layout is almost entirely different > > > > > > > > We use DMA not FIFO > > > > > > Well, DMA still uses the FIFOs. And even then, you're kind of missing > > > the point. The device tree's compatible is about whether a particular > > > device can be used as another one. How you are using it in the driver > > > is completely irrelevant. > > > > Sorry I meant " We use DMA not PIO". > > I'm still not quite sure what you mean. Both DMA and PIO would be > using the FIFOs. Just correcting myself but yes we use FIFO with the DMA. > > > I didn't change the driver and the SPDIF is working what's irrelevant > > in declaring the driver as compatible ? > > It's working by accident. > > This won't work for example: > https://elixir.bootlin.com/linux/latest/source/sound/soc/sunxi/sun4i-spdif.c#L181 > > > If some feature are missing they can be introduce later as there is a > > special binding for H6 no ? > > Again, that's irrelevant. The only question you need to ask yourself > is whether, if you take an imaginary source code that would support > all the H3 SPDIF features and run it on an H6, it works just as well. > > The examples above that it's not the case, so you can't claim that the > device is compatible. Is it ok if I fix the TX Fifo flush bit and remove the compatible with H3 ? (Looking at the driver this is the only bit used that is incompatible with H6) Or should I send a new driver with the correct mapping ? Thanks Clément > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: "Clément Péron" <peron.clem@gmail.com> To: Maxime Ripard <maxime.ripard@bootlin.com> Cc: devicetree <devicetree@vger.kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net>, linux-sunxi <linux-sunxi@googlegroups.com>, linux-kernel <linux-kernel@vger.kernel.org>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Jagan Teki <jagan@amarulasolutions.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Icenowy Zheng <icenowy@aosc.io> Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible Date: Mon, 15 Apr 2019 18:30:10 +0200 [thread overview] Message-ID: <CAJiuCcdrQ64jC8UH1eDKKhFdcOtk=bkWTAzoYOQ1ut3He+j2GQ@mail.gmail.com> (raw) In-Reply-To: <20190415145135.fjbcaldwy7w3eqcs@flea> Hi, On Mon, 15 Apr 2019 at 16:51, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Mon, Apr 15, 2019 at 10:30:38AM +0200, Clément Péron wrote: > > On Mon, 15 Apr 2019 at 10:18, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > On Mon, Apr 15, 2019 at 10:09:11AM +0200, Clément Péron wrote: > > > > Hi, > > > > > > > > On Mon, 15 Apr 2019 at 10:04, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > > > > > Hi, > > > > > > > > > > On Thu, Apr 11, 2019 at 11:44:19PM +0200, Clément Péron wrote: > > > > > > Allwinner H6 has a SPDIF controller with an increase of the fifo > > > > > > size and the possibility to output the master clock. > > > > > > However it's still compatible with the already existing driver for > > > > > > Allwiner H3. > > > > > > > > > > > > Add this compatible in the device-tree bindings documentation. > > > > > > > > > > How was this tested? > > > > > > > > Using Alsa utils on a Beelink GS1 and I check correct output sound on > > > > my home cinema. > > > > > > > > > After looking at the datasheet, it looks like it's still significantly > > > > > different. In particular: > > > > > > > > > > - The MCLK divider isn't at the same offset > > > > > > > > We don't use the MCLK > > > > > > > > > - The bits to flush the FIFO aren't at the same offset > > > > > - The FIFO trigger levels aren't at the same offset > > > > > - The FIFO status register layout is almost entirely different > > > > > > > > We use DMA not FIFO > > > > > > Well, DMA still uses the FIFOs. And even then, you're kind of missing > > > the point. The device tree's compatible is about whether a particular > > > device can be used as another one. How you are using it in the driver > > > is completely irrelevant. > > > > Sorry I meant " We use DMA not PIO". > > I'm still not quite sure what you mean. Both DMA and PIO would be > using the FIFOs. Just correcting myself but yes we use FIFO with the DMA. > > > I didn't change the driver and the SPDIF is working what's irrelevant > > in declaring the driver as compatible ? > > It's working by accident. > > This won't work for example: > https://elixir.bootlin.com/linux/latest/source/sound/soc/sunxi/sun4i-spdif.c#L181 > > > If some feature are missing they can be introduce later as there is a > > special binding for H6 no ? > > Again, that's irrelevant. The only question you need to ask yourself > is whether, if you take an imaginary source code that would support > all the H3 SPDIF features and run it on an H6, it works just as well. > > The examples above that it's not the case, so you can't claim that the > device is compatible. Is it ok if I fix the TX Fifo flush bit and remove the compatible with H3 ? (Looking at the driver this is the only bit used that is incompatible with H6) Or should I send a new driver with the correct mapping ? Thanks Clément > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-15 16:30 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-11 21:44 [PATCH 0/4] Allwinner H6 SPDIF support Clément Péron 2019-04-11 21:44 ` Clément Péron 2019-04-11 21:44 ` [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible Clément Péron 2019-04-11 21:44 ` Clément Péron 2019-04-11 21:44 ` Clément Péron 2019-04-15 8:04 ` Maxime Ripard 2019-04-15 8:04 ` Maxime Ripard 2019-04-15 8:04 ` Maxime Ripard 2019-04-15 8:09 ` Clément Péron 2019-04-15 8:09 ` Clément Péron 2019-04-15 8:09 ` Clément Péron 2019-04-15 8:11 ` Clément Péron 2019-04-15 8:11 ` Clément Péron 2019-04-15 8:18 ` Maxime Ripard 2019-04-15 8:18 ` Maxime Ripard 2019-04-15 8:18 ` Maxime Ripard 2019-04-15 8:30 ` Clément Péron 2019-04-15 8:30 ` Clément Péron 2019-04-15 8:30 ` Clément Péron 2019-04-15 14:51 ` Maxime Ripard 2019-04-15 14:51 ` Maxime Ripard 2019-04-15 14:51 ` Maxime Ripard 2019-04-15 16:30 ` Clément Péron [this message] 2019-04-15 16:30 ` Clément Péron 2019-04-16 7:34 ` Maxime Ripard 2019-04-16 7:34 ` Maxime Ripard 2019-04-16 8:30 ` Clément Péron 2019-04-16 8:30 ` Clément Péron 2019-04-15 15:06 ` Ondřej Jirman 2019-04-15 15:06 ` Ondřej Jirman 2019-04-15 15:06 ` 'Ondřej Jirman' via linux-sunxi 2019-04-11 21:44 ` [PATCH 2/4] arm64: dts: allwinner: Add SPDIF node for Allwinner H6 Clément Péron 2019-04-11 21:44 ` Clément Péron 2019-04-11 21:44 ` Clément Péron 2019-04-11 21:44 ` [PATCH 3/4] arm64: dts: allwinner: h6: Enable SPDIF for Beelink GS1 Clément Péron 2019-04-11 21:44 ` Clément Péron 2019-04-11 21:44 ` Clément Péron 2019-04-11 21:44 ` [PATCH 4/4] arm64: defconfig: Enable Sun4i SPDIF module Clément Péron 2019-04-11 21:44 ` Clément Péron 2019-04-11 21:44 ` Clément Péron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJiuCcdrQ64jC8UH1eDKKhFdcOtk=bkWTAzoYOQ1ut3He+j2GQ@mail.gmail.com' \ --to=peron.clem@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=icenowy@aosc.io \ --cc=jagan@amarulasolutions.com \ --cc=jernej.skrabec@siol.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=maxime.ripard@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.