All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Abraham <thomas.abraham@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Karol Lewandowski <k.lewandowsk@samsung.com>,
	linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com,
	grant.likely@secretlab.ca, kgene.kim@samsung.com,
	myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, patches@linaro.org,
	Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH v4 2/2] regulator: add device tree support for max8997
Date: Wed, 18 Apr 2012 13:46:58 +0530	[thread overview]
Message-ID: <CAJuYYwSg-VkWe=0PFNj2snX4+_fN7Lc1-YU1xdUvTM9uJvha7A@mail.gmail.com> (raw)
In-Reply-To: <20120417183829.GW6652@opensource.wolfsonmicro.com>

Hi Mark,

On 18 April 2012 00:08, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote:
>> On 28 March 2012 22:33, Karol Lewandowski <k.lewandowsk@samsung.com> wrote:
>
>> >> +    For BUCK's:
>
> No 's here, BTW.

Ok.

>
>> >  - EN32KHz_AP
>> >  - EN32KHz_CP
>> >  - ENVICHG
>> >  - ESAFEOUT1
>> >  - ESAFEOUT2
>> >  - CHARGER
>> >  - CHARGER_CV
>> >  - CHARGER_TOPOFF
>
>> > I wonder if these should be mentioned in documentation too.
>
>> Yes, I missed the above regulators in the documentation. I have
>> included them now and will resubmit this patch.
>
> Please omit the clocks; these are obviously a bodge due to the inability
> to support clocks off-SoC so we shouldn't be enshrining them in the
> device tree bindings.

Thanks for the suggestion. I have removed EN32KHz_AP and EN32KHz_CP
from the list. The rest are either voltage (fixed) or current
regulators.

Regards,
Thomas.

WARNING: multiple messages have this Message-ID (diff)
From: thomas.abraham@linaro.org (Thomas Abraham)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] regulator: add device tree support for max8997
Date: Wed, 18 Apr 2012 13:46:58 +0530	[thread overview]
Message-ID: <CAJuYYwSg-VkWe=0PFNj2snX4+_fN7Lc1-YU1xdUvTM9uJvha7A@mail.gmail.com> (raw)
In-Reply-To: <20120417183829.GW6652@opensource.wolfsonmicro.com>

Hi Mark,

On 18 April 2012 00:08, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote:
>> On 28 March 2012 22:33, Karol Lewandowski <k.lewandowsk@samsung.com> wrote:
>
>> >> + ? ?For BUCK's:
>
> No 's here, BTW.

Ok.

>
>> > ?- EN32KHz_AP
>> > ?- EN32KHz_CP
>> > ?- ENVICHG
>> > ?- ESAFEOUT1
>> > ?- ESAFEOUT2
>> > ?- CHARGER
>> > ?- CHARGER_CV
>> > ?- CHARGER_TOPOFF
>
>> > I wonder if these should be mentioned in documentation too.
>
>> Yes, I missed the above regulators in the documentation. I have
>> included them now and will resubmit this patch.
>
> Please omit the clocks; these are obviously a bodge due to the inability
> to support clocks off-SoC so we shouldn't be enshrining them in the
> device tree bindings.

Thanks for the suggestion. I have removed EN32KHz_AP and EN32KHz_CP
from the list. The rest are either voltage (fixed) or current
regulators.

Regards,
Thomas.

  reply	other threads:[~2012-04-18  8:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-24  9:49 [PATCH v4 0/2] regulator: add irq domain and device tree support for MAX8997 Thomas Abraham
2012-03-24  9:49 ` Thomas Abraham
2012-03-24  9:49 ` Thomas Abraham
2012-03-24  9:49 ` [PATCH v4 1/2] mfd: add irq domain support for max8997 interrupts Thomas Abraham
2012-03-24  9:49   ` Thomas Abraham
2012-03-24  9:49   ` Thomas Abraham
2012-03-26 12:20   ` MyungJoo Ham
2012-03-26 12:20     ` MyungJoo Ham
2012-03-30 22:06   ` Grant Likely
2012-03-30 22:06     ` Grant Likely
2012-04-17 18:11     ` Thomas Abraham
2012-04-17 18:11       ` Thomas Abraham
2012-04-04 21:22   ` Mark Brown
2012-04-04 21:22     ` Mark Brown
2012-04-16 15:32     ` Samuel Ortiz
2012-04-16 15:32       ` Samuel Ortiz
2012-04-16 18:47   ` Mark Brown
2012-04-16 18:47     ` Mark Brown
2012-03-24  9:49 ` [PATCH v4 2/2] regulator: add device tree support for max8997 Thomas Abraham
2012-03-24  9:49   ` Thomas Abraham
2012-03-27  6:40   ` MyungJoo Ham
2012-03-27  6:40     ` MyungJoo Ham
2012-03-28 17:03   ` Karol Lewandowski
2012-03-28 17:03     ` Karol Lewandowski
2012-04-17 18:35     ` Thomas Abraham
2012-04-17 18:35       ` Thomas Abraham
2012-04-17 18:38       ` Mark Brown
2012-04-17 18:38         ` Mark Brown
2012-04-18  8:16         ` Thomas Abraham [this message]
2012-04-18  8:16           ` Thomas Abraham
2012-03-30 22:09   ` Grant Likely
2012-03-30 22:09     ` Grant Likely
2012-04-16 18:51   ` Mark Brown
2012-04-16 18:51     ` Mark Brown
2012-04-16 18:56     ` Thomas Abraham
2012-04-16 18:56       ` Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJuYYwSg-VkWe=0PFNj2snX4+_fN7Lc1-YU1xdUvTM9uJvha7A@mail.gmail.com' \
    --to=thomas.abraham@linaro.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=k.lewandowsk@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@linaro.org \
    --cc=rnayak@ti.com \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.