[PATCH] .gitignore: Add compilation database files

[PATCH] .gitignore: Add compilation database files

[Toru Komatsu]

This file is used by clangd to use language server protocol.
It can be generated at each compile using scripts/gen_compile_commands.py.
Therefore it is different depending on the environment and should be
ignored.

Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index 8f5422cba6e2..025d887f64f1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -142,3 +142,6 @@ x509.genkey
 
 # Kdevelop4
 *.kdev4
+
+# Clang's compilation database files
+/compile_commands.json
-- 
2.17.1

Re: [PATCH] .gitignore: Add compilation database files

[Nick Desaulniers]

On Sun, Jul 21, 2019 at 1:54 AM Toru Komatsu <k0ma@utam0k.jp> wrote:
>
> This file is used by clangd to use language server protocol.
> It can be generated at each compile using scripts/gen_compile_commands.py.
> Therefore it is different depending on the environment and should be
> ignored.
>
> Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 8f5422cba6e2..025d887f64f1 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -142,3 +142,6 @@ x509.genkey
>
>  # Kdevelop4
>  *.kdev4
> +
> +# Clang's compilation database files
> +/compile_commands.json

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Also, if you're doing anything exciting with compile_commands.json,
I'd love to know.  We're using it for static analyses.

-- 
Thanks,
~Nick Desaulniers

Re: [PATCH] .gitignore: Add compilation database files

[Masahiro Yamada]

Just a nit.

The patch title is:
.gitignore: Add compilation database "files"

Maybe, should it be singular?


On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu <k0ma@utam0k.jp> wrote:
>
> This file is used by clangd to use language server protocol.
> It can be generated at each compile using scripts/gen_compile_commands.py.
> Therefore it is different depending on the environment and should be
> ignored.
>
> Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 8f5422cba6e2..025d887f64f1 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -142,3 +142,6 @@ x509.genkey
>
>  # Kdevelop4
>  *.kdev4
> +
> +# Clang's compilation database files
> +/compile_commands.json
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada

Re: [PATCH] .gitignore: Add compilation database files

[Toru Komatsu]

On 07/24, Masahiro Yamada wrote:
> Just a nit.
> 
> The patch title is:
> .gitignore: Add compilation database "files"
> 
> Maybe, should it be singular?
> 
> 
> On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu <k0ma@utam0k.jp> wrote:
> >
> > This file is used by clangd to use language server protocol.
> > It can be generated at each compile using scripts/gen_compile_commands.py.
> > Therefore it is different depending on the environment and should be
> > ignored.
> >
> > Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> > ---
> >  .gitignore | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 8f5422cba6e2..025d887f64f1 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -142,3 +142,6 @@ x509.genkey
> >
> >  # Kdevelop4
> >  *.kdev4
> > +
> > +# Clang's compilation database files
> > +/compile_commands.json
> > --
> > 2.17.1
> >
> 
> 
> -- 
> Best Regards
> Masahiro Yamada

-- 

Thanks for your review.

 Sorry, this point which you pointed out is my mistake.
 It is should be "file".

 I'm begginer because this patch is my first time,
 What should I do next?

> Thanks,
> ~Toru Komatsu

Re: [PATCH] .gitignore: Add compilation database files

[Masahiro Yamada]

On Wed, Jul 24, 2019 at 1:28 AM Toru Komatsu <k0ma@utam0k.jp> wrote:
>
> On 07/24, Masahiro Yamada wrote:
> > Just a nit.
> >
> > The patch title is:
> > .gitignore: Add compilation database "files"
> >
> > Maybe, should it be singular?
> >
> >
> > On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu <k0ma@utam0k.jp> wrote:
> > >
> > > This file is used by clangd to use language server protocol.
> > > It can be generated at each compile using scripts/gen_compile_commands.py.
> > > Therefore it is different depending on the environment and should be
> > > ignored.
> > >
> > > Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> > > ---
> > >  .gitignore | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/.gitignore b/.gitignore
> > > index 8f5422cba6e2..025d887f64f1 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -142,3 +142,6 @@ x509.genkey
> > >
> > >  # Kdevelop4
> > >  *.kdev4
> > > +
> > > +# Clang's compilation database files
> > > +/compile_commands.json
> > > --
> > > 2.17.1
> > >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada
>
> --
>
> Thanks for your review.
>
>  Sorry, this point which you pointed out is my mistake.
>  It is should be "file".
>
>  I'm begginer because this patch is my first time,
>  What should I do next?


This patch is trivial enough.

I will change "files" -> "file"
(patch subject and code),
then I will apply it.

Thanks.




-- 
Best Regards
Masahiro Yamada

Re: [PATCH] .gitignore: Add compilation database files

[Nick Desaulniers]

On Tue, Jul 23, 2019 at 9:28 AM Toru Komatsu <k0ma@utam0k.jp> wrote:
>  I'm begginer because this patch is my first time,
>  What should I do next?

https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/

TL;DR
<edit file>
$ git commit <file> --amend
$ git format-patch -v2
<resend>
-- 
Thanks,
~Nick Desaulniers