* [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag
@ 2018-07-06 5:12 Masahiro Yamada
2018-07-28 2:43 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2018-07-06 5:12 UTC (permalink / raw)
To: David Airlie, dri-devel
Cc: Masahiro Yamada, Lucas Stach, linux-kernel, Chunming Zhou,
Alex Deucher, Christian König
I refactored the include directives under include/drm/ some time ago.
This flag is unneeded.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/gpu/drm/scheduler/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/scheduler/Makefile
index bd0377c..7665883 100644
--- a/drivers/gpu/drm/scheduler/Makefile
+++ b/drivers/gpu/drm/scheduler/Makefile
@@ -20,7 +20,6 @@
# OTHER DEALINGS IN THE SOFTWARE.
#
#
-ccflags-y := -Iinclude/drm
gpu-sched-y := gpu_scheduler.o sched_fence.o
obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag
2018-07-06 5:12 [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada
@ 2018-07-28 2:43 ` Masahiro Yamada
2018-07-30 12:49 ` Nayan Deshmukh
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2018-07-28 2:43 UTC (permalink / raw)
To: David Airlie, dri-devel
Cc: Masahiro Yamada, Lucas Stach, Linux Kernel Mailing List,
Chunming Zhou, Alex Deucher, Christian König
Hi.
2018-07-06 14:12 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> I refactored the include directives under include/drm/ some time ago.
> This flag is unneeded.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Ping?
> ---
>
> drivers/gpu/drm/scheduler/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/scheduler/Makefile
> index bd0377c..7665883 100644
> --- a/drivers/gpu/drm/scheduler/Makefile
> +++ b/drivers/gpu/drm/scheduler/Makefile
> @@ -20,7 +20,6 @@
> # OTHER DEALINGS IN THE SOFTWARE.
> #
> #
> -ccflags-y := -Iinclude/drm
> gpu-sched-y := gpu_scheduler.o sched_fence.o
>
> obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag
2018-07-28 2:43 ` Masahiro Yamada
@ 2018-07-30 12:49 ` Nayan Deshmukh
2018-07-30 13:09 ` Christian König
0 siblings, 1 reply; 4+ messages in thread
From: Nayan Deshmukh @ 2018-07-30 12:49 UTC (permalink / raw)
To: yamada.masahiro
Cc: airlied, Alex Deucher, Linux Kernel Mailing List,
Maling list - DRI developers, Christian König
[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]
On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada <
yamada.masahiro@socionext.com> wrote:
> Hi.
>
> 2018-07-06 14:12 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com
> >:
> > I refactored the include directives under include/drm/ some time ago.
> > This flag is unneeded.
> >
>
A minor nit-pick in the commit message, something like "With the refactored
include directives under include/drm, this flag is uneeded." might be
better.
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
With or without that the patch is Acked-by: Nayan Deshmukh <
nayan26deshmukh@gmail.com>
Regards,
Nayan Deshmukh
>
> Ping?
>
>
> > ---
> >
> > drivers/gpu/drm/scheduler/Makefile | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/Makefile
> b/drivers/gpu/drm/scheduler/Makefile
> > index bd0377c..7665883 100644
> > --- a/drivers/gpu/drm/scheduler/Makefile
> > +++ b/drivers/gpu/drm/scheduler/Makefile
> > @@ -20,7 +20,6 @@
> > # OTHER DEALINGS IN THE SOFTWARE.
> > #
> > #
> > -ccflags-y := -Iinclude/drm
> > gpu-sched-y := gpu_scheduler.o sched_fence.o
> >
> > obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> > --
> > 2.7.4
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
[-- Attachment #1.2: Type: text/html, Size: 2542 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag
2018-07-30 12:49 ` Nayan Deshmukh
@ 2018-07-30 13:09 ` Christian König
0 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2018-07-30 13:09 UTC (permalink / raw)
To: Nayan Deshmukh, yamada.masahiro
Cc: airlied, Alex Deucher, Linux Kernel Mailing List,
Maling list - DRI developers, Christian König
[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]
Am 30.07.2018 um 14:49 schrieb Nayan Deshmukh:
>
>
> On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada
> <yamada.masahiro@socionext.com <mailto:yamada.masahiro@socionext.com>>
> wrote:
>
> Hi.
>
> 2018-07-06 14:12 GMT+09:00 Masahiro Yamada
> <yamada.masahiro@socionext.com
> <mailto:yamada.masahiro@socionext.com>>:
> > I refactored the include directives under include/drm/ some time
> ago.
> > This flag is unneeded.
> >
>
> A minor nit-pick in the commit message, something like "With the
> refactored include directives under include/drm, this flag is
> uneeded." might be better.
>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com
> <mailto:yamada.masahiro@socionext.com>>
>
> With or without that the patch is Acked-by: Nayan Deshmukh
> <nayan26deshmukh@gmail.com <mailto:nayan26deshmukh@gmail.com>>
I've pushed that patch into our internal branch for scheduler work.
Thanks,
Christian.
>
> Regards,
> Nayan Deshmukh
>
>
> Ping?
>
>
> > ---
> >
> > drivers/gpu/drm/scheduler/Makefile | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/Makefile
> b/drivers/gpu/drm/scheduler/Makefile
> > index bd0377c..7665883 100644
> > --- a/drivers/gpu/drm/scheduler/Makefile
> > +++ b/drivers/gpu/drm/scheduler/Makefile
> > @@ -20,7 +20,6 @@
> > # OTHER DEALINGS IN THE SOFTWARE.
> > #
> > #
> > -ccflags-y := -Iinclude/drm
> > gpu-sched-y := gpu_scheduler.o sched_fence.o
> >
> > obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> > --
> > 2.7.4
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> <mailto:dri-devel@lists.freedesktop.org>
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
[-- Attachment #2: Type: text/html, Size: 4928 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-30 13:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-06 5:12 [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada
2018-07-28 2:43 ` Masahiro Yamada
2018-07-30 12:49 ` Nayan Deshmukh
2018-07-30 13:09 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.