From: Arnd Bergmann <arnd@arndb.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Keith Packard <keithpac@amazon.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 01/10] ARM: fix incorrect use of get_kernel_nofault()
Date: Tue, 21 Sep 2021 12:39:38 +0200 [thread overview]
Message-ID: <CAK8P3a05d+WFkqNNmiHV6jqMu_nJa6XJjYwHtdLOLuPvZvMzsA@mail.gmail.com> (raw)
In-Reply-To: <20210921095408.133210-2-ardb@kernel.org>
On Tue, Sep 21, 2021 at 11:53 AM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> Commit 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead
> of set_fs()") replaced an occurrence of __get_user() with
> get_kernel_nofault(), but inverted the sense of the conditional in the
> process, resulting in no values to be printed at all.
>
> I.e., every exception stack now looks like this:
>
> Exception stack(0xc18d1fb0 to 0xc18d1ff8)
> 1fa0: ???????? ???????? ???????? ????????
> 1fc0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
> 1fe0: ???????? ???????? ???????? ???????? ???????? ????????
>
> which is rather unhelpful.
>
> Fixes: 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead of set_fs()")
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Thanks for catching this!
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-21 10:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 9:53 [PATCH 00/10] ARM: add support for IRQ stacks Ard Biesheuvel
2021-09-21 9:53 ` [PATCH 01/10] ARM: fix incorrect use of get_kernel_nofault() Ard Biesheuvel
2021-09-21 10:39 ` Arnd Bergmann [this message]
2021-09-21 14:02 ` Russell King (Oracle)
2021-09-21 14:33 ` Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 02/10] ARM: remove some dead code Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 03/10] ARM: assembler: introduce bl_r and bl_m macros Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 04/10] ARM: optimize indirect call to handle_arch_irq for v7 cores Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 05/10] ARM: unwind: support unwinding across multiple stacks Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 06/10] ARM: export dump_mem() to other objects Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 07/10] ARM: unwind: dump exception stack from calling frame Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 08/10] ARM: implement IRQ stacks Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 09/10] ARM: call_with_stack: add unwind support Ard Biesheuvel
2021-09-21 9:54 ` [PATCH 10/10] ARM: run softirqs on the per-CPU IRQ stack Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a05d+WFkqNNmiHV6jqMu_nJa6XJjYwHtdLOLuPvZvMzsA@mail.gmail.com \
--to=arnd@arndb.de \
--cc=ardb@kernel.org \
--cc=keescook@chromium.org \
--cc=keithpac@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.