From: Arnd Bergmann <arnd@arndb.de>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Subject: Re: [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver
Date: Mon, 7 Mar 2022 14:16:06 +0100 [thread overview]
Message-ID: <CAK8P3a1Fw5cdxtr3LeG=tNbrTRbseXP+fDzfr-2B+LqbShA99w@mail.gmail.com> (raw)
In-Reply-To: <51603aa7-4113-dba4-9a38-0a6683a1d249@os.amperecomputing.com>
On Mon, Mar 7, 2022 at 9:32 AM Quan Nguyen <quan@os.amperecomputing.com> wrote:
> > diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c
> > index a7cd64bf9eaa..5611dd30f8f4 100644
> > --- a/drivers/mfd/smpro-mfd.c
> > +++ b/drivers/mfd/smpro-mfd.c
> > @@ -28,6 +28,7 @@ static const struct regmap_config simple_word_regmap_config = {
> > static const struct mfd_cell smpro_devs[] = {
> > MFD_CELL_NAME("smpro-hwmon"),
> > MFD_CELL_NAME("smpro-errmon"),
> > + MFD_CELL_NAME("smpro-misc"),
>
> [Lee Jones]
> Misc is a Linuxisum which are not allowed in DT.
>
> What does this driver actually do?
>
> [Quan]
> This drivers is to report the boot progress to BMC and allow BMC to
> configure the Soc Power Limit of Ampere's Altra family processor.
That doesn't sound like it should be platform specific at all, but rather
a generic BMC interface. I see you already have the openbmc list on Cc,
so I assume the right people can see this. Presumably this is a BMC that
already runs on openbmc and can have a platform-independent interface
for doing this.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: linux-aspeed <linux-aspeed@lists.ozlabs.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Joel Stanley <joel@jms.id.au>,
Open Source Submission <patches@amperecomputing.com>,
Guenter Roeck <linux@roeck-us.net>,
DTML <devicetree@vger.kernel.org>,
Jean Delvare <jdelvare@suse.com>, Arnd Bergmann <arnd@arndb.de>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
Rob Herring <robh+dt@kernel.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
linux-hwmon@vger.kernel.org, Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Phong Vo <phong@os.amperecomputing.com>,
Mark Brown <broonie@kernel.org>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Subject: Re: [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver
Date: Mon, 7 Mar 2022 14:16:06 +0100 [thread overview]
Message-ID: <CAK8P3a1Fw5cdxtr3LeG=tNbrTRbseXP+fDzfr-2B+LqbShA99w@mail.gmail.com> (raw)
In-Reply-To: <51603aa7-4113-dba4-9a38-0a6683a1d249@os.amperecomputing.com>
On Mon, Mar 7, 2022 at 9:32 AM Quan Nguyen <quan@os.amperecomputing.com> wrote:
> > diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c
> > index a7cd64bf9eaa..5611dd30f8f4 100644
> > --- a/drivers/mfd/smpro-mfd.c
> > +++ b/drivers/mfd/smpro-mfd.c
> > @@ -28,6 +28,7 @@ static const struct regmap_config simple_word_regmap_config = {
> > static const struct mfd_cell smpro_devs[] = {
> > MFD_CELL_NAME("smpro-hwmon"),
> > MFD_CELL_NAME("smpro-errmon"),
> > + MFD_CELL_NAME("smpro-misc"),
>
> [Lee Jones]
> Misc is a Linuxisum which are not allowed in DT.
>
> What does this driver actually do?
>
> [Quan]
> This drivers is to report the boot progress to BMC and allow BMC to
> configure the Soc Power Limit of Ampere's Altra family processor.
That doesn't sound like it should be platform specific at all, but rather
a generic BMC interface. I see you already have the openbmc list on Cc,
so I assume the right people can see this. Presumably this is a BMC that
already runs on openbmc and can have a platform-independent interface
for doing this.
Arnd
next prev parent reply other threads:[~2022-03-07 13:16 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 4:13 [PATCH v6 0/9] Add Ampere's Altra SMPro MFD and its child drivers Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 1/9] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 2/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro " Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2022-02-08 9:12 ` Lee Jones
2022-02-08 9:12 ` Lee Jones
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 3/9] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 4/9] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 5/9] regmap: Introduces regmap lock helpers Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 13:19 ` Mark Brown
2021-12-24 13:19 ` Mark Brown
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 8:32 ` Greg Kroah-Hartman
2021-12-24 8:32 ` Greg Kroah-Hartman
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 8:32 ` Quan Nguyen
2021-12-24 13:28 ` Mark Brown
2021-12-24 13:28 ` Mark Brown
2022-03-07 8:30 ` Quan Nguyen
2022-03-07 8:30 ` Quan Nguyen
2021-12-28 6:31 ` kernel test robot
2021-12-29 10:16 ` Lee Jones
2021-12-29 10:16 ` Lee Jones
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 7/9] docs: misc-devices: (smpro-errmon) Add documentation Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-29 10:18 ` Lee Jones
2021-12-29 10:18 ` Lee Jones
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 13:16 ` Arnd Bergmann [this message]
2022-03-07 13:16 ` Arnd Bergmann
2021-12-24 4:13 ` [PATCH v6 9/9] docs: misc-devices: (smpro-misc) Add documentation Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1Fw5cdxtr3LeG=tNbrTRbseXP+fDzfr-2B+LqbShA99w@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=andrew@aj.id.au \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.