From: Arnd Bergmann <arnd@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: openipmi-developer@lists.sourceforge.net,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Corey Minyard <minyard@acm.org>, Joel Stanley <joel@jms.id.au>,
Ryan Chen <ryan_chen@aspeedtech.com>,
DTML <devicetree@vger.kernel.org>,
Tomer Maimon <tmaimon77@gmail.com>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Avi Fishman <avifishman70@gmail.com>,
Patrick Venture <venture@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tali Perry <tali.perry1@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
chiawei_wang@aspeedtech.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Benjamin Fair <benjaminfair@google.com>
Subject: Re: [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface
Date: Fri, 9 Apr 2021 09:55:53 +0200 [thread overview]
Message-ID: <CAK8P3a1HDQdbTAT4aRMLu-VFz720ynPqPHG5b22NZ5p5QfUqOw@mail.gmail.com> (raw)
In-Reply-To: <20210319062752.145730-16-andrew@aj.id.au>
On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> The existing IPMI chardev encodes IPMI behaviours as the name suggests.
> However, KCS devices are useful beyond IPMI (or keyboards), as they
> provide a means to generate IRQs and exchange arbitrary data between a
> BMC and its host system.
I only noticed the series after Joel asked about the DT changes on the arm
side. One question though:
How does this related to the drivers/input/serio/ framework that also talks
to the keyboard controller for things that are not keyboards? Are these
separate communication channels on adjacent I/O ports, or does there
need to be some arbitration?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
chiawei_wang@aspeedtech.com, Ryan Chen <ryan_chen@aspeedtech.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Corey Minyard <minyard@acm.org>,
Avi Fishman <avifishman70@gmail.com>,
Patrick Venture <venture@google.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tali Perry <tali.perry1@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
openipmi-developer@lists.sourceforge.net,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Benjamin Fair <benjaminfair@google.com>
Subject: Re: [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface
Date: Fri, 9 Apr 2021 09:55:53 +0200 [thread overview]
Message-ID: <CAK8P3a1HDQdbTAT4aRMLu-VFz720ynPqPHG5b22NZ5p5QfUqOw@mail.gmail.com> (raw)
In-Reply-To: <20210319062752.145730-16-andrew@aj.id.au>
On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> The existing IPMI chardev encodes IPMI behaviours as the name suggests.
> However, KCS devices are useful beyond IPMI (or keyboards), as they
> provide a means to generate IRQs and exchange arbitrary data between a
> BMC and its host system.
I only noticed the series after Joel asked about the DT changes on the arm
side. One question though:
How does this related to the drivers/input/serio/ framework that also talks
to the keyboard controller for things that are not keyboards? Are these
separate communication channels on adjacent I/O ports, or does there
need to be some arbitration?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: openipmi-developer@lists.sourceforge.net,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Corey Minyard <minyard@acm.org>, Joel Stanley <joel@jms.id.au>,
Ryan Chen <ryan_chen@aspeedtech.com>,
DTML <devicetree@vger.kernel.org>,
Tomer Maimon <tmaimon77@gmail.com>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Avi Fishman <avifishman70@gmail.com>,
Patrick Venture <venture@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tali Perry <tali.perry1@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
chiawei_wang@aspeedtech.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Benjamin Fair <benjaminfair@google.com>
Subject: Re: [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface
Date: Fri, 9 Apr 2021 09:55:53 +0200 [thread overview]
Message-ID: <CAK8P3a1HDQdbTAT4aRMLu-VFz720ynPqPHG5b22NZ5p5QfUqOw@mail.gmail.com> (raw)
In-Reply-To: <20210319062752.145730-16-andrew@aj.id.au>
On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> The existing IPMI chardev encodes IPMI behaviours as the name suggests.
> However, KCS devices are useful beyond IPMI (or keyboards), as they
> provide a means to generate IRQs and exchange arbitrary data between a
> BMC and its host system.
I only noticed the series after Joel asked about the DT changes on the arm
side. One question though:
How does this related to the drivers/input/serio/ framework that also talks
to the keyboard controller for things that are not keyboards? Are these
separate communication channels on adjacent I/O ports, or does there
need to be some arbitration?
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-09 7:56 UTC|newest]
Thread overview: 200+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 6:27 [PATCH v2 01/21] dt-bindings: aspeed-lpc: Remove LPC partitioning Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 02/21] ARM: dts: Remove LPC BMC and Host partitions Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 03/21] ipmi: kcs: aspeed: Adapt to new LPC DTS layout Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 3:35 ` Joel Stanley
2021-04-09 3:35 ` Joel Stanley
2021-04-09 3:35 ` Joel Stanley
2021-03-19 6:27 ` [PATCH v2 04/21] pinctrl: aspeed-g5: Adapt to new LPC device tree layout Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 3:36 ` Joel Stanley
2021-04-09 3:36 ` Joel Stanley
2021-04-09 3:36 ` Joel Stanley
2021-03-19 6:27 ` [PATCH v2 05/21] soc: aspeed: " Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 3:38 ` Joel Stanley
2021-04-09 3:38 ` Joel Stanley
2021-04-09 3:38 ` Joel Stanley
2021-03-19 6:27 ` [PATCH v2 06/21] ipmi: kcs_bmc_aspeed: Use of match data to extract KCS properties Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-06 6:07 ` ChiaWei Wang
2021-04-06 6:07 ` ChiaWei Wang
2021-04-06 6:07 ` ChiaWei Wang
2021-04-09 3:24 ` Zev Weiss
2021-04-09 3:24 ` Zev Weiss
2021-04-09 3:24 ` Zev Weiss
2021-03-19 6:27 ` [PATCH v2 07/21] ipmi: kcs_bmc: Make status update atomic Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 5:32 ` Zev Weiss
2021-04-09 5:32 ` Zev Weiss
2021-04-09 5:32 ` Zev Weiss
2021-03-19 6:27 ` [PATCH v2 08/21] ipmi: kcs_bmc: Rename {read,write}_{status,data}() functions Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 08/21] ipmi: kcs_bmc: Rename {read, write}_{status, data}() functions Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 5:33 ` Zev Weiss
2021-04-09 5:33 ` Zev Weiss
2021-04-09 5:33 ` Zev Weiss
2021-03-19 6:27 ` [PATCH v2 09/21] ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 3:56 ` Zev Weiss
2021-04-09 3:56 ` Zev Weiss
2021-04-09 3:56 ` Zev Weiss
2021-04-09 5:48 ` Andrew Jeffery
2021-04-09 5:48 ` Andrew Jeffery
2021-04-09 5:48 ` Andrew Jeffery
2021-04-09 19:21 ` Zev Weiss
2021-04-09 19:21 ` Zev Weiss
2021-04-09 19:21 ` Zev Weiss
2021-03-19 6:27 ` [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 3:57 ` Zev Weiss
2021-04-09 3:57 ` Zev Weiss
2021-04-09 3:57 ` Zev Weiss
2021-04-09 5:59 ` Andrew Jeffery
2021-04-09 5:59 ` Andrew Jeffery
2021-04-09 5:59 ` Andrew Jeffery
2021-04-09 6:25 ` Zev Weiss
2021-04-09 6:25 ` Zev Weiss
2021-04-09 6:25 ` Zev Weiss
2021-04-09 19:26 ` Zev Weiss
2021-04-09 19:26 ` Zev Weiss
2021-04-09 19:26 ` Zev Weiss
2021-04-11 23:00 ` Andrew Jeffery
2021-04-11 23:00 ` Andrew Jeffery
2021-04-11 23:00 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 11/21] ipmi: kcs_bmc: Split headers into device and client Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 4:01 ` Zev Weiss
2021-04-09 4:01 ` Zev Weiss
2021-04-09 4:01 ` Zev Weiss
2021-04-09 6:06 ` Andrew Jeffery
2021-04-09 6:06 ` Andrew Jeffery
2021-04-09 6:06 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 12/21] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 4:07 ` Zev Weiss
2021-04-09 4:07 ` Zev Weiss
2021-04-09 4:07 ` Zev Weiss
2021-04-09 6:15 ` Andrew Jeffery
2021-04-09 6:15 ` Andrew Jeffery
2021-04-09 6:15 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 13/21] ipmi: kcs_bmc: Decouple the IPMI chardev from the core Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-06 6:07 ` ChiaWei Wang
2021-04-06 6:07 ` ChiaWei Wang
2021-04-06 6:07 ` ChiaWei Wang
2021-04-09 4:35 ` Zev Weiss
2021-04-09 4:35 ` Zev Weiss
2021-04-09 4:35 ` Zev Weiss
2021-04-09 6:24 ` Andrew Jeffery
2021-04-09 6:24 ` Andrew Jeffery
2021-04-09 6:24 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 14/21] ipmi: kcs_bmc: Allow clients to control KCS IRQ state Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 4:37 ` Zev Weiss
2021-04-09 4:37 ` Zev Weiss
2021-04-09 4:37 ` Zev Weiss
2021-04-09 6:39 ` Andrew Jeffery
2021-04-09 6:39 ` Andrew Jeffery
2021-04-09 6:39 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 15/21] ipmi: kcs_bmc: Don't enforce single-open policy in the kernel Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 5:07 ` Zev Weiss
2021-04-09 5:07 ` Zev Weiss
2021-04-09 5:07 ` Zev Weiss
2021-04-09 6:42 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 5:17 ` Zev Weiss
2021-04-09 5:17 ` Zev Weiss
2021-04-09 5:17 ` Zev Weiss
2021-04-09 6:46 ` Andrew Jeffery
2021-04-09 6:46 ` Andrew Jeffery
2021-04-09 6:46 ` Andrew Jeffery
2021-04-09 7:55 ` Arnd Bergmann [this message]
2021-04-09 7:55 ` Arnd Bergmann
2021-04-09 7:55 ` Arnd Bergmann
2021-04-09 8:51 ` Andrew Jeffery
2021-04-12 1:33 ` Andrew Jeffery
2021-04-12 1:33 ` Andrew Jeffery
2021-04-12 1:33 ` Andrew Jeffery
2021-04-12 8:48 ` Arnd Bergmann
2021-04-12 8:48 ` Arnd Bergmann
2021-04-12 8:48 ` Arnd Bergmann
2021-04-12 23:45 ` Andrew Jeffery
2021-04-12 23:45 ` Andrew Jeffery
2021-04-12 23:45 ` Andrew Jeffery
2021-04-13 8:22 ` Arnd Bergmann
2021-04-13 8:22 ` Arnd Bergmann
2021-04-13 8:22 ` Arnd Bergmann
2021-04-14 0:30 ` Andrew Jeffery
2021-04-14 0:30 ` Andrew Jeffery
2021-04-14 0:30 ` Andrew Jeffery
2021-03-19 6:27 ` [PATCH v2 17/21] dt-bindings: ipmi: Convert ASPEED KCS binding to schema Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-26 1:48 ` Rob Herring
2021-03-26 1:48 ` Rob Herring
2021-03-26 1:48 ` Rob Herring
2021-04-09 5:15 ` Zev Weiss
2021-04-09 5:15 ` Zev Weiss
2021-04-09 5:15 ` Zev Weiss
2021-04-09 5:33 ` Andrew Jeffery
2021-04-09 5:33 ` Andrew Jeffery
2021-04-09 5:33 ` Andrew Jeffery
2021-04-09 5:44 ` Zev Weiss
2021-04-09 5:44 ` Zev Weiss
2021-04-09 5:44 ` Zev Weiss
2021-04-09 8:46 ` Zev Weiss
2021-04-09 8:46 ` Zev Weiss
2021-04-09 8:46 ` Zev Weiss
2021-03-19 6:27 ` [PATCH v2 18/21] dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-26 1:49 ` Rob Herring
2021-03-26 1:49 ` Rob Herring
2021-03-26 1:49 ` Rob Herring
2021-03-19 6:27 ` [PATCH v2 19/21] ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-01 9:30 ` [EXTERNAL] " Zev Weiss
2021-04-01 9:30 ` Zev Weiss
2021-04-01 9:30 ` Zev Weiss
2021-03-19 6:27 ` [PATCH v2 20/21] ipmi: kcs_bmc_aspeed: Fix IBFIE typo from datasheet Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-09 5:40 ` Zev Weiss
2021-04-09 5:40 ` Zev Weiss
2021-04-09 5:40 ` Zev Weiss
2021-03-19 6:27 ` [PATCH v2 21/21] ipmi: kcs_bmc_aspeed: Optionally apply status address Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-03-19 6:27 ` Andrew Jeffery
2021-04-01 18:18 ` Re " Zev Weiss
2021-04-01 18:18 ` Zev Weiss
2021-04-01 18:18 ` Zev Weiss
2021-04-06 6:09 ` ChiaWei Wang
2021-04-06 6:09 ` ChiaWei Wang
2021-04-06 6:09 ` ChiaWei Wang
2021-04-09 3:18 ` [PATCH v2 01/21] dt-bindings: aspeed-lpc: Remove LPC partitioning Joel Stanley
2021-04-09 3:18 ` Joel Stanley
2021-04-09 3:18 ` Joel Stanley
2021-04-09 5:24 ` Andrew Jeffery
2021-04-09 5:24 ` Andrew Jeffery
2021-04-09 5:24 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1HDQdbTAT4aRMLu-VFz720ynPqPHG5b22NZ5p5QfUqOw@mail.gmail.com \
--to=arnd@kernel.org \
--cc=andrew@aj.id.au \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openbmc@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.