From: Arnd Bergmann <arnd@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ardb@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] ARM: kprobes: rewrite in UAL
Date: Thu, 28 Jan 2021 22:23:56 +0100 [thread overview]
Message-ID: <CAK8P3a2Jxj-aEe-kk+xsEX19mHOc6LQ8O=XXCrWowAP0Vo2Kew@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOd=ORiCsvv_XQ8By8ZUe0QnzH3T6pFEwnRy65tmUsQ2yQg@mail.gmail.com>
On Thu, Jan 28, 2021 at 7:59 PM 'Nick Desaulniers' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
> On Thu, Jan 28, 2021 at 8:15 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> > Plus a lot of extra errors when building with CONFIG_THUMB2_KERNEL,
> > as that uses tests in arch/arm/probes/kprobes/test-thumb.c.
>
> Technically, that's a distinctly separate issue;
> arch/arm/probes/kprobes/test-arm.c is not built with
> CONFIG_THUMB2_KERNEL=y. This patch doesn't introduce those warnings;
> that file has the same issue but it is separate from test-arm.c.
>
> Would you prefer to see a v2 with the swpvsb fix contain fixes for
> test-thumb.c as well, or a separate patch for that?
I think either way is fine. I'd probably go with a combined patch in
this case, since you
are addressing the same issue in two closely related files.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: kprobes: rewrite in UAL
Date: Thu, 28 Jan 2021 22:23:56 +0100 [thread overview]
Message-ID: <CAK8P3a2Jxj-aEe-kk+xsEX19mHOc6LQ8O=XXCrWowAP0Vo2Kew@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOd=ORiCsvv_XQ8By8ZUe0QnzH3T6pFEwnRy65tmUsQ2yQg@mail.gmail.com>
On Thu, Jan 28, 2021 at 7:59 PM 'Nick Desaulniers' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
> On Thu, Jan 28, 2021 at 8:15 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> > Plus a lot of extra errors when building with CONFIG_THUMB2_KERNEL,
> > as that uses tests in arch/arm/probes/kprobes/test-thumb.c.
>
> Technically, that's a distinctly separate issue;
> arch/arm/probes/kprobes/test-arm.c is not built with
> CONFIG_THUMB2_KERNEL=y. This patch doesn't introduce those warnings;
> that file has the same issue but it is separate from test-arm.c.
>
> Would you prefer to see a v2 with the swpvsb fix contain fixes for
> test-thumb.c as well, or a separate patch for that?
I think either way is fine. I'd probably go with a combined patch in
this case, since you
are addressing the same issue in two closely related files.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-28 21:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 4:43 [PATCH] ARM: kprobes: rewrite in UAL Nick Desaulniers
2021-01-28 4:43 ` Nick Desaulniers
2021-01-28 16:15 ` Arnd Bergmann
2021-01-28 16:15 ` Arnd Bergmann
2021-01-28 18:59 ` Nick Desaulniers
2021-01-28 21:23 ` Arnd Bergmann [this message]
2021-01-28 21:23 ` Arnd Bergmann
2021-01-28 19:34 ` [PATCH v2] ARM: kprobes: rewrite test-[arm|thumb].c " Nick Desaulniers
2021-01-28 21:03 ` Ard Biesheuvel
2021-01-28 21:03 ` Ard Biesheuvel
2021-01-28 22:28 ` Arnd Bergmann
2021-01-28 22:28 ` Arnd Bergmann
2021-01-28 23:30 ` Ard Biesheuvel
2021-01-28 23:30 ` Ard Biesheuvel
2021-02-13 11:01 ` Ard Biesheuvel
2021-02-13 11:01 ` Ard Biesheuvel
2021-01-29 0:21 ` Nick Desaulniers
2021-01-29 0:21 ` Nick Desaulniers
2021-01-29 9:40 ` Ard Biesheuvel
2021-01-29 18:54 ` [PATCH v3] ARM: kprobes: rewrite test-arm.c " Nick Desaulniers
2021-01-29 18:54 ` Nick Desaulniers
2021-03-29 22:08 ` [PATCH v2] ARM: kprobes: rewrite test-[arm|thumb].c " Nick Desaulniers
2021-03-29 22:08 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2Jxj-aEe-kk+xsEX19mHOc6LQ8O=XXCrWowAP0Vo2Kew@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.