Re: [PATCH 1/8] ALSA: Replace timespec with timespec64

From: Arnd Bergmann <arnd@arndb.de>
To: kbuild test robot <lkp@intel.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
	kbuild-all@01.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	Ingo Molnar <mingo@kernel.org>,
	SF Markus Elfring <elfring@users.sourceforge.net>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	jeeja.kp@intel.com, Vinod Koul <vinod.koul@intel.com>,
	Guneshwor Singh <guneshwor.o.singh@intel.com>,
	subhransu.s.prusty@intel.com, Bhumika Goyal <bhumirks@gmail.com>,
	gudishax.kranthikumar@intel.com, Naveen M <naveen.m@intel.com>,
	hardik.t.shah@intel.com, Arvind Yadav <arvind.yadav.cs@gmail.com>,
	Fabian Frederick <fabf@skynet.be>,
	alsa-devel@alsa-project.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] ALSA: Replace timespec with timespec64
Date: Thu, 26 Apr 2018 10:30:52 +0200	[thread overview]
Message-ID: <CAK8P3a2TpW8rDw9YrWsJRkyawi+VkqaZQR6_WCSRpn96W6UbEg@mail.gmail.com> (raw)
In-Reply-To: <201804261345.1lsWsCDl%fengguang.wu@intel.com>

On Thu, Apr 26, 2018 at 10:15 AM, kbuild test robot <lkp@intel.com> wrote:
> Hi Baolin,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on v4.17-rc2]
> [also build test ERROR on next-20180424]
> [cannot apply to sound/for-next asoc/for-next arm-soc/for-next]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Baolin-Wang/Fix-year-2038-issue-for-sound-subsystem/20180426-010145
> config: sh-ecovec24_defconfig (attached as .config)
> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=sh
>
> Note: the linux-review/Baolin-Wang/Fix-year-2038-issue-for-sound-subsystem/20180426-010145 HEAD 53cdcc389f07bdd923be240cdb746a97de063301 builds fine.
>       It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
>    sound/core/pcm_lib.c: In function 'update_audio_tstamp':
>>> sound/core/pcm_lib.c:256:54: error: passing argument 2 of 'timespec_equal' from incompatible pointer type [-Werror=incompatible-pointer-types]
>      if (!timespec_equal(&runtime->status->audio_tstamp, audio_tstamp)) {
>                                                          ^~~~~~~~~~~~

Probably a mistake during rebasing: patch 8/8 fixes this, but it should be done
right here by moving the open-coded comparison into the first patch:

-       if (!timespec_equal(&runtime->status->audio_tstamp, audio_tstamp)) {
+       if (runtime->status->audio_tstamp.tv_sec != audio_tstamp->tv_sec ||
+           runtime->status->audio_tstamp.tv_nsec != audio_tstamp->tv_nsec) {

       Arnd