All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Jackie Liu <liu.yun@linux.dev>,
	"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
	<linux-samsung-soc@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Jackie Liu <liuyun01@kylinos.cn>
Subject: Re: [PATCH v2] ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc()
Date: Tue, 26 Oct 2021 17:28:50 +0200	[thread overview]
Message-ID: <CAK8P3a2WwhA8Obz=1yoGbRTTS7w1VU1bUZKkSYxBFhGXo3woGQ@mail.gmail.com> (raw)
In-Reply-To: <957585d9-2f0f-7181-bba3-69c690c92f6f@canonical.com>

On Tue, Oct 26, 2021 at 5:22 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
> On 26/10/2021 17:10, Arnd Bergmann wrote:
> > On Wed, Sep 1, 2021 at 2:35 PM Jackie Liu <liu.yun@linux.dev> wrote:
...
> > Nothing actually uses the return code of s3c24xx_init_intc(), so returning
> > NULL on error there and changing all the checks to that would be a much
> > more straightforward solution.
> >
> > Any chance you could send a follow-up to do that?
>
> I can work on this but you know this is a legacy platform and none of us
> can test it?

Sure. I was actually hoping for Jackie to send you that follow-up.

      Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Jackie Liu <liu.yun@linux.dev>,
	 "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
	<linux-samsung-soc@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Jackie Liu <liuyun01@kylinos.cn>
Subject: Re: [PATCH v2] ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc()
Date: Tue, 26 Oct 2021 17:28:50 +0200	[thread overview]
Message-ID: <CAK8P3a2WwhA8Obz=1yoGbRTTS7w1VU1bUZKkSYxBFhGXo3woGQ@mail.gmail.com> (raw)
In-Reply-To: <957585d9-2f0f-7181-bba3-69c690c92f6f@canonical.com>

On Tue, Oct 26, 2021 at 5:22 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
> On 26/10/2021 17:10, Arnd Bergmann wrote:
> > On Wed, Sep 1, 2021 at 2:35 PM Jackie Liu <liu.yun@linux.dev> wrote:
...
> > Nothing actually uses the return code of s3c24xx_init_intc(), so returning
> > NULL on error there and changing all the checks to that would be a much
> > more straightforward solution.
> >
> > Any chance you could send a follow-up to do that?
>
> I can work on this but you know this is a legacy platform and none of us
> can test it?

Sure. I was actually hoping for Jackie to send you that follow-up.

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-26 15:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 12:35 [PATCH v2] ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc() Jackie Liu
2021-09-01 12:35 ` Jackie Liu
2021-09-06 10:23 ` Jackie Liu
2021-09-06 10:23   ` Jackie Liu
2021-09-06 10:52   ` Krzysztof Kozlowski
2021-09-06 10:52     ` Krzysztof Kozlowski
2021-09-15  7:50 ` Krzysztof Kozlowski
2021-09-15  7:50   ` Krzysztof Kozlowski
2021-10-26 15:10 ` Arnd Bergmann
2021-10-26 15:10   ` Arnd Bergmann
2021-10-26 15:22   ` Krzysztof Kozlowski
2021-10-26 15:22     ` Krzysztof Kozlowski
2021-10-26 15:28     ` Arnd Bergmann [this message]
2021-10-26 15:28       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a2WwhA8Obz=1yoGbRTTS7w1VU1bUZKkSYxBFhGXo3woGQ@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=liu.yun@linux.dev \
    --cc=liuyun01@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.