All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Guo Ren <guoren@kernel.org>
Cc: "Palmer Dabbelt" <palmer@dabbelt.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Anup Patel" <anup.patel@wdc.com>,
	gregkh <gregkh@linuxfoundation.org>,
	liush <liush@allwinnertech.com>,
	wefu@redhat.com, "Drew Fustini" <drew@beagleboard.org>,
	wangjunqiang@iscas.ac.cn, "Wei Wu (吴伟)" <lazyparser@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	linux-csky@vger.kernel.org, "Guo Ren" <guoren@linux.alibaba.com>
Subject: Re: [PATCH 03/13] riscv: compat: Add basic compat date type implementation
Date: Tue, 21 Dec 2021 18:12:46 +0100	[thread overview]
Message-ID: <CAK8P3a3navO2Z2F5zxisby5EBNDo8rwQ6hxSuyniFgFxrQ5qXQ@mail.gmail.com> (raw)
In-Reply-To: <20211221163532.2636028-4-guoren@kernel.org>

On Tue, Dec 21, 2021 at 5:35 PM <guoren@kernel.org> wrote:
>
> From: Guo Ren <guoren@linux.alibaba.com>
>
> Implement asm/compat.h for struct compat_xxx, RLIM_INFINITY,
> OFF_T_MAX, is_compat_task, compat_user_regset, regset convert.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> ---
>  arch/riscv/include/asm/compat.h      | 259 +++++++++++++++++++++++++++

Since both the native and compat side use the generic interface, I think this
should all be part of asm-generic/compat.h, in case other architectures want to
share this in the future. Maybe see if any other architectures use the
same definition
for some of the structures and then remove the duplicates.

> +struct compat_stat {
> +       compat_ulong_t  st_dev;
> +       compat_ulong_t  st_ino;
> +       compat_uint_t   st_mode;
> +       compat_uint_t   st_nlink;

You should not need a compat_stat, because native rv32 does not have a
stat() syscall.

> +static inline int is_compat_task(void)
> +{
> +       return test_thread_flag(TIF_32BIT);
> +}
> +
> +struct compat_user_regs_struct {
> +       compat_ulong_t pc;
> +       compat_ulong_t ra;

These clearly need to stay in arch/riscv

        Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Guo Ren <guoren@kernel.org>
Cc: "Palmer Dabbelt" <palmer@dabbelt.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Anup Patel" <anup.patel@wdc.com>,
	gregkh <gregkh@linuxfoundation.org>,
	liush <liush@allwinnertech.com>,
	wefu@redhat.com, "Drew Fustini" <drew@beagleboard.org>,
	wangjunqiang@iscas.ac.cn, "Wei Wu (吴伟)" <lazyparser@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	linux-csky@vger.kernel.org, "Guo Ren" <guoren@linux.alibaba.com>
Subject: Re: [PATCH 03/13] riscv: compat: Add basic compat date type implementation
Date: Tue, 21 Dec 2021 18:12:46 +0100	[thread overview]
Message-ID: <CAK8P3a3navO2Z2F5zxisby5EBNDo8rwQ6hxSuyniFgFxrQ5qXQ@mail.gmail.com> (raw)
In-Reply-To: <20211221163532.2636028-4-guoren@kernel.org>

On Tue, Dec 21, 2021 at 5:35 PM <guoren@kernel.org> wrote:
>
> From: Guo Ren <guoren@linux.alibaba.com>
>
> Implement asm/compat.h for struct compat_xxx, RLIM_INFINITY,
> OFF_T_MAX, is_compat_task, compat_user_regset, regset convert.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> ---
>  arch/riscv/include/asm/compat.h      | 259 +++++++++++++++++++++++++++

Since both the native and compat side use the generic interface, I think this
should all be part of asm-generic/compat.h, in case other architectures want to
share this in the future. Maybe see if any other architectures use the
same definition
for some of the structures and then remove the duplicates.

> +struct compat_stat {
> +       compat_ulong_t  st_dev;
> +       compat_ulong_t  st_ino;
> +       compat_uint_t   st_mode;
> +       compat_uint_t   st_nlink;

You should not need a compat_stat, because native rv32 does not have a
stat() syscall.

> +static inline int is_compat_task(void)
> +{
> +       return test_thread_flag(TIF_32BIT);
> +}
> +
> +struct compat_user_regs_struct {
> +       compat_ulong_t pc;
> +       compat_ulong_t ra;

These clearly need to stay in arch/riscv

        Arnd

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2021-12-21 17:13 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 16:35 [PATCH 00/13] riscv: compat: Add COMPAT mode support for rv64 guoren
2021-12-21 16:35 ` guoren
2021-12-21 16:35 ` [PATCH 01/13] syscalls: compat: Fix the missing part for __SYSCALL_COMPAT guoren
2021-12-21 16:35   ` guoren
2021-12-21 17:08   ` Arnd Bergmann
2021-12-21 17:08     ` Arnd Bergmann
2021-12-22 11:16     ` Guo Ren
2021-12-22 11:16       ` Guo Ren
2021-12-22 11:24       ` Arnd Bergmann
2021-12-22 11:24         ` Arnd Bergmann
2021-12-24  6:52     ` Christoph Hellwig
2021-12-24  6:52       ` Christoph Hellwig
2021-12-21 16:35 ` [PATCH 02/13] riscv: Fixup difference with defconfig guoren
2021-12-21 16:35   ` guoren
2021-12-21 17:09   ` Arnd Bergmann
2021-12-21 17:09     ` Arnd Bergmann
2021-12-22 11:34     ` Guo Ren
2021-12-22 11:34       ` Guo Ren
2021-12-22 11:44       ` Arnd Bergmann
2021-12-22 11:44         ` Arnd Bergmann
2021-12-22 13:06         ` Guo Ren
2021-12-22 13:06           ` Guo Ren
2021-12-22 13:30           ` Arnd Bergmann
2021-12-22 13:30             ` Arnd Bergmann
2021-12-23  2:12             ` Guo Ren
2021-12-23  2:12               ` Guo Ren
2021-12-21 16:35 ` [PATCH 03/13] riscv: compat: Add basic compat date type implementation guoren
2021-12-21 16:35   ` guoren
2021-12-21 17:12   ` Arnd Bergmann [this message]
2021-12-21 17:12     ` Arnd Bergmann
2021-12-22 12:03     ` Guo Ren
2021-12-22 12:03       ` Guo Ren
2021-12-22 12:46       ` Arnd Bergmann
2021-12-22 12:46         ` Arnd Bergmann
2021-12-26 15:33         ` Guo Ren
2021-12-26 15:33           ` Guo Ren
2021-12-24  6:53   ` Christoph Hellwig
2021-12-24  6:53     ` Christoph Hellwig
2021-12-24  9:28     ` Guo Ren
2021-12-24  9:28       ` Guo Ren
2021-12-21 16:35 ` [PATCH 04/13] riscv: compat: Re-implement TASK_SIZE for COMPAT_32BIT guoren
2021-12-21 16:35   ` guoren
2021-12-21 16:35 ` [PATCH 05/13] riscv: compat: syscall: Add compat_sys_call_table implementation guoren
2021-12-21 16:35   ` guoren
2021-12-21 17:15   ` Arnd Bergmann
2021-12-21 17:15     ` Arnd Bergmann
2021-12-22 12:43     ` Guo Ren
2021-12-22 12:43       ` Guo Ren
2021-12-22 13:21       ` Arnd Bergmann
2021-12-22 13:21         ` Arnd Bergmann
2021-12-22 14:00         ` Arnd Bergmann
2021-12-22 14:00           ` Arnd Bergmann
2021-12-24  9:42           ` Guo Ren
2021-12-24  9:42             ` Guo Ren
2021-12-21 16:35 ` [PATCH 06/13] riscv: compat: syscall: Add entry.S implementation guoren
2021-12-21 16:35   ` guoren
2021-12-21 16:35 ` [PATCH 07/13] riscv: compat: Add elf.h implementation guoren
2021-12-21 16:35   ` guoren
2021-12-21 16:35 ` [PATCH 08/13] riscv: compat: Add COMPAT Kbuild skeletal support guoren
2021-12-21 16:35   ` guoren
2021-12-21 17:21   ` Arnd Bergmann
2021-12-21 17:21     ` Arnd Bergmann
2021-12-22 12:06     ` Guo Ren
2021-12-22 12:06       ` Guo Ren
2021-12-24  6:54       ` Christoph Hellwig
2021-12-24  6:54         ` Christoph Hellwig
2021-12-21 16:35 ` [PATCH 09/13] riscv: compat: init: Add hw-cap detect in setup_arch guoren
2021-12-21 16:35   ` guoren
2021-12-21 16:35 ` [PATCH 10/13] riscv: compat: vdso: Add rv32 VDSO base code implementation guoren
2021-12-21 16:35   ` guoren
2021-12-21 16:35 ` [PATCH 11/13] riscv: compat: vdso: Add setup additional pages implementation guoren
2021-12-21 16:35   ` guoren
2021-12-21 16:35 ` [PATCH 12/13] riscv: compat: signal: Add rt_frame implementation guoren
2021-12-21 16:35   ` guoren
2021-12-21 16:35 ` [PATCH 13/13] riscv: compat: ptrace: Add compat_arch_ptrace implement guoren
2021-12-21 16:35   ` guoren
2021-12-21 17:38 ` [PATCH 00/13] riscv: compat: Add COMPAT mode support for rv64 Arnd Bergmann
2021-12-21 17:38   ` Arnd Bergmann
2021-12-22 12:59   ` Guo Ren
2021-12-22 12:59     ` Guo Ren
2021-12-22 13:29     ` Arnd Bergmann
2021-12-22 13:29       ` Arnd Bergmann
2021-12-26  8:22     ` Jisheng Zhang
2021-12-26  8:22       ` Jisheng Zhang
2021-12-26 12:38       ` Guo Ren
2021-12-26 12:38         ` Guo Ren
2021-12-26 20:31         ` Arnd Bergmann
2021-12-26 20:31           ` Arnd Bergmann
2021-12-27  1:16           ` Guo Ren
2021-12-27  1:16             ` Guo Ren
2021-12-27  2:29             ` Jessica Clarke
2021-12-27  2:29               ` Jessica Clarke
2021-12-28 10:45               ` Guo Ren
2021-12-28 10:45                 ` Guo Ren
2021-12-22 12:00 ` Guo Ren
2021-12-22 12:00   ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a3navO2Z2F5zxisby5EBNDo8rwQ6hxSuyniFgFxrQ5qXQ@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=anup.patel@wdc.com \
    --cc=drew@beagleboard.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=guoren@kernel.org \
    --cc=guoren@linux.alibaba.com \
    --cc=lazyparser@gmail.com \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=liush@allwinnertech.com \
    --cc=palmer@dabbelt.com \
    --cc=wangjunqiang@iscas.ac.cn \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.