All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brad Larson <brad@pensando.io>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Mark Brown <broonie@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Olof Johansson <olof@lixom.net>, David Clear <dac2@pensando.io>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support
Date: Wed, 25 May 2022 13:06:23 -0700	[thread overview]
Message-ID: <CAK9rFnz9a_21Bc9yyUqqmQET_o6g5XK6=mfZVv9jUp4dNxCx4w@mail.gmail.com> (raw)
In-Reply-To: <20220412112239.cucvqqlfsdpjnzju@mobilestation>

Hi Sergey,

On Tue, Apr 12, 2022 at 4:22 AM Serge Semin <fancer.lancer@gmail.com> wrote:
>
> On Wed, Apr 06, 2022 at 04:36:48PM -0700, Brad Larson wrote:

> > +             spi0: spi@2800 {
> > +                     compatible = "pensando,elba-spi";
> > +                     reg = <0x0 0x2800 0x0 0x100>;
>
> > +                     pensando,syscon-spics = <&mssoc 0x2468>;
>
> I am wondering do you really need to define the
> "pensando,syscon-spics" property as accepting a phandle with an
> additional argument? That would have been justified if you had at
> least two SPI controllers with different CS override registers. AFAICS
> you've got only one here. So you can simplify the bindings by defining
> the property like "pensando,syscon" (with no "spics" suffix) which
> accepts the syscon phandle alone. Respective SPICS offset can be
> locally declared in the driver as a macro with respective name.

Yes this can be simplified and doing that in updated patchset.  Only this
API call is needed in dw_spi_elba_init().

syscon_regmap_lookup_by_phandle(np, "pensando,syscon");

Regards,
Brad

WARNING: multiple messages have this Message-ID (diff)
From: Brad Larson <brad@pensando.io>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Arnd Bergmann <arnd@arndb.de>,
	 Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	 Mark Brown <broonie@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 Ulf Hansson <ulf.hansson@linaro.org>,
	Olof Johansson <olof@lixom.net>, David Clear <dac2@pensando.io>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	 linux-mmc <linux-mmc@vger.kernel.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support
Date: Wed, 25 May 2022 13:06:23 -0700	[thread overview]
Message-ID: <CAK9rFnz9a_21Bc9yyUqqmQET_o6g5XK6=mfZVv9jUp4dNxCx4w@mail.gmail.com> (raw)
In-Reply-To: <20220412112239.cucvqqlfsdpjnzju@mobilestation>

Hi Sergey,

On Tue, Apr 12, 2022 at 4:22 AM Serge Semin <fancer.lancer@gmail.com> wrote:
>
> On Wed, Apr 06, 2022 at 04:36:48PM -0700, Brad Larson wrote:

> > +             spi0: spi@2800 {
> > +                     compatible = "pensando,elba-spi";
> > +                     reg = <0x0 0x2800 0x0 0x100>;
>
> > +                     pensando,syscon-spics = <&mssoc 0x2468>;
>
> I am wondering do you really need to define the
> "pensando,syscon-spics" property as accepting a phandle with an
> additional argument? That would have been justified if you had at
> least two SPI controllers with different CS override registers. AFAICS
> you've got only one here. So you can simplify the bindings by defining
> the property like "pensando,syscon" (with no "spics" suffix) which
> accepts the syscon phandle alone. Respective SPICS offset can be
> locally declared in the driver as a macro with respective name.

Yes this can be simplified and doing that in updated patchset.  Only this
API call is needed in dw_spi_elba_init().

syscon_regmap_lookup_by_phandle(np, "pensando,syscon");

Regards,
Brad

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-25 20:06 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 23:36 [PATCH 00/11] Support Pensando Elba SoC Brad Larson
2022-04-06 23:36 ` Brad Larson
2022-04-06 23:36 ` [PATCH 01/11] dt-bindings: arm: add Pensando boards Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-07 18:45   ` Krzysztof Kozlowski
2022-04-07 18:45     ` Krzysztof Kozlowski
2022-04-09  2:19     ` Brad Larson
2022-04-09  2:19       ` Brad Larson
2022-04-09 10:39       ` Krzysztof Kozlowski
2022-04-09 10:39         ` Krzysztof Kozlowski
2022-04-11 21:24         ` Serge Semin
2022-04-11 21:24           ` Serge Semin
2022-05-25 16:31         ` Brad Larson
2022-05-25 16:31           ` Brad Larson
2022-04-07 18:54   ` Krzysztof Kozlowski
2022-04-07 18:54     ` Krzysztof Kozlowski
2022-04-09  2:04     ` Brad Larson
2022-04-09  2:04       ` Brad Larson
2022-04-06 23:36 ` [PATCH 02/11] dt-bindings: Add vendor prefix for Pensando Systems Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-07 18:43   ` Krzysztof Kozlowski
2022-04-07 18:43     ` Krzysztof Kozlowski
2022-04-09  2:00     ` Brad Larson
2022-04-09  2:00       ` Brad Larson
2022-04-06 23:36 ` [PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-07  6:30   ` Arnd Bergmann
2022-04-07  6:30     ` Arnd Bergmann
2022-05-25 15:46     ` Brad Larson
2022-05-25 15:46       ` Brad Larson
2022-04-07 18:57   ` Krzysztof Kozlowski
2022-04-07 18:57     ` Krzysztof Kozlowski
2022-05-25 15:49     ` Brad Larson
2022-05-25 15:49       ` Brad Larson
2022-04-06 23:36 ` [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-07 18:59   ` Krzysztof Kozlowski
2022-04-07 18:59     ` Krzysztof Kozlowski
2022-05-25 16:58     ` Brad Larson
2022-05-25 16:58       ` Brad Larson
2022-04-12 11:37   ` Serge Semin
2022-04-12 11:37     ` Serge Semin
2022-05-25 17:03     ` Brad Larson
2022-05-25 17:03       ` Brad Larson
2022-04-06 23:36 ` [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-07 18:52   ` Krzysztof Kozlowski
2022-04-07 18:52     ` Krzysztof Kozlowski
2022-04-11 21:17     ` Serge Semin
2022-04-11 21:17       ` Serge Semin
2022-05-26  0:27     ` Brad Larson
2022-05-26  0:27       ` Brad Larson
2022-04-12 11:29   ` Serge Semin
2022-04-12 11:29     ` Serge Semin
2022-04-06 23:36 ` [PATCH 06/11] MAINTAINERS: Add entry for PENSANDO Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-06 23:36 ` [PATCH 07/11] arm64: Add config for Pensando SoC platforms Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-06 23:36 ` [PATCH 08/11] spi: cadence-quadspi: Add compatible for Pensando Elba SoC Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-06 23:36 ` [PATCH 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-07  6:45   ` Arnd Bergmann
2022-04-07  6:45     ` Arnd Bergmann
2022-04-07  7:13     ` Adrian Hunter
2022-04-07  7:13       ` Adrian Hunter
2022-04-07 17:06       ` Brad Larson
2022-04-07 17:06         ` Brad Larson
2022-04-07 20:38         ` Arnd Bergmann
2022-04-07 20:38           ` Arnd Bergmann
2022-05-25 16:10           ` Brad Larson
2022-05-25 16:10             ` Brad Larson
2022-04-06 23:36 ` [PATCH 10/11] spi: dw: Add support for Pensando Elba SoC Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-12 11:06   ` Serge Semin
2022-04-12 11:06     ` Serge Semin
2022-05-25 21:54     ` Brad Larson
2022-05-25 21:54       ` Brad Larson
2022-04-06 23:36 ` [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support Brad Larson
2022-04-06 23:36   ` Brad Larson
2022-04-07  7:57   ` Marc Zyngier
2022-04-07  7:57     ` Marc Zyngier
2022-04-09  2:38     ` Brad Larson
2022-04-09  2:38       ` Brad Larson
2022-04-09  9:18       ` Marc Zyngier
2022-04-09  9:18         ` Marc Zyngier
2022-05-25 17:28         ` Brad Larson
2022-05-25 17:28           ` Brad Larson
2022-04-07 19:06   ` Krzysztof Kozlowski
2022-04-07 19:06     ` Krzysztof Kozlowski
2022-05-26  0:19     ` Brad Larson
2022-05-26  0:19       ` Brad Larson
2022-05-26  6:53       ` Krzysztof Kozlowski
2022-05-26  6:53         ` Krzysztof Kozlowski
2022-04-07 20:58   ` Krzysztof Kozlowski
2022-04-07 20:58     ` Krzysztof Kozlowski
2022-04-12 11:22   ` Serge Semin
2022-04-12 11:22     ` Serge Semin
2022-05-25 20:06     ` Brad Larson [this message]
2022-05-25 20:06       ` Brad Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK9rFnz9a_21Bc9yyUqqmQET_o6g5XK6=mfZVv9jUp4dNxCx4w@mail.gmail.com' \
    --to=brad@pensando.io \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=adrian.hunter@intel.com \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=dac2@pensando.io \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.