* [PATCH] staging: lustre: llite: rw26: Remove unused function definition
@ 2017-03-11 6:31 sayli karnik
2017-03-12 13:40 ` [Outreachy kernel] " Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: sayli karnik @ 2017-03-11 6:31 UTC (permalink / raw)
To: outreachy-kernel
Cc: Oleg Drokin, Andreas Dilger, James Simmons, Greg Kroah-Hartman
The patch removes unused function definition ll_get_user_pages().
Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
drivers/staging/lustre/lustre/llite/rw26.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
index d89e795..420f296 100644
--- a/drivers/staging/lustre/lustre/llite/rw26.c
+++ b/drivers/staging/lustre/lustre/llite/rw26.c
@@ -156,32 +156,6 @@ static int ll_releasepage(struct page *vmpage, gfp_t gfp_mask)
#define MAX_DIRECTIO_SIZE (2 * 1024 * 1024 * 1024UL)
-static inline int ll_get_user_pages(int rw, unsigned long user_addr,
- size_t size, struct page ***pages,
- int *max_pages)
-{
- int result = -ENOMEM;
-
- /* set an arbitrary limit to prevent arithmetic overflow */
- if (size > MAX_DIRECTIO_SIZE) {
- *pages = NULL;
- return -EFBIG;
- }
-
- *max_pages = (user_addr + size + PAGE_SIZE - 1) >> PAGE_SHIFT;
- *max_pages -= user_addr >> PAGE_SHIFT;
-
- *pages = libcfs_kvzalloc(*max_pages * sizeof(**pages), GFP_NOFS);
- if (*pages) {
- result = get_user_pages_fast(user_addr, *max_pages,
- (rw == READ), *pages);
- if (unlikely(result <= 0))
- kvfree(*pages);
- }
-
- return result;
-}
-
/* ll_free_user_pages - tear down page struct array
* @pages: array of page struct pointers underlying target buffer
*/
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: lustre: llite: rw26: Remove unused function definition
2017-03-11 6:31 [PATCH] staging: lustre: llite: rw26: Remove unused function definition sayli karnik
@ 2017-03-12 13:40 ` Greg Kroah-Hartman
2017-03-15 9:07 ` Dilger, Andreas
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-12 13:40 UTC (permalink / raw)
To: sayli karnik; +Cc: outreachy-kernel, Oleg Drokin, Andreas Dilger, James Simmons
On Sat, Mar 11, 2017 at 12:01:53PM +0530, sayli karnik wrote:
> The patch removes unused function definition ll_get_user_pages().
>
> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/rw26.c | 26 --------------------------
> 1 file changed, 26 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
> index d89e795..420f296 100644
> --- a/drivers/staging/lustre/lustre/llite/rw26.c
> +++ b/drivers/staging/lustre/lustre/llite/rw26.c
> @@ -156,32 +156,6 @@ static int ll_releasepage(struct page *vmpage, gfp_t gfp_mask)
>
> #define MAX_DIRECTIO_SIZE (2 * 1024 * 1024 * 1024UL)
>
> -static inline int ll_get_user_pages(int rw, unsigned long user_addr,
> - size_t size, struct page ***pages,
> - int *max_pages)
> -{
> - int result = -ENOMEM;
> -
> - /* set an arbitrary limit to prevent arithmetic overflow */
> - if (size > MAX_DIRECTIO_SIZE) {
> - *pages = NULL;
> - return -EFBIG;
> - }
> -
> - *max_pages = (user_addr + size + PAGE_SIZE - 1) >> PAGE_SHIFT;
> - *max_pages -= user_addr >> PAGE_SHIFT;
> -
> - *pages = libcfs_kvzalloc(*max_pages * sizeof(**pages), GFP_NOFS);
> - if (*pages) {
> - result = get_user_pages_fast(user_addr, *max_pages,
> - (rw == READ), *pages);
> - if (unlikely(result <= 0))
> - kvfree(*pages);
> - }
> -
> - return result;
> -}
> -
Should this be deleted? Given that ll_free_user_pages() is used, that
implies that this function should also be used somewhere. Why isn't it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: lustre: llite: rw26: Remove unused function definition
2017-03-12 13:40 ` [Outreachy kernel] " Greg Kroah-Hartman
@ 2017-03-15 9:07 ` Dilger, Andreas
2017-03-15 16:05 ` sayli karnik
0 siblings, 1 reply; 5+ messages in thread
From: Dilger, Andreas @ 2017-03-15 9:07 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: sayli karnik, outreachy-kernel, Drokin, Oleg, James Simmons
On Mar 12, 2017, at 07:40, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Mar 11, 2017 at 12:01:53PM +0530, sayli karnik wrote:
>> The patch removes unused function definition ll_get_user_pages().
>>
>> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/llite/rw26.c | 26 --------------------------
>> 1 file changed, 26 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
>> index d89e795..420f296 100644
>> --- a/drivers/staging/lustre/lustre/llite/rw26.c
>> +++ b/drivers/staging/lustre/lustre/llite/rw26.c
>> @@ -156,32 +156,6 @@ static int ll_releasepage(struct page *vmpage, gfp_t gfp_mask)
>>
>> #define MAX_DIRECTIO_SIZE (2 * 1024 * 1024 * 1024UL)
>>
>> -static inline int ll_get_user_pages(int rw, unsigned long user_addr,
>> - size_t size, struct page ***pages,
>> - int *max_pages)
>> -{
>> - int result = -ENOMEM;
>> -
>> - /* set an arbitrary limit to prevent arithmetic overflow */
>> - if (size > MAX_DIRECTIO_SIZE) {
>> - *pages = NULL;
>> - return -EFBIG;
>> - }
>> -
>> - *max_pages = (user_addr + size + PAGE_SIZE - 1) >> PAGE_SHIFT;
>> - *max_pages -= user_addr >> PAGE_SHIFT;
>> -
>> - *pages = libcfs_kvzalloc(*max_pages * sizeof(**pages), GFP_NOFS);
>> - if (*pages) {
>> - result = get_user_pages_fast(user_addr, *max_pages,
>> - (rw == READ), *pages);
>> - if (unlikely(result <= 0))
>> - kvfree(*pages);
>> - }
>> -
>> - return result;
>> -}
>> -
>
> Should this be deleted? Given that ll_free_user_pages() is used, that
> implies that this function should also be used somewhere. Why isn't it?
Al replaced the use of ll_get_user_pages() with iov_iter_get_pages_alloc() in
commit 91f79c43d1b54d7154b118860d81b39bad07dfff so it is no longer used.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: lustre: llite: rw26: Remove unused function definition
2017-03-15 9:07 ` Dilger, Andreas
@ 2017-03-15 16:05 ` sayli karnik
2017-03-16 1:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: sayli karnik @ 2017-03-15 16:05 UTC (permalink / raw)
To: Dilger, Andreas
Cc: Greg Kroah-Hartman, outreachy-kernel, Drokin, Oleg, James Simmons
On Wed, Mar 15, 2017 at 2:37 PM, Dilger, Andreas
<andreas.dilger@intel.com> wrote:
> On Mar 12, 2017, at 07:40, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>>
>> On Sat, Mar 11, 2017 at 12:01:53PM +0530, sayli karnik wrote:
>>> The patch removes unused function definition ll_get_user_pages().
>>>
>>> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
>>> ---
>>> drivers/staging/lustre/lustre/llite/rw26.c | 26 --------------------------
>>> 1 file changed, 26 deletions(-)
>>>
>>> diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
>>> index d89e795..420f296 100644
>>> --- a/drivers/staging/lustre/lustre/llite/rw26.c
>>> +++ b/drivers/staging/lustre/lustre/llite/rw26.c
>>> @@ -156,32 +156,6 @@ static int ll_releasepage(struct page *vmpage, gfp_t gfp_mask)
>>>
>>> #define MAX_DIRECTIO_SIZE (2 * 1024 * 1024 * 1024UL)
>>>
>>> -static inline int ll_get_user_pages(int rw, unsigned long user_addr,
>>> - size_t size, struct page ***pages,
>>> - int *max_pages)
>>> -{
>>> - int result = -ENOMEM;
>>> -
>>> - /* set an arbitrary limit to prevent arithmetic overflow */
>>> - if (size > MAX_DIRECTIO_SIZE) {
>>> - *pages = NULL;
>>> - return -EFBIG;
>>> - }
>>> -
>>> - *max_pages = (user_addr + size + PAGE_SIZE - 1) >> PAGE_SHIFT;
>>> - *max_pages -= user_addr >> PAGE_SHIFT;
>>> -
>>> - *pages = libcfs_kvzalloc(*max_pages * sizeof(**pages), GFP_NOFS);
>>> - if (*pages) {
>>> - result = get_user_pages_fast(user_addr, *max_pages,
>>> - (rw == READ), *pages);
>>> - if (unlikely(result <= 0))
>>> - kvfree(*pages);
>>> - }
>>> -
>>> - return result;
>>> -}
>>> -
>>
>> Should this be deleted? Given that ll_free_user_pages() is used, that
>> implies that this function should also be used somewhere. Why isn't it?
>
> Al replaced the use of ll_get_user_pages() with iov_iter_get_pages_alloc() in
> commit 91f79c43d1b54d7154b118860d81b39bad07dfff so it is no longer used.
>
Yes it is, thanks for the input!
> Cheers, Andreas
> --
> Andreas Dilger
> Lustre Principal Architect
> Intel Corporation
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: lustre: llite: rw26: Remove unused function definition
2017-03-15 16:05 ` sayli karnik
@ 2017-03-16 1:50 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-16 1:50 UTC (permalink / raw)
To: sayli karnik
Cc: Dilger, Andreas, outreachy-kernel, Drokin, Oleg, James Simmons
On Wed, Mar 15, 2017 at 09:35:31PM +0530, sayli karnik wrote:
> On Wed, Mar 15, 2017 at 2:37 PM, Dilger, Andreas
> <andreas.dilger@intel.com> wrote:
> > On Mar 12, 2017, at 07:40, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >>
> >> On Sat, Mar 11, 2017 at 12:01:53PM +0530, sayli karnik wrote:
> >>> The patch removes unused function definition ll_get_user_pages().
> >>>
> >>> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> >>> ---
> >>> drivers/staging/lustre/lustre/llite/rw26.c | 26 --------------------------
> >>> 1 file changed, 26 deletions(-)
> >>>
> >>> diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
> >>> index d89e795..420f296 100644
> >>> --- a/drivers/staging/lustre/lustre/llite/rw26.c
> >>> +++ b/drivers/staging/lustre/lustre/llite/rw26.c
> >>> @@ -156,32 +156,6 @@ static int ll_releasepage(struct page *vmpage, gfp_t gfp_mask)
> >>>
> >>> #define MAX_DIRECTIO_SIZE (2 * 1024 * 1024 * 1024UL)
> >>>
> >>> -static inline int ll_get_user_pages(int rw, unsigned long user_addr,
> >>> - size_t size, struct page ***pages,
> >>> - int *max_pages)
> >>> -{
> >>> - int result = -ENOMEM;
> >>> -
> >>> - /* set an arbitrary limit to prevent arithmetic overflow */
> >>> - if (size > MAX_DIRECTIO_SIZE) {
> >>> - *pages = NULL;
> >>> - return -EFBIG;
> >>> - }
> >>> -
> >>> - *max_pages = (user_addr + size + PAGE_SIZE - 1) >> PAGE_SHIFT;
> >>> - *max_pages -= user_addr >> PAGE_SHIFT;
> >>> -
> >>> - *pages = libcfs_kvzalloc(*max_pages * sizeof(**pages), GFP_NOFS);
> >>> - if (*pages) {
> >>> - result = get_user_pages_fast(user_addr, *max_pages,
> >>> - (rw == READ), *pages);
> >>> - if (unlikely(result <= 0))
> >>> - kvfree(*pages);
> >>> - }
> >>> -
> >>> - return result;
> >>> -}
> >>> -
> >>
> >> Should this be deleted? Given that ll_free_user_pages() is used, that
> >> implies that this function should also be used somewhere. Why isn't it?
> >
> > Al replaced the use of ll_get_user_pages() with iov_iter_get_pages_alloc() in
> > commit 91f79c43d1b54d7154b118860d81b39bad07dfff so it is no longer used.
> >
> Yes it is, thanks for the input!
Ok, can you please resend this patch with this information in the
changelog text so I don't ask it again when I see it again?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-16 1:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-11 6:31 [PATCH] staging: lustre: llite: rw26: Remove unused function definition sayli karnik
2017-03-12 13:40 ` [Outreachy kernel] " Greg Kroah-Hartman
2017-03-15 9:07 ` Dilger, Andreas
2017-03-15 16:05 ` sayli karnik
2017-03-16 1:50 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.