All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drm/lima: Make lima_sched_ops static
@ 2019-04-16 14:43 ` Yue Haibing
  0 siblings, 0 replies; 5+ messages in thread
From: Yue Haibing @ 2019-04-16 14:43 UTC (permalink / raw)
  To: yuq825, airlied, daniel; +Cc: linux-kernel, lima, dri-devel, YueHaibing

From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
 symbol 'lima_sched_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/lima/lima_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
index 97bd9c1..569f0a95 100644
--- a/drivers/gpu/drm/lima/lima_sched.c
+++ b/drivers/gpu/drm/lima/lima_sched.c
@@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
 	kmem_cache_free(pipe->task_slab, task);
 }
 
-const struct drm_sched_backend_ops lima_sched_ops = {
+static const struct drm_sched_backend_ops lima_sched_ops = {
 	.dependency = lima_sched_dependency,
 	.run_job = lima_sched_run_job,
 	.timedout_job = lima_sched_timedout_job,
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH -next] drm/lima: Make lima_sched_ops static
@ 2019-04-16 14:43 ` Yue Haibing
  0 siblings, 0 replies; 5+ messages in thread
From: Yue Haibing @ 2019-04-16 14:43 UTC (permalink / raw)
  To: yuq825, airlied, daniel; +Cc: linux-kernel, lima, dri-devel, YueHaibing

From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
 symbol 'lima_sched_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/lima/lima_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
index 97bd9c1..569f0a95 100644
--- a/drivers/gpu/drm/lima/lima_sched.c
+++ b/drivers/gpu/drm/lima/lima_sched.c
@@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
 	kmem_cache_free(pipe->task_slab, task);
 }
 
-const struct drm_sched_backend_ops lima_sched_ops = {
+static const struct drm_sched_backend_ops lima_sched_ops = {
 	.dependency = lima_sched_dependency,
 	.run_job = lima_sched_run_job,
 	.timedout_job = lima_sched_timedout_job,
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/lima: Make lima_sched_ops static
  2019-04-16 14:43 ` Yue Haibing
@ 2019-04-17  2:42   ` Qiang Yu
  -1 siblings, 0 replies; 5+ messages in thread
From: Qiang Yu @ 2019-04-17  2:42 UTC (permalink / raw)
  To: Yue Haibing
  Cc: David Airlie, Daniel Vetter, Linux Kernel Mailing List, lima, dri-devel

Thanks, patch is:
Reviewed-by: Qiang Yu <yuq825@gmail.com>

I'll add a "Fix" tag and push it to drm-misc-next.

Regards,
Qiang

On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
>  symbol 'lima_sched_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpu/drm/lima/lima_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
> index 97bd9c1..569f0a95 100644
> --- a/drivers/gpu/drm/lima/lima_sched.c
> +++ b/drivers/gpu/drm/lima/lima_sched.c
> @@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
>         kmem_cache_free(pipe->task_slab, task);
>  }
>
> -const struct drm_sched_backend_ops lima_sched_ops = {
> +static const struct drm_sched_backend_ops lima_sched_ops = {
>         .dependency = lima_sched_dependency,
>         .run_job = lima_sched_run_job,
>         .timedout_job = lima_sched_timedout_job,
> --
> 2.7.4
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/lima: Make lima_sched_ops static
@ 2019-04-17  2:42   ` Qiang Yu
  0 siblings, 0 replies; 5+ messages in thread
From: Qiang Yu @ 2019-04-17  2:42 UTC (permalink / raw)
  To: Yue Haibing; +Cc: David Airlie, dri-devel, Linux Kernel Mailing List, lima

Thanks, patch is:
Reviewed-by: Qiang Yu <yuq825@gmail.com>

I'll add a "Fix" tag and push it to drm-misc-next.

Regards,
Qiang

On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
>  symbol 'lima_sched_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpu/drm/lima/lima_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
> index 97bd9c1..569f0a95 100644
> --- a/drivers/gpu/drm/lima/lima_sched.c
> +++ b/drivers/gpu/drm/lima/lima_sched.c
> @@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
>         kmem_cache_free(pipe->task_slab, task);
>  }
>
> -const struct drm_sched_backend_ops lima_sched_ops = {
> +static const struct drm_sched_backend_ops lima_sched_ops = {
>         .dependency = lima_sched_dependency,
>         .run_job = lima_sched_run_job,
>         .timedout_job = lima_sched_timedout_job,
> --
> 2.7.4
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/lima: Make lima_sched_ops static
  2019-04-16 14:43 ` Yue Haibing
  (?)
  (?)
@ 2019-04-17 13:06 ` Qiang Yu
  -1 siblings, 0 replies; 5+ messages in thread
From: Qiang Yu @ 2019-04-17 13:06 UTC (permalink / raw)
  To: Yue Haibing
  Cc: David Airlie, Daniel Vetter, Linux Kernel Mailing List, lima, dri-devel

Pushed to drm-misc-next.

Thanks,
Qiang

On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
>  symbol 'lima_sched_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpu/drm/lima/lima_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
> index 97bd9c1..569f0a95 100644
> --- a/drivers/gpu/drm/lima/lima_sched.c
> +++ b/drivers/gpu/drm/lima/lima_sched.c
> @@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
>         kmem_cache_free(pipe->task_slab, task);
>  }
>
> -const struct drm_sched_backend_ops lima_sched_ops = {
> +static const struct drm_sched_backend_ops lima_sched_ops = {
>         .dependency = lima_sched_dependency,
>         .run_job = lima_sched_run_job,
>         .timedout_job = lima_sched_timedout_job,
> --
> 2.7.4
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-17 13:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16 14:43 [PATCH -next] drm/lima: Make lima_sched_ops static Yue Haibing
2019-04-16 14:43 ` Yue Haibing
2019-04-17  2:42 ` Qiang Yu
2019-04-17  2:42   ` Qiang Yu
2019-04-17 13:06 ` Qiang Yu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.