From: Daniel Vetter <daniel@ffwll.ch> To: "Christian König" <christian.koenig@amd.com> Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>, Jason Ekstrand <jason@jlekstrand.net> Subject: Re: [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails Date: Wed, 21 Jul 2021 11:12:19 +0200 [thread overview] Message-ID: <CAKMK7uE1c=nhY9JNpLhky=ty4OXYfM3wcLi6EMhhVSH=otKagg@mail.gmail.com> (raw) In-Reply-To: <acfefe81-1eae-af52-c045-1d2c1dcb162a@amd.com> On Wed, Jul 21, 2021 at 11:08 AM Christian König <christian.koenig@amd.com> wrote: > Am 21.07.21 um 11:06 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 8:36 AM Christian König > > <christian.koenig@amd.com> wrote: > >> Am 20.07.21 um 20:13 schrieb Jason Ekstrand: > >>> If we have a failure, decrement the reference count so that the next > >>> call to ttm_global_init() will actually do something instead of assume > >>> everything is all set up. > >>> > >>> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > >>> Fixes: 62b53b37e4b1 ("drm/ttm: use a static ttm_bo_global instance") > >>> Reviewed-by: Christian König <christian.koenig@amd.com> > >> I've just pushed this to drm-misc-fixes. > > Did you see patch 5/6 here which is also touching ttm? > > Nope, neither with my AMD nor with my GMail account. > > Looks like something is wrong with the distribution of mails over the > mailing list for a few days now. Ping admins on #freedesktop on oftc, they can usually chase where mails are stuck. It works all fine for me, but I've seen you complain that you didn't get all the msm patches too, so figured better I highlight in case it's lost. > Going to double check patchwork. https://lore.kernel.org/dri-devel/20210720181357.2760720-6-jason@jlekstrand.net/ Cheers, Daniel > > Christian. > > > -Daniel > > > >> Thanks, > >> Christian. > >> > >>> --- > >>> drivers/gpu/drm/ttm/ttm_device.c | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c > >>> index 5f31acec3ad76..519deea8e39b7 100644 > >>> --- a/drivers/gpu/drm/ttm/ttm_device.c > >>> +++ b/drivers/gpu/drm/ttm/ttm_device.c > >>> @@ -100,6 +100,8 @@ static int ttm_global_init(void) > >>> debugfs_create_atomic_t("buffer_objects", 0444, ttm_debugfs_root, > >>> &glob->bo_count); > >>> out: > >>> + if (ret) > >>> + --ttm_glob_use_count; > >>> mutex_unlock(&ttm_global_mutex); > >>> return ret; > >>> } > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fintel-gfx&data=04%7C01%7Cchristian.koenig%40amd.com%7C05ff233273a54b987b6b08d94c26d0ac%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637624551867495341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=70RYQ49Q58VED5jMpJ%2FW9Vy5imUndghFS0tQWIeD7dk%3D&reserved=0 > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: "Christian König" <christian.koenig@amd.com> Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails Date: Wed, 21 Jul 2021 11:12:19 +0200 [thread overview] Message-ID: <CAKMK7uE1c=nhY9JNpLhky=ty4OXYfM3wcLi6EMhhVSH=otKagg@mail.gmail.com> (raw) In-Reply-To: <acfefe81-1eae-af52-c045-1d2c1dcb162a@amd.com> On Wed, Jul 21, 2021 at 11:08 AM Christian König <christian.koenig@amd.com> wrote: > Am 21.07.21 um 11:06 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 8:36 AM Christian König > > <christian.koenig@amd.com> wrote: > >> Am 20.07.21 um 20:13 schrieb Jason Ekstrand: > >>> If we have a failure, decrement the reference count so that the next > >>> call to ttm_global_init() will actually do something instead of assume > >>> everything is all set up. > >>> > >>> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > >>> Fixes: 62b53b37e4b1 ("drm/ttm: use a static ttm_bo_global instance") > >>> Reviewed-by: Christian König <christian.koenig@amd.com> > >> I've just pushed this to drm-misc-fixes. > > Did you see patch 5/6 here which is also touching ttm? > > Nope, neither with my AMD nor with my GMail account. > > Looks like something is wrong with the distribution of mails over the > mailing list for a few days now. Ping admins on #freedesktop on oftc, they can usually chase where mails are stuck. It works all fine for me, but I've seen you complain that you didn't get all the msm patches too, so figured better I highlight in case it's lost. > Going to double check patchwork. https://lore.kernel.org/dri-devel/20210720181357.2760720-6-jason@jlekstrand.net/ Cheers, Daniel > > Christian. > > > -Daniel > > > >> Thanks, > >> Christian. > >> > >>> --- > >>> drivers/gpu/drm/ttm/ttm_device.c | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c > >>> index 5f31acec3ad76..519deea8e39b7 100644 > >>> --- a/drivers/gpu/drm/ttm/ttm_device.c > >>> +++ b/drivers/gpu/drm/ttm/ttm_device.c > >>> @@ -100,6 +100,8 @@ static int ttm_global_init(void) > >>> debugfs_create_atomic_t("buffer_objects", 0444, ttm_debugfs_root, > >>> &glob->bo_count); > >>> out: > >>> + if (ret) > >>> + --ttm_glob_use_count; > >>> mutex_unlock(&ttm_global_mutex); > >>> return ret; > >>> } > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fintel-gfx&data=04%7C01%7Cchristian.koenig%40amd.com%7C05ff233273a54b987b6b08d94c26d0ac%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637624551867495341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=70RYQ49Q58VED5jMpJ%2FW9Vy5imUndghFS0tQWIeD7dk%3D&reserved=0 > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-21 9:12 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-20 18:13 [PATCH 0/6] Fix the debugfs splat from mock selftests Jason Ekstrand 2021-07-20 18:13 ` [Intel-gfx] " Jason Ekstrand 2021-07-20 18:13 ` [PATCH 1/6] drm/i915: Call i915_globals_exit() after i915_pmu_exit() Jason Ekstrand 2021-07-20 18:13 ` [Intel-gfx] " Jason Ekstrand 2021-07-20 18:13 ` [PATCH 2/6] drm/i915: Call i915_globals_exit() if pci_register_device() fails Jason Ekstrand 2021-07-20 18:13 ` [Intel-gfx] " Jason Ekstrand 2021-07-20 18:13 ` [PATCH 3/6] drm/i915: Use a table for i915_init/exit Jason Ekstrand 2021-07-20 18:13 ` [Intel-gfx] " Jason Ekstrand 2021-07-20 18:29 ` Daniel Vetter 2021-07-20 18:29 ` [Intel-gfx] " Daniel Vetter 2021-07-21 9:06 ` Tvrtko Ursulin 2021-07-21 9:06 ` Tvrtko Ursulin 2021-07-21 15:12 ` Jason Ekstrand 2021-07-21 15:12 ` Jason Ekstrand 2021-07-20 18:13 ` [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails Jason Ekstrand 2021-07-20 18:13 ` [Intel-gfx] " Jason Ekstrand 2021-07-21 6:35 ` Christian König 2021-07-21 6:35 ` [Intel-gfx] " Christian König 2021-07-21 9:06 ` Daniel Vetter 2021-07-21 9:06 ` Daniel Vetter 2021-07-21 9:08 ` Christian König 2021-07-21 9:08 ` Christian König 2021-07-21 9:12 ` Daniel Vetter [this message] 2021-07-21 9:12 ` Daniel Vetter 2021-07-20 18:13 ` [PATCH 5/6] drm/ttm: Initialize debugfs from ttm_global_init() Jason Ekstrand 2021-07-20 18:13 ` [Intel-gfx] " Jason Ekstrand 2021-07-20 18:13 ` [PATCH 6/6] drm/i915: Make the kmem slab for i915_buddy_block a global Jason Ekstrand 2021-07-20 18:13 ` [Intel-gfx] " Jason Ekstrand 2021-07-20 18:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix the debugfs splat from mock selftests (rev2) Patchwork 2021-07-20 18:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-07-20 18:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2021-07-20 18:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-07-20 20:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2021-07-21 15:23 [PATCH 0/6] Fix the debugfs splat from mock selftests (v3) Jason Ekstrand 2021-07-21 15:23 ` [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails Jason Ekstrand 2021-07-22 10:05 ` Daniel Vetter 2021-07-22 10:05 ` Daniel Vetter 2021-07-19 18:30 [PATCH 0/6] Fix the debugfs splat from mock selftests Jason Ekstrand 2021-07-19 18:30 ` [Intel-gfx] [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails Jason Ekstrand 2021-07-19 19:21 ` Christian König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKMK7uE1c=nhY9JNpLhky=ty4OXYfM3wcLi6EMhhVSH=otKagg@mail.gmail.com' \ --to=daniel@ffwll.ch \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jason@jlekstrand.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.