* [PATCH] drm/xen: adjust Kconfig
@ 2021-02-23 16:41 ` Jan Beulich
0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2021-02-23 16:41 UTC (permalink / raw)
To: oleksandr_andrushchenko; +Cc: xen-devel, dri-devel
By having selected DRM_XEN, I was assuming I would build the frontend
driver. As it turns out this is a dummy option, and I have really not
been building this (because I had DRM disabled). Make it a promptless
one, moving the "depends on" to the other, real option, and "select"ing
the dummy one.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/drivers/gpu/drm/xen/Kconfig
+++ b/drivers/gpu/drm/xen/Kconfig
@@ -1,15 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_XEN
- bool "DRM Support for Xen guest OS"
- depends on XEN
- help
- Choose this option if you want to enable DRM support
- for Xen.
+ bool
config DRM_XEN_FRONTEND
tristate "Para-virtualized frontend driver for Xen guest OS"
- depends on DRM_XEN
- depends on DRM
+ depends on XEN && DRM
+ select DRM_XEN
select DRM_KMS_HELPER
select VIDEOMODE_HELPERS
select XEN_XENBUS_FRONTEND
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/xen: adjust Kconfig
@ 2021-02-23 16:41 ` Jan Beulich
0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2021-02-23 16:41 UTC (permalink / raw)
To: oleksandr_andrushchenko; +Cc: xen-devel, dri-devel
By having selected DRM_XEN, I was assuming I would build the frontend
driver. As it turns out this is a dummy option, and I have really not
been building this (because I had DRM disabled). Make it a promptless
one, moving the "depends on" to the other, real option, and "select"ing
the dummy one.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/drivers/gpu/drm/xen/Kconfig
+++ b/drivers/gpu/drm/xen/Kconfig
@@ -1,15 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_XEN
- bool "DRM Support for Xen guest OS"
- depends on XEN
- help
- Choose this option if you want to enable DRM support
- for Xen.
+ bool
config DRM_XEN_FRONTEND
tristate "Para-virtualized frontend driver for Xen guest OS"
- depends on DRM_XEN
- depends on DRM
+ depends on XEN && DRM
+ select DRM_XEN
select DRM_KMS_HELPER
select VIDEOMODE_HELPERS
select XEN_XENBUS_FRONTEND
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/xen: adjust Kconfig
2021-02-23 16:41 ` Jan Beulich
@ 2021-02-24 6:48 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 8+ messages in thread
From: Oleksandr Andrushchenko @ 2021-02-24 6:48 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, dri-devel
Hello, Jan!
On 2/23/21 6:41 PM, Jan Beulich wrote:
> By having selected DRM_XEN, I was assuming I would build the frontend
> driver. As it turns out this is a dummy option, and I have really not
> been building this (because I had DRM disabled). Make it a promptless
> one, moving the "depends on" to the other, real option, and "select"ing
> the dummy one.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> --- a/drivers/gpu/drm/xen/Kconfig
> +++ b/drivers/gpu/drm/xen/Kconfig
> @@ -1,15 +1,11 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_XEN
> - bool "DRM Support for Xen guest OS"
> - depends on XEN
> - help
> - Choose this option if you want to enable DRM support
> - for Xen.
> + bool
>
> config DRM_XEN_FRONTEND
> tristate "Para-virtualized frontend driver for Xen guest OS"
> - depends on DRM_XEN
> - depends on DRM
> + depends on XEN && DRM
> + select DRM_XEN
> select DRM_KMS_HELPER
> select VIDEOMODE_HELPERS
> select XEN_XENBUS_FRONTEND
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/xen: adjust Kconfig
@ 2021-02-24 6:48 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 8+ messages in thread
From: Oleksandr Andrushchenko @ 2021-02-24 6:48 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, dri-devel
Hello, Jan!
On 2/23/21 6:41 PM, Jan Beulich wrote:
> By having selected DRM_XEN, I was assuming I would build the frontend
> driver. As it turns out this is a dummy option, and I have really not
> been building this (because I had DRM disabled). Make it a promptless
> one, moving the "depends on" to the other, real option, and "select"ing
> the dummy one.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> --- a/drivers/gpu/drm/xen/Kconfig
> +++ b/drivers/gpu/drm/xen/Kconfig
> @@ -1,15 +1,11 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_XEN
> - bool "DRM Support for Xen guest OS"
> - depends on XEN
> - help
> - Choose this option if you want to enable DRM support
> - for Xen.
> + bool
>
> config DRM_XEN_FRONTEND
> tristate "Para-virtualized frontend driver for Xen guest OS"
> - depends on DRM_XEN
> - depends on DRM
> + depends on XEN && DRM
> + select DRM_XEN
> select DRM_KMS_HELPER
> select VIDEOMODE_HELPERS
> select XEN_XENBUS_FRONTEND
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/xen: adjust Kconfig
2021-02-24 6:48 ` Oleksandr Andrushchenko
@ 2021-02-24 16:17 ` Daniel Vetter
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2021-02-24 16:17 UTC (permalink / raw)
To: Oleksandr Andrushchenko; +Cc: xen-devel, dri-devel, Jan Beulich
On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko
<Oleksandr_Andrushchenko@epam.com> wrote:
>
> Hello, Jan!
>
> On 2/23/21 6:41 PM, Jan Beulich wrote:
> > By having selected DRM_XEN, I was assuming I would build the frontend
> > driver. As it turns out this is a dummy option, and I have really not
> > been building this (because I had DRM disabled). Make it a promptless
> > one, moving the "depends on" to the other, real option, and "select"ing
> > the dummy one.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Since you're maintainer/committer, I'm assuming you'll also merge
this? Always confusing when there's an r-b but nothing about whether
the patch will get merged or not.
-Daniel
> > --- a/drivers/gpu/drm/xen/Kconfig
> > +++ b/drivers/gpu/drm/xen/Kconfig
> > @@ -1,15 +1,11 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > config DRM_XEN
> > - bool "DRM Support for Xen guest OS"
> > - depends on XEN
> > - help
> > - Choose this option if you want to enable DRM support
> > - for Xen.
> > + bool
> >
> > config DRM_XEN_FRONTEND
> > tristate "Para-virtualized frontend driver for Xen guest OS"
> > - depends on DRM_XEN
> > - depends on DRM
> > + depends on XEN && DRM
> > + select DRM_XEN
> > select DRM_KMS_HELPER
> > select VIDEOMODE_HELPERS
> > select XEN_XENBUS_FRONTEND
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/xen: adjust Kconfig
@ 2021-02-24 16:17 ` Daniel Vetter
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2021-02-24 16:17 UTC (permalink / raw)
To: Oleksandr Andrushchenko; +Cc: Jan Beulich, xen-devel, dri-devel
On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko
<Oleksandr_Andrushchenko@epam.com> wrote:
>
> Hello, Jan!
>
> On 2/23/21 6:41 PM, Jan Beulich wrote:
> > By having selected DRM_XEN, I was assuming I would build the frontend
> > driver. As it turns out this is a dummy option, and I have really not
> > been building this (because I had DRM disabled). Make it a promptless
> > one, moving the "depends on" to the other, real option, and "select"ing
> > the dummy one.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Since you're maintainer/committer, I'm assuming you'll also merge
this? Always confusing when there's an r-b but nothing about whether
the patch will get merged or not.
-Daniel
> > --- a/drivers/gpu/drm/xen/Kconfig
> > +++ b/drivers/gpu/drm/xen/Kconfig
> > @@ -1,15 +1,11 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > config DRM_XEN
> > - bool "DRM Support for Xen guest OS"
> > - depends on XEN
> > - help
> > - Choose this option if you want to enable DRM support
> > - for Xen.
> > + bool
> >
> > config DRM_XEN_FRONTEND
> > tristate "Para-virtualized frontend driver for Xen guest OS"
> > - depends on DRM_XEN
> > - depends on DRM
> > + depends on XEN && DRM
> > + select DRM_XEN
> > select DRM_KMS_HELPER
> > select VIDEOMODE_HELPERS
> > select XEN_XENBUS_FRONTEND
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/xen: adjust Kconfig
2021-02-24 16:17 ` Daniel Vetter
@ 2021-03-01 6:08 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 8+ messages in thread
From: Oleksandr Andrushchenko @ 2021-03-01 6:08 UTC (permalink / raw)
To: Daniel Vetter; +Cc: xen-devel, dri-devel, Jan Beulich
On 2/24/21 6:17 PM, Daniel Vetter wrote:
> On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko
> <Oleksandr_Andrushchenko@epam.com> wrote:
>> Hello, Jan!
>>
>> On 2/23/21 6:41 PM, Jan Beulich wrote:
>>> By having selected DRM_XEN, I was assuming I would build the frontend
>>> driver. As it turns out this is a dummy option, and I have really not
>>> been building this (because I had DRM disabled). Make it a promptless
>>> one, moving the "depends on" to the other, real option, and "select"ing
>>> the dummy one.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Since you're maintainer/committer, I'm assuming you'll also merge
> this? Always confusing when there's an r-b but nothing about whether
> the patch will get merged or not.
Applied to drm-misc-next,
thank you
> -Daniel
>
>>> --- a/drivers/gpu/drm/xen/Kconfig
>>> +++ b/drivers/gpu/drm/xen/Kconfig
>>> @@ -1,15 +1,11 @@
>>> # SPDX-License-Identifier: GPL-2.0-only
>>> config DRM_XEN
>>> - bool "DRM Support for Xen guest OS"
>>> - depends on XEN
>>> - help
>>> - Choose this option if you want to enable DRM support
>>> - for Xen.
>>> + bool
>>>
>>> config DRM_XEN_FRONTEND
>>> tristate "Para-virtualized frontend driver for Xen guest OS"
>>> - depends on DRM_XEN
>>> - depends on DRM
>>> + depends on XEN && DRM
>>> + select DRM_XEN
>>> select DRM_KMS_HELPER
>>> select VIDEOMODE_HELPERS
>>> select XEN_XENBUS_FRONTEND
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://urldefense.com/v3/__https://lists.freedesktop.org/mailman/listinfo/dri-devel__;!!GF_29dbcQIUBPA!l8ITnylvjn3TuANLahtryeLJhjH20i-9Oi_1tYkdA59vXUpBHtKnlQ-Kg-zURW_ruUkKKaUAZQ$ [lists[.]freedesktop[.]org]
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/xen: adjust Kconfig
@ 2021-03-01 6:08 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 8+ messages in thread
From: Oleksandr Andrushchenko @ 2021-03-01 6:08 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Jan Beulich, xen-devel, dri-devel
On 2/24/21 6:17 PM, Daniel Vetter wrote:
> On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko
> <Oleksandr_Andrushchenko@epam.com> wrote:
>> Hello, Jan!
>>
>> On 2/23/21 6:41 PM, Jan Beulich wrote:
>>> By having selected DRM_XEN, I was assuming I would build the frontend
>>> driver. As it turns out this is a dummy option, and I have really not
>>> been building this (because I had DRM disabled). Make it a promptless
>>> one, moving the "depends on" to the other, real option, and "select"ing
>>> the dummy one.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Since you're maintainer/committer, I'm assuming you'll also merge
> this? Always confusing when there's an r-b but nothing about whether
> the patch will get merged or not.
Applied to drm-misc-next,
thank you
> -Daniel
>
>>> --- a/drivers/gpu/drm/xen/Kconfig
>>> +++ b/drivers/gpu/drm/xen/Kconfig
>>> @@ -1,15 +1,11 @@
>>> # SPDX-License-Identifier: GPL-2.0-only
>>> config DRM_XEN
>>> - bool "DRM Support for Xen guest OS"
>>> - depends on XEN
>>> - help
>>> - Choose this option if you want to enable DRM support
>>> - for Xen.
>>> + bool
>>>
>>> config DRM_XEN_FRONTEND
>>> tristate "Para-virtualized frontend driver for Xen guest OS"
>>> - depends on DRM_XEN
>>> - depends on DRM
>>> + depends on XEN && DRM
>>> + select DRM_XEN
>>> select DRM_KMS_HELPER
>>> select VIDEOMODE_HELPERS
>>> select XEN_XENBUS_FRONTEND
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://urldefense.com/v3/__https://lists.freedesktop.org/mailman/listinfo/dri-devel__;!!GF_29dbcQIUBPA!l8ITnylvjn3TuANLahtryeLJhjH20i-9Oi_1tYkdA59vXUpBHtKnlQ-Kg-zURW_ruUkKKaUAZQ$ [lists[.]freedesktop[.]org]
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-01 6:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 16:41 [PATCH] drm/xen: adjust Kconfig Jan Beulich
2021-02-23 16:41 ` Jan Beulich
2021-02-24 6:48 ` Oleksandr Andrushchenko
2021-02-24 6:48 ` Oleksandr Andrushchenko
2021-02-24 16:17 ` Daniel Vetter
2021-02-24 16:17 ` Daniel Vetter
2021-03-01 6:08 ` Oleksandr Andrushchenko
2021-03-01 6:08 ` Oleksandr Andrushchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.