From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
sean@poorly.run, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
pony1.wu@gmail.com, Orson Zhai <orsonzhai@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
zou_wei@huawei.com, Chunyan Zhang <zhang.lyra@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig
Date: Tue, 11 Jan 2022 10:24:21 +0100 [thread overview]
Message-ID: <CAKXUXMyXYcdWOTMMdUxXMYvBKiRor4LMtK-JgACo+iA8ogvqmw@mail.gmail.com> (raw)
In-Reply-To: <20211224141213.27612-2-kevin3.tang@gmail.com>
On Fri, Dec 24, 2021 at 3:12 PM Kevin Tang <kevin3.tang@gmail.com> wrote:
>
> On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") adds the config DRM_SPRD,
> which selects DRM_KMS_CMA_HELPER.
>
That this commit is _currently_ on linux-next is just a matter of the
current state. The commit message that goes into the project's history
should probably not state "on linux-next";
this information is probably outdated or of no interest to any further
future reader at the time of reading.
So, just drop "On linux-next". The commit 43531edd53f0 ("drm/sprd: add
Unisoc's drm kms master") will exist until the end of time.
> However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") just removed the
> DRM_KMS_CMA_HELPER. So, the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol.
>
I would be happy about acknowledging my work of reporting with a
Reported-by tag, although I accidently send the report only to you
without cc-ing the mailing lists.
Please add:
Reported-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
That said you may also add a Reviewed-by tag now:
Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Lukas
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
> drivers/gpu/drm/sprd/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig
> index 3edeaeca0..9a9c7ebfc 100644
> --- a/drivers/gpu/drm/sprd/Kconfig
> +++ b/drivers/gpu/drm/sprd/Kconfig
> @@ -3,7 +3,6 @@ config DRM_SPRD
> depends on ARCH_SPRD || COMPILE_TEST
> depends on DRM && OF
> select DRM_GEM_CMA_HELPER
> - select DRM_KMS_CMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select VIDEOMODE_HELPERS
> --
> 2.29.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
pony1.wu@gmail.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org,
Chunyan Zhang <zhang.lyra@gmail.com>,
Orson Zhai <orsonzhai@gmail.com>,
zou_wei@huawei.com, sean@poorly.run,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig
Date: Tue, 11 Jan 2022 10:24:21 +0100 [thread overview]
Message-ID: <CAKXUXMyXYcdWOTMMdUxXMYvBKiRor4LMtK-JgACo+iA8ogvqmw@mail.gmail.com> (raw)
In-Reply-To: <20211224141213.27612-2-kevin3.tang@gmail.com>
On Fri, Dec 24, 2021 at 3:12 PM Kevin Tang <kevin3.tang@gmail.com> wrote:
>
> On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") adds the config DRM_SPRD,
> which selects DRM_KMS_CMA_HELPER.
>
That this commit is _currently_ on linux-next is just a matter of the
current state. The commit message that goes into the project's history
should probably not state "on linux-next";
this information is probably outdated or of no interest to any further
future reader at the time of reading.
So, just drop "On linux-next". The commit 43531edd53f0 ("drm/sprd: add
Unisoc's drm kms master") will exist until the end of time.
> However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") just removed the
> DRM_KMS_CMA_HELPER. So, the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol.
>
I would be happy about acknowledging my work of reporting with a
Reported-by tag, although I accidently send the report only to you
without cc-ing the mailing lists.
Please add:
Reported-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
That said you may also add a Reviewed-by tag now:
Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Lukas
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
> drivers/gpu/drm/sprd/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig
> index 3edeaeca0..9a9c7ebfc 100644
> --- a/drivers/gpu/drm/sprd/Kconfig
> +++ b/drivers/gpu/drm/sprd/Kconfig
> @@ -3,7 +3,6 @@ config DRM_SPRD
> depends on ARCH_SPRD || COMPILE_TEST
> depends on DRM && OF
> select DRM_GEM_CMA_HELPER
> - select DRM_KMS_CMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select VIDEOMODE_HELPERS
> --
> 2.29.0
>
next prev parent reply other threads:[~2022-01-11 9:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 14:12 [PATCH v1 0/2] sprd drm cover letter Kevin Tang
2021-12-24 14:12 ` Kevin Tang
2021-12-24 14:12 ` [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig Kevin Tang
2021-12-24 14:12 ` Kevin Tang
2022-01-11 9:11 ` Javier Martinez Canillas
2022-01-11 9:11 ` Javier Martinez Canillas
2022-01-11 9:20 ` Thomas Zimmermann
2022-01-11 9:20 ` Thomas Zimmermann
2022-01-11 9:24 ` Lukas Bulwahn [this message]
2022-01-11 9:24 ` Lukas Bulwahn
2021-12-24 14:12 ` [PATCH v1 2/2] drm/sprd: fix potential NULL dereference Kevin Tang
2021-12-24 14:12 ` Kevin Tang
2022-01-11 9:18 ` Javier Martinez Canillas
2022-01-11 9:18 ` Javier Martinez Canillas
2022-01-11 9:31 ` Thomas Zimmermann
2022-01-11 9:31 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXUXMyXYcdWOTMMdUxXMYvBKiRor4LMtK-JgACo+iA8ogvqmw@mail.gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=pony1.wu@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=zhang.lyra@gmail.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.