From: Axel Haslam <ahaslam@baylibre.com> To: David Lechner <david@lechnology.com> Cc: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>, robh+dt@kernel.org, Alexandre Bailon <abailon@baylibre.com>, Alan Stern <stern@rowland.harvard.edu>, Greg KH <gregkh@linuxfoundation.org>, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node Date: Mon, 21 Nov 2016 11:27:49 +0100 [thread overview] Message-ID: <CAKXjFTN_VvxJ+mk=ooUiGqZJnuJJJn33KsBF2n6SvZNjWpYm3Q@mail.gmail.com> (raw) In-Reply-To: <48d0c158-f7c8-0d1e-f06e-b7b28d6f2b93@lechnology.com> On Mon, Nov 21, 2016 at 3:42 AM, David Lechner <david@lechnology.com> wrote: > On 11/07/2016 02:39 PM, Axel Haslam wrote: >> >> This adds the ohci device node for the da850 soc. >> It also enables it for the omapl138 hawk board. >> >> Signed-off-by: Axel Haslam <ahaslam@baylibre.com> >> --- >> arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ >> arch/arm/boot/dts/da850.dtsi | 8 ++++++++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850-lcdk.dts >> b/arch/arm/boot/dts/da850-lcdk.dts >> index 7b8ab21..aaf533e 100644 >> --- a/arch/arm/boot/dts/da850-lcdk.dts >> +++ b/arch/arm/boot/dts/da850-lcdk.dts >> @@ -86,6 +86,14 @@ >> }; >> }; >> >> +&usb_phy { >> + status = "okay"; >> +}; >> + >> +&ohci { >> + status = "okay"; >> +}; >> + >> &serial2 { >> pinctrl-names = "default"; >> pinctrl-0 = <&serial2_rxtx_pins>; >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 2534aab..50e86da 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -405,6 +405,14 @@ >> >; >> status = "disabled"; >> }; >> + ohci: usb@0225000 { > > > In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci > tree, the alias for the musb device is usb0. So, I think we should use usb1 > here instead of ohci - or change the usb0 alias to musb. > > https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6 ok, i will change to usb1, since i will be resubmiting this. > >> + compatible = "ti,da830-ohci"; >> + reg = <0x225000 0x1000>; >> + interrupts = <59>; >> + phys = <&usb_phy 1>; >> + phy-names = "usb-phy"; >> + status = "disabled"; >> + }; >> gpio: gpio@226000 { >> compatible = "ti,dm6441-gpio"; >> gpio-controller; >> >
WARNING: multiple messages have this Message-ID (diff)
From: ahaslam@baylibre.com (Axel Haslam) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 10/10] ARM: dts: da850: add usb device node Date: Mon, 21 Nov 2016 11:27:49 +0100 [thread overview] Message-ID: <CAKXjFTN_VvxJ+mk=ooUiGqZJnuJJJn33KsBF2n6SvZNjWpYm3Q@mail.gmail.com> (raw) In-Reply-To: <48d0c158-f7c8-0d1e-f06e-b7b28d6f2b93@lechnology.com> On Mon, Nov 21, 2016 at 3:42 AM, David Lechner <david@lechnology.com> wrote: > On 11/07/2016 02:39 PM, Axel Haslam wrote: >> >> This adds the ohci device node for the da850 soc. >> It also enables it for the omapl138 hawk board. >> >> Signed-off-by: Axel Haslam <ahaslam@baylibre.com> >> --- >> arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ >> arch/arm/boot/dts/da850.dtsi | 8 ++++++++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850-lcdk.dts >> b/arch/arm/boot/dts/da850-lcdk.dts >> index 7b8ab21..aaf533e 100644 >> --- a/arch/arm/boot/dts/da850-lcdk.dts >> +++ b/arch/arm/boot/dts/da850-lcdk.dts >> @@ -86,6 +86,14 @@ >> }; >> }; >> >> +&usb_phy { >> + status = "okay"; >> +}; >> + >> +&ohci { >> + status = "okay"; >> +}; >> + >> &serial2 { >> pinctrl-names = "default"; >> pinctrl-0 = <&serial2_rxtx_pins>; >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 2534aab..50e86da 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -405,6 +405,14 @@ >> >; >> status = "disabled"; >> }; >> + ohci: usb at 0225000 { > > > In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci > tree, the alias for the musb device is usb0. So, I think we should use usb1 > here instead of ohci - or change the usb0 alias to musb. > > https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6 ok, i will change to usb1, since i will be resubmiting this. > >> + compatible = "ti,da830-ohci"; >> + reg = <0x225000 0x1000>; >> + interrupts = <59>; >> + phys = <&usb_phy 1>; >> + phy-names = "usb-phy"; >> + status = "disabled"; >> + }; >> gpio: gpio at 226000 { >> compatible = "ti,dm6441-gpio"; >> gpio-controller; >> >
next prev parent reply other threads:[~2016-11-21 10:28 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-07 20:39 [PATCH v3 00/10] Add DT support for ohci-da8xx Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 01/10] USB: ohci: da8xx: use ohci priv data instead of globals Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 02/10] USB: ohci: da8xx: Prepare to remove platform callbacks Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 03/10] USB: ohci: da8xx: Allow a regulator to handle VBUS Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 04/10] ARM: davinci: da830: Handle vbus with a regulator Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 05/10] ARM: davinci: hawk: Remove vbus and over current gpios Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 06/10] USB: ohci: da8xx: Remove ohci platform callbacks Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 07/10] USB: ohci: da8xx: use a flag instead of mask for ocic Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 08/10] USB: ohci: da8xx: Add devicetree bindings Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 09/10] USB: ohci: da8xx: Allow probing from DT Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-07 20:39 ` [PATCH v3 10/10] ARM: dts: da850: add usb device node Axel Haslam 2016-11-07 20:39 ` Axel Haslam 2016-11-21 2:42 ` David Lechner 2016-11-21 2:42 ` David Lechner 2016-11-21 2:42 ` David Lechner 2016-11-21 10:27 ` Axel Haslam [this message] 2016-11-21 10:27 ` Axel Haslam 2016-11-21 10:46 ` Sekhar Nori 2016-11-21 10:46 ` Sekhar Nori 2016-11-21 10:46 ` Sekhar Nori 2016-11-21 10:49 ` Sekhar Nori 2016-11-21 10:49 ` Sekhar Nori 2016-11-21 10:49 ` Sekhar Nori 2016-11-21 10:53 ` Axel Haslam 2016-11-21 10:53 ` Axel Haslam 2016-11-21 10:53 ` Axel Haslam 2016-11-08 16:37 ` [PATCH v3 00/10] Add DT support for ohci-da8xx Axel Haslam 2016-11-08 16:37 ` Axel Haslam 2016-11-10 12:02 ` Greg KH 2016-11-10 12:02 ` Greg KH 2016-11-10 17:28 ` Axel Haslam 2016-11-10 17:28 ` Axel Haslam 2016-11-10 17:28 ` Axel Haslam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKXjFTN_VvxJ+mk=ooUiGqZJnuJJJn33KsBF2n6SvZNjWpYm3Q@mail.gmail.com' \ --to=ahaslam@baylibre.com \ --cc=abailon@baylibre.com \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=nsekhar@ti.com \ --cc=robh+dt@kernel.org \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.