From: Alexander Duyck <alexander.duyck@gmail.com> To: Alex Shi <alex.shi@linux.alibaba.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@techsingularity.net>, Tejun Heo <tj@kernel.org>, Hugh Dickins <hughd@google.com>, Konstantin Khlebnikov <khlebnikov@yandex-team.ru>, Daniel Jordan <daniel.m.jordan@oracle.com>, Yang Shi <yang.shi@linux.alibaba.com>, Matthew Wilcox <willy@infradead.org>, Johannes Weiner <hannes@cmpxchg.org>, kbuild test robot <lkp@intel.com>, linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, cgroups@vger.kernel.org, Shakeel Butt <shakeelb@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Wei Yang <richard.weiyang@gmail.com>, "Kirill A. Shutemov" <kirill@shutemov.name>, Rong Chen <rong.a.chen@intel.com> Subject: Re: [PATCH v17 20/21] mm/pgdat: remove pgdat lru_lock Date: Mon, 3 Aug 2020 15:42:59 -0700 [thread overview] Message-ID: <CAKgT0UfZg5Wf2qNJ_=VPO1Cj8YuifZN8rG_X4Btq86ADmsVZFw@mail.gmail.com> (raw) In-Reply-To: <1595681998-19193-21-git-send-email-alex.shi@linux.alibaba.com> On Sat, Jul 25, 2020 at 6:00 AM Alex Shi <alex.shi@linux.alibaba.com> wrote: > > Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore. > > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> > Cc: Hugh Dickins <hughd@google.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org I really think this would be better just squashed into patch 18 instead of as a standalone patch since you were moving all of the locking anyway so it would be more likely to trigger build errors if somebody didn't move a lock somewhere that was referencing this. That said this change is harmless at this point. Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com> > --- > include/linux/mmzone.h | 1 - > mm/page_alloc.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 30b961a9a749..8af956aa13cf 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -735,7 +735,6 @@ struct deferred_split { > > /* Write-intensive fields used by page reclaim */ > ZONE_PADDING(_pad1_) > - spinlock_t lru_lock; > > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > /* > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e028b87ce294..4d7df42b32d6 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6721,7 +6721,6 @@ static void __meminit pgdat_init_internals(struct pglist_data *pgdat) > init_waitqueue_head(&pgdat->pfmemalloc_wait); > > pgdat_page_ext_init(pgdat); > - spin_lock_init(&pgdat->lru_lock); > lruvec_init(&pgdat->__lruvec); > } > > -- > 1.8.3.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Duyck <alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Mel Gorman <mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org>, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Konstantin Khlebnikov <khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org>, Daniel Jordan <daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>, Yang Shi <yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>, Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, linux-mm <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Joonsoo Kim <iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org>, Wei Yang <richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>, Rong Chen <rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Subject: Re: [PATCH v17 20/21] mm/pgdat: remove pgdat lru_lock Date: Mon, 3 Aug 2020 15:42:59 -0700 [thread overview] Message-ID: <CAKgT0UfZg5Wf2qNJ_=VPO1Cj8YuifZN8rG_X4Btq86ADmsVZFw@mail.gmail.com> (raw) In-Reply-To: <1595681998-19193-21-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> On Sat, Jul 25, 2020 at 6:00 AM Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> wrote: > > Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore. > > Signed-off-by: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> > Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> > Cc: Konstantin Khlebnikov <khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org> > Cc: Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> > Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> > Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org I really think this would be better just squashed into patch 18 instead of as a standalone patch since you were moving all of the locking anyway so it would be more likely to trigger build errors if somebody didn't move a lock somewhere that was referencing this. That said this change is harmless at this point. Reviewed-by: Alexander Duyck <alexander.h.duyck-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > --- > include/linux/mmzone.h | 1 - > mm/page_alloc.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 30b961a9a749..8af956aa13cf 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -735,7 +735,6 @@ struct deferred_split { > > /* Write-intensive fields used by page reclaim */ > ZONE_PADDING(_pad1_) > - spinlock_t lru_lock; > > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > /* > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e028b87ce294..4d7df42b32d6 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6721,7 +6721,6 @@ static void __meminit pgdat_init_internals(struct pglist_data *pgdat) > init_waitqueue_head(&pgdat->pfmemalloc_wait); > > pgdat_page_ext_init(pgdat); > - spin_lock_init(&pgdat->lru_lock); > lruvec_init(&pgdat->__lruvec); > } > > -- > 1.8.3.1 >
next prev parent reply other threads:[~2020-08-03 22:43 UTC|newest] Thread overview: 209+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-25 12:59 [PATCH v17 00/21] per memcg lru lock Alex Shi 2020-07-25 12:59 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 01/21] mm/vmscan: remove unnecessary lruvec adding Alex Shi 2020-08-06 3:47 ` Alex Shi 2020-08-06 3:47 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 02/21] mm/page_idle: no unlikely double check for idle page counting Alex Shi 2020-07-25 12:59 ` [PATCH v17 03/21] mm/compaction: correct the comments of compact_defer_shift Alex Shi 2020-07-27 17:29 ` Alexander Duyck 2020-07-27 17:29 ` Alexander Duyck 2020-07-28 11:59 ` Alex Shi 2020-07-28 11:59 ` Alex Shi 2020-07-28 14:17 ` Alexander Duyck 2020-07-28 14:17 ` Alexander Duyck 2020-07-28 14:17 ` Alexander Duyck 2020-07-25 12:59 ` [PATCH v17 04/21] mm/compaction: rename compact_deferred as compact_should_defer Alex Shi 2020-07-25 12:59 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 05/21] mm/thp: move lru_add_page_tail func to huge_memory.c Alex Shi 2020-07-25 12:59 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 06/21] mm/thp: clean up lru_add_page_tail Alex Shi 2020-07-25 12:59 ` [PATCH v17 07/21] mm/thp: remove code path which never got into Alex Shi 2020-07-25 12:59 ` [PATCH v17 08/21] mm/thp: narrow lru locking Alex Shi 2020-07-25 12:59 ` [PATCH v17 09/21] mm/memcg: add debug checking in lock_page_memcg Alex Shi 2020-07-25 12:59 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 10/21] mm/swap: fold vm event PGROTATED into pagevec_move_tail_fn Alex Shi 2020-07-25 12:59 ` [PATCH v17 11/21] mm/lru: move lru_lock holding in func lru_note_cost_page Alex Shi 2020-08-05 21:18 ` Alexander Duyck 2020-08-05 21:18 ` Alexander Duyck 2020-08-05 21:18 ` Alexander Duyck 2020-07-25 12:59 ` [PATCH v17 12/21] mm/lru: move lock into lru_note_cost Alex Shi 2020-07-25 12:59 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 13/21] mm/lru: introduce TestClearPageLRU Alex Shi 2020-07-25 12:59 ` Alex Shi 2020-07-29 3:53 ` Alex Shi 2020-07-29 3:53 ` Alex Shi 2020-08-05 22:43 ` Alexander Duyck 2020-08-05 22:43 ` Alexander Duyck 2020-08-06 1:54 ` Alex Shi 2020-08-06 1:54 ` Alex Shi 2020-08-06 14:41 ` Alexander Duyck 2020-08-06 14:41 ` Alexander Duyck 2020-07-25 12:59 ` [PATCH v17 14/21] mm/compaction: do page isolation first in compaction Alex Shi 2020-08-04 21:35 ` Alexander Duyck 2020-08-04 21:35 ` Alexander Duyck 2020-08-04 21:35 ` Alexander Duyck 2020-08-06 18:38 ` Alexander Duyck 2020-08-06 18:38 ` Alexander Duyck 2020-08-06 18:38 ` Alexander Duyck 2020-08-07 3:24 ` Alex Shi 2020-08-07 3:24 ` Alex Shi 2020-08-07 14:51 ` Alexander Duyck 2020-08-07 14:51 ` Alexander Duyck 2020-08-07 14:51 ` Alexander Duyck 2020-08-10 13:10 ` Alex Shi 2020-08-10 13:10 ` Alex Shi 2020-08-10 14:41 ` Alexander Duyck 2020-08-10 14:41 ` Alexander Duyck 2020-08-10 14:41 ` Alexander Duyck 2020-08-11 8:22 ` Alex Shi 2020-08-11 14:47 ` Alexander Duyck 2020-08-11 14:47 ` Alexander Duyck 2020-08-11 14:47 ` Alexander Duyck 2020-08-12 11:43 ` Alex Shi 2020-08-12 12:16 ` Alex Shi 2020-08-12 12:16 ` Alex Shi 2020-08-12 16:51 ` Alexander Duyck 2020-08-12 16:51 ` Alexander Duyck 2020-08-12 16:51 ` Alexander Duyck 2020-08-13 1:46 ` Alex Shi 2020-08-13 2:17 ` Alexander Duyck 2020-08-13 2:17 ` Alexander Duyck 2020-08-13 2:17 ` Alexander Duyck 2020-08-13 3:52 ` Alex Shi 2020-08-13 3:52 ` Alex Shi 2020-08-13 4:02 ` [RFC PATCH 0/3] " Alexander Duyck 2020-08-13 4:02 ` Alexander Duyck 2020-08-13 4:02 ` [RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block Alexander Duyck 2020-08-13 4:02 ` Alexander Duyck 2020-08-13 6:56 ` Alex Shi 2020-08-13 6:56 ` Alex Shi 2020-08-13 14:32 ` Alexander Duyck 2020-08-13 14:32 ` Alexander Duyck 2020-08-13 14:32 ` Alexander Duyck 2020-08-14 7:25 ` Alex Shi 2020-08-14 7:25 ` Alex Shi 2020-08-13 7:44 ` Alex Shi 2020-08-13 7:44 ` Alex Shi 2020-08-13 14:26 ` Alexander Duyck 2020-08-13 14:26 ` Alexander Duyck 2020-08-13 4:02 ` [RFC PATCH 2/3] mm: Drop use of test_and_set_skip in favor of just setting skip Alexander Duyck 2020-08-13 4:02 ` Alexander Duyck 2020-08-14 7:19 ` Alex Shi 2020-08-14 7:19 ` Alex Shi 2020-08-14 14:24 ` Alexander Duyck 2020-08-14 14:24 ` Alexander Duyck 2020-08-14 14:24 ` Alexander Duyck 2020-08-14 21:15 ` Alexander Duyck 2020-08-14 21:15 ` Alexander Duyck 2020-08-14 21:15 ` Alexander Duyck 2020-08-15 9:49 ` Alex Shi 2020-08-17 15:38 ` Alexander Duyck 2020-08-17 15:38 ` Alexander Duyck 2020-08-17 15:38 ` Alexander Duyck 2020-08-18 6:50 ` Alex Shi 2020-08-18 6:50 ` Alex Shi 2020-08-13 4:02 ` [RFC PATCH 3/3] mm: Identify compound pages sooner in isolate_migratepages_block Alexander Duyck 2020-08-13 4:02 ` Alexander Duyck 2020-08-14 7:20 ` Alex Shi 2020-08-14 7:20 ` Alex Shi 2020-08-17 22:58 ` [PATCH v17 14/21] mm/compaction: do page isolation first in compaction Alexander Duyck 2020-08-17 22:58 ` Alexander Duyck 2020-08-17 22:58 ` Alexander Duyck 2020-07-25 12:59 ` [PATCH v17 15/21] mm/thp: add tail pages into lru anyway in split_huge_page() Alex Shi 2020-07-25 12:59 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 16/21] mm/swap: serialize memcg changes in pagevec_lru_move_fn Alex Shi 2020-07-25 12:59 ` [PATCH v17 17/21] mm/lru: replace pgdat lru_lock with lruvec lock Alex Shi 2020-07-25 12:59 ` Alex Shi 2020-07-27 23:34 ` Alexander Duyck 2020-07-27 23:34 ` Alexander Duyck 2020-07-27 23:34 ` Alexander Duyck 2020-07-28 7:15 ` Alex Shi 2020-07-28 7:15 ` Alex Shi 2020-07-28 11:19 ` Alex Shi 2020-07-28 11:19 ` Alex Shi 2020-07-28 14:54 ` Alexander Duyck 2020-07-28 14:54 ` Alexander Duyck 2020-07-28 14:54 ` Alexander Duyck 2020-07-29 1:00 ` Alex Shi 2020-07-29 1:27 ` Alexander Duyck 2020-07-29 1:27 ` Alexander Duyck 2020-07-29 1:27 ` Alexander Duyck 2020-07-29 2:27 ` Alex Shi 2020-07-29 2:27 ` Alex Shi 2020-07-28 15:39 ` Alex Shi 2020-07-28 15:39 ` Alex Shi 2020-07-28 15:55 ` Alexander Duyck 2020-07-28 15:55 ` Alexander Duyck 2020-07-28 15:55 ` Alexander Duyck 2020-07-29 0:48 ` Alex Shi 2020-07-29 3:54 ` Alex Shi 2020-08-06 7:41 ` Alex Shi 2020-08-06 7:41 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 18/21] mm/lru: introduce the relock_page_lruvec function Alex Shi 2020-07-29 17:52 ` Alexander Duyck 2020-07-29 17:52 ` Alexander Duyck 2020-07-29 17:52 ` Alexander Duyck 2020-07-30 6:08 ` Alex Shi 2020-07-30 6:08 ` Alex Shi 2020-07-31 14:20 ` Alexander Duyck 2020-07-31 14:20 ` Alexander Duyck 2020-07-31 14:20 ` Alexander Duyck 2020-07-31 21:14 ` [PATCH RFC] mm: Add function for testing if the current lruvec lock is valid alexander.h.duyck 2020-07-31 21:14 ` alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w 2020-07-31 23:54 ` Alex Shi 2020-07-31 23:54 ` Alex Shi 2020-08-02 18:20 ` Alexander Duyck 2020-08-02 18:20 ` Alexander Duyck 2020-08-02 18:20 ` Alexander Duyck 2020-08-04 6:13 ` Alex Shi 2020-08-04 6:13 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 19/21] mm/vmscan: use relock for move_pages_to_lru Alex Shi 2020-08-03 22:49 ` Alexander Duyck 2020-08-03 22:49 ` Alexander Duyck 2020-08-04 6:23 ` Alex Shi 2020-08-04 6:23 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 20/21] mm/pgdat: remove pgdat lru_lock Alex Shi 2020-08-03 22:42 ` Alexander Duyck [this message] 2020-08-03 22:42 ` Alexander Duyck 2020-08-03 22:42 ` Alexander Duyck 2020-08-03 22:45 ` Alexander Duyck 2020-08-03 22:45 ` Alexander Duyck 2020-08-03 22:45 ` Alexander Duyck 2020-08-04 6:22 ` Alex Shi 2020-08-04 6:22 ` Alex Shi 2020-07-25 12:59 ` [PATCH v17 21/21] mm/lru: revise the comments of lru_lock Alex Shi 2020-08-03 22:37 ` Alexander Duyck 2020-08-03 22:37 ` Alexander Duyck 2020-08-04 10:04 ` Alex Shi 2020-08-04 10:04 ` Alex Shi 2020-08-04 14:29 ` Alexander Duyck 2020-08-04 14:29 ` Alexander Duyck 2020-08-04 14:29 ` Alexander Duyck 2020-08-06 1:39 ` Alex Shi 2020-08-06 1:39 ` Alex Shi 2020-08-06 16:27 ` Alexander Duyck 2020-08-06 16:27 ` Alexander Duyck 2020-08-06 16:27 ` Alexander Duyck 2020-07-27 5:40 ` [PATCH v17 00/21] per memcg lru lock Alex Shi 2020-07-27 5:40 ` Alex Shi 2020-07-29 14:49 ` Alex Shi 2020-07-29 14:49 ` Alex Shi 2020-07-29 18:06 ` Hugh Dickins 2020-07-29 18:06 ` Hugh Dickins 2020-07-30 2:16 ` Alex Shi 2020-07-30 2:16 ` Alex Shi 2020-08-03 15:07 ` Michal Hocko 2020-08-03 15:07 ` Michal Hocko 2020-08-04 6:14 ` Alex Shi 2020-08-04 6:14 ` Alex Shi 2020-07-31 21:31 ` Alexander Duyck 2020-07-31 21:31 ` Alexander Duyck 2020-07-31 21:31 ` Alexander Duyck 2020-08-04 8:36 ` Alex Shi 2020-08-04 8:36 ` Alex Shi 2020-08-04 8:36 ` Alex Shi 2020-08-04 8:36 ` Alex Shi 2020-08-04 8:37 ` Alex Shi 2020-08-04 8:37 ` Alex Shi 2020-08-04 8:37 ` Alex Shi 2020-08-04 8:37 ` Alex Shi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKgT0UfZg5Wf2qNJ_=VPO1Cj8YuifZN8rG_X4Btq86ADmsVZFw@mail.gmail.com' \ --to=alexander.duyck@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=alex.shi@linux.alibaba.com \ --cc=cgroups@vger.kernel.org \ --cc=daniel.m.jordan@oracle.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=khlebnikov@yandex-team.ru \ --cc=kirill@shutemov.name \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lkp@intel.com \ --cc=mgorman@techsingularity.net \ --cc=richard.weiyang@gmail.com \ --cc=rong.a.chen@intel.com \ --cc=shakeelb@google.com \ --cc=tj@kernel.org \ --cc=willy@infradead.org \ --cc=yang.shi@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.