From: Alistair Francis <alistair23@gmail.com> To: Maxime Ripard <mripard@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org>, Alistair Francis <alistair@alistair23.me>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3 Date: Tue, 5 Nov 2019 11:27:42 -0800 [thread overview] Message-ID: <CAKmqyKN8Ru19h3y=9O13=5wpys3BC2LQM65S+2QYjPdJQn2O4w@mail.gmail.com> (raw) In-Reply-To: <20191021111709.dpu6g7jltuw6cbbn@gilmour> On Mon, Oct 21, 2019 at 4:17 AM Maxime Ripard <mripard@kernel.org> wrote: > > Hi, > > On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote: > > On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote: > > > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote: > > > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial > > > > connections. > > > > > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > > > > --- > > > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++ > > > > 1 file changed, 25 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > > > index 124b0b030b28..49c37b21ab36 100644 > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > > > @@ -56,6 +56,10 @@ > > > > aliases { > > > > ethernet0 = &emac; > > > > serial0 = &uart0; > > > > + serial1 = &uart1; > > > > + serial2 = &uart2; > > > > + serial3 = &uart3; > > > > + serial4 = &uart4; > > > > }; > > > > > > > > chosen { > > > > @@ -280,6 +284,27 @@ > > > > }; > > > > }; > > > > > > > > +/* On Pi-2 connector */ > > > > +&uart2 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&uart2_pins>; > > > > + status = "disabled"; > > > > +}; > > > > + > > > > +/* On Euler connector */ > > > > +&uart3 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&uart3_pins>; > > > > + status = "disabled"; > > > > +}; > > > > + > > > > +/* On Euler connector, RTS/CTS optional */ > > > > +&uart4 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&uart4_pins>; > > > > + status = "disabled"; > > > > +}; > > > > > > Since these are all the default muxing, maybe we should just set that > > > in the DTSI? > > > > Maybe not, since people may want to only use RX/TX, and leave the other > > two pins for GPIO? > > Right, I'll apply that patch. Ping, just want to make sure this has been applied/will be applied. Alistair > > Thanks! > Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com> To: Maxime Ripard <mripard@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org>, Alistair Francis <alistair@alistair23.me>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3 Date: Tue, 5 Nov 2019 11:27:42 -0800 [thread overview] Message-ID: <CAKmqyKN8Ru19h3y=9O13=5wpys3BC2LQM65S+2QYjPdJQn2O4w@mail.gmail.com> (raw) In-Reply-To: <20191021111709.dpu6g7jltuw6cbbn@gilmour> On Mon, Oct 21, 2019 at 4:17 AM Maxime Ripard <mripard@kernel.org> wrote: > > Hi, > > On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote: > > On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote: > > > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote: > > > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial > > > > connections. > > > > > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > > > > --- > > > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++ > > > > 1 file changed, 25 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > > > index 124b0b030b28..49c37b21ab36 100644 > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > > > @@ -56,6 +56,10 @@ > > > > aliases { > > > > ethernet0 = &emac; > > > > serial0 = &uart0; > > > > + serial1 = &uart1; > > > > + serial2 = &uart2; > > > > + serial3 = &uart3; > > > > + serial4 = &uart4; > > > > }; > > > > > > > > chosen { > > > > @@ -280,6 +284,27 @@ > > > > }; > > > > }; > > > > > > > > +/* On Pi-2 connector */ > > > > +&uart2 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&uart2_pins>; > > > > + status = "disabled"; > > > > +}; > > > > + > > > > +/* On Euler connector */ > > > > +&uart3 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&uart3_pins>; > > > > + status = "disabled"; > > > > +}; > > > > + > > > > +/* On Euler connector, RTS/CTS optional */ > > > > +&uart4 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&uart4_pins>; > > > > + status = "disabled"; > > > > +}; > > > > > > Since these are all the default muxing, maybe we should just set that > > > in the DTSI? > > > > Maybe not, since people may want to only use RX/TX, and leave the other > > two pins for GPIO? > > Right, I'll apply that patch. Ping, just want to make sure this has been applied/will be applied. Alistair > > Thanks! > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-05 19:33 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-12 20:05 [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3 Alistair Francis 2019-10-12 20:05 ` Alistair Francis 2019-10-16 14:49 ` Maxime Ripard 2019-10-16 14:49 ` Maxime Ripard 2019-10-16 14:54 ` Chen-Yu Tsai 2019-10-16 14:54 ` Chen-Yu Tsai 2019-10-16 16:10 ` Alistair Francis 2019-10-16 16:10 ` Alistair Francis 2019-10-21 11:17 ` Maxime Ripard 2019-10-21 11:17 ` Maxime Ripard 2019-11-05 19:27 ` Alistair Francis [this message] 2019-11-05 19:27 ` Alistair Francis 2019-11-06 11:52 ` Maxime Ripard 2019-11-06 11:52 ` Maxime Ripard 2019-11-06 21:45 ` Alistair Francis 2019-11-06 21:45 ` Alistair Francis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKmqyKN8Ru19h3y=9O13=5wpys3BC2LQM65S+2QYjPdJQn2O4w@mail.gmail.com' \ --to=alistair23@gmail.com \ --cc=alistair@alistair23.me \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mripard@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.