From: Alistair Francis <alistair23@gmail.com> To: Bin Meng <bmeng.cn@gmail.com> Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>, Bin Meng <bin.meng@windriver.com>, Alistair Francis <Alistair.Francis@wdc.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org> Subject: Re: [PATCH 4/8] hw/riscv: Support the official PLIC DT bindings Date: Wed, 31 Mar 2021 11:43:17 -0400 [thread overview] Message-ID: <CAKmqyKNZ3gGA1Zj2dTyemFvX52Sk_rjPviX+h5nd1ouVKjRrXw@mail.gmail.com> (raw) In-Reply-To: <20210329170818.23139-4-bmeng.cn@gmail.com> On Mon, Mar 29, 2021 at 1:12 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > The official DT bindings of PLIC uses "sifive,plic-1.0.0" as the > compatible string in the upstream Linux kernel. "riscv,plic0" is > now legacy and has to be kept for backward compatibility of legacy > systems. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > hw/riscv/sifive_u.c | 4 +++- > hw/riscv/virt.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c > index 7f696ebc12..651a439528 100644 > --- a/hw/riscv/sifive_u.c > +++ b/hw/riscv/sifive_u.c > @@ -98,6 +98,7 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap, > char *nodename; > const char *ethclk_names[2] = { "pclk", "hclk" }; > const char *clint_compat[2] = { "sifive,clint0", "riscv,clint0" }; > + const char *plic_compat[2] = { "sifive,plic-1.0.0", "riscv,plic0" }; > uint32_t plic_phandle, prci_phandle, gpio_phandle, phandle = 1; > uint32_t hfclk_phandle, rtcclk_phandle, phy_phandle; > > @@ -269,7 +270,8 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap, > (long)memmap[SIFIVE_U_DEV_PLIC].base); > qemu_fdt_add_subnode(fdt, nodename); > qemu_fdt_setprop_cell(fdt, nodename, "#interrupt-cells", 1); > - qemu_fdt_setprop_string(fdt, nodename, "compatible", "riscv,plic0"); > + qemu_fdt_setprop_string_array(fdt, nodename, "compatible", > + (char **)&plic_compat, ARRAY_SIZE(plic_compat)); > qemu_fdt_setprop(fdt, nodename, "interrupt-controller", NULL, 0); > qemu_fdt_setprop(fdt, nodename, "interrupts-extended", > cells, (ms->smp.cpus * 4 - 2) * sizeof(uint32_t)); > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index 5b4fac015d..d04733d97c 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -194,6 +194,7 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap, > char *mem_name, *cpu_name, *core_name, *intc_name; > char *name, *clint_name, *plic_name, *clust_name; > const char *clint_compat[2] = { "sifive,clint0", "riscv,clint0" }; > + const char *plic_compat[2] = { "sifive,plic-1.0.0", "riscv,plic0" }; > hwaddr flashsize = virt_memmap[VIRT_FLASH].size / 2; > hwaddr flashbase = virt_memmap[VIRT_FLASH].base; > > @@ -318,7 +319,8 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap, > "#address-cells", FDT_PLIC_ADDR_CELLS); > qemu_fdt_setprop_cell(fdt, plic_name, > "#interrupt-cells", FDT_PLIC_INT_CELLS); > - qemu_fdt_setprop_string(fdt, plic_name, "compatible", "riscv,plic0"); > + qemu_fdt_setprop_string_array(fdt, plic_name, "compatible", > + (char **)&plic_compat, ARRAY_SIZE(plic_compat)); > qemu_fdt_setprop(fdt, plic_name, "interrupt-controller", NULL, 0); > qemu_fdt_setprop(fdt, plic_name, "interrupts-extended", > plic_cells, s->soc[socket].num_harts * sizeof(uint32_t) * 4); > -- > 2.25.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com> To: Bin Meng <bmeng.cn@gmail.com> Cc: Alistair Francis <Alistair.Francis@wdc.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "open list:RISC-V" <qemu-riscv@nongnu.org>, Bin Meng <bin.meng@windriver.com> Subject: Re: [PATCH 4/8] hw/riscv: Support the official PLIC DT bindings Date: Wed, 31 Mar 2021 11:43:17 -0400 [thread overview] Message-ID: <CAKmqyKNZ3gGA1Zj2dTyemFvX52Sk_rjPviX+h5nd1ouVKjRrXw@mail.gmail.com> (raw) In-Reply-To: <20210329170818.23139-4-bmeng.cn@gmail.com> On Mon, Mar 29, 2021 at 1:12 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > The official DT bindings of PLIC uses "sifive,plic-1.0.0" as the > compatible string in the upstream Linux kernel. "riscv,plic0" is > now legacy and has to be kept for backward compatibility of legacy > systems. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > hw/riscv/sifive_u.c | 4 +++- > hw/riscv/virt.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c > index 7f696ebc12..651a439528 100644 > --- a/hw/riscv/sifive_u.c > +++ b/hw/riscv/sifive_u.c > @@ -98,6 +98,7 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap, > char *nodename; > const char *ethclk_names[2] = { "pclk", "hclk" }; > const char *clint_compat[2] = { "sifive,clint0", "riscv,clint0" }; > + const char *plic_compat[2] = { "sifive,plic-1.0.0", "riscv,plic0" }; > uint32_t plic_phandle, prci_phandle, gpio_phandle, phandle = 1; > uint32_t hfclk_phandle, rtcclk_phandle, phy_phandle; > > @@ -269,7 +270,8 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap, > (long)memmap[SIFIVE_U_DEV_PLIC].base); > qemu_fdt_add_subnode(fdt, nodename); > qemu_fdt_setprop_cell(fdt, nodename, "#interrupt-cells", 1); > - qemu_fdt_setprop_string(fdt, nodename, "compatible", "riscv,plic0"); > + qemu_fdt_setprop_string_array(fdt, nodename, "compatible", > + (char **)&plic_compat, ARRAY_SIZE(plic_compat)); > qemu_fdt_setprop(fdt, nodename, "interrupt-controller", NULL, 0); > qemu_fdt_setprop(fdt, nodename, "interrupts-extended", > cells, (ms->smp.cpus * 4 - 2) * sizeof(uint32_t)); > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index 5b4fac015d..d04733d97c 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -194,6 +194,7 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap, > char *mem_name, *cpu_name, *core_name, *intc_name; > char *name, *clint_name, *plic_name, *clust_name; > const char *clint_compat[2] = { "sifive,clint0", "riscv,clint0" }; > + const char *plic_compat[2] = { "sifive,plic-1.0.0", "riscv,plic0" }; > hwaddr flashsize = virt_memmap[VIRT_FLASH].size / 2; > hwaddr flashbase = virt_memmap[VIRT_FLASH].base; > > @@ -318,7 +319,8 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap, > "#address-cells", FDT_PLIC_ADDR_CELLS); > qemu_fdt_setprop_cell(fdt, plic_name, > "#interrupt-cells", FDT_PLIC_INT_CELLS); > - qemu_fdt_setprop_string(fdt, plic_name, "compatible", "riscv,plic0"); > + qemu_fdt_setprop_string_array(fdt, plic_name, "compatible", > + (char **)&plic_compat, ARRAY_SIZE(plic_compat)); > qemu_fdt_setprop(fdt, plic_name, "interrupt-controller", NULL, 0); > qemu_fdt_setprop(fdt, plic_name, "interrupts-extended", > plic_cells, s->soc[socket].num_harts * sizeof(uint32_t) * 4); > -- > 2.25.1 > >
next prev parent reply other threads:[~2021-03-31 15:49 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-29 17:08 [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper Bin Meng 2021-03-29 17:08 ` [PATCH 2/8] hw/riscv: virt: " Bin Meng 2021-03-31 15:41 ` Alistair Francis 2021-03-31 15:41 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 3/8] hw/riscv: Support the official CLINT DT bindings Bin Meng 2021-03-31 15:42 ` Alistair Francis 2021-03-31 15:42 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 4/8] hw/riscv: Support the official PLIC " Bin Meng 2021-03-31 15:43 ` Alistair Francis [this message] 2021-03-31 15:43 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 5/8] docs/system/riscv: Correct the indentation level of supported devices Bin Meng 2021-03-31 15:44 ` Alistair Francis 2021-03-31 15:44 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 6/8] docs/system/riscv: sifive_u: Document '-dtb' usage Bin Meng 2021-03-31 15:46 ` Alistair Francis 2021-03-31 15:46 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 7/8] hw/riscv: Use macros for BIOS image names Bin Meng 2021-03-31 15:44 ` Alistair Francis 2021-03-31 15:44 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 8/8] hw/riscv: microchip_pfsoc: Support direct kernel boot Bin Meng 2021-03-31 15:50 ` Alistair Francis 2021-03-31 15:50 ` Alistair Francis 2021-03-31 15:40 ` [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper Alistair Francis 2021-03-31 15:40 ` Alistair Francis 2021-03-31 16:07 ` Richard Henderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKmqyKNZ3gGA1Zj2dTyemFvX52Sk_rjPviX+h5nd1ouVKjRrXw@mail.gmail.com \ --to=alistair23@gmail.com \ --cc=Alistair.Francis@wdc.com \ --cc=bin.meng@windriver.com \ --cc=bmeng.cn@gmail.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.