From: Alistair Francis <alistair23@gmail.com> To: Bin Meng <bmeng.cn@gmail.com> Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>, Bin Meng <bin.meng@windriver.com>, Alistair Francis <Alistair.Francis@wdc.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org> Subject: Re: [PATCH 2/8] hw/riscv: virt: Switch to use qemu_fdt_setprop_string_array() helper Date: Wed, 31 Mar 2021 11:41:50 -0400 [thread overview] Message-ID: <CAKmqyKO-PEXM1D=WCT8=zq+cp9A_k0-Lrp7_oCKwg22iMQz3Pg@mail.gmail.com> (raw) In-Reply-To: <20210329170818.23139-2-bmeng.cn@gmail.com> On Mon, Mar 29, 2021 at 1:17 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array helper"), > we can use the new helper to set the compatible strings for the > SiFive test device node. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > hw/riscv/virt.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index c0dc69ff33..5d0c1e5903 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -395,8 +395,9 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap, > (long)memmap[VIRT_TEST].base); > qemu_fdt_add_subnode(fdt, name); > { > - const char compat[] = "sifive,test1\0sifive,test0\0syscon"; > - qemu_fdt_setprop(fdt, name, "compatible", compat, sizeof(compat)); > + const char *compat[3] = { "sifive,test1", "sifive,test0", "syscon" }; > + qemu_fdt_setprop_string_array(fdt, name, "compatible", (char **)&compat, > + ARRAY_SIZE(compat)); > } > qemu_fdt_setprop_cells(fdt, name, "reg", > 0x0, memmap[VIRT_TEST].base, > -- > 2.25.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com> To: Bin Meng <bmeng.cn@gmail.com> Cc: Alistair Francis <Alistair.Francis@wdc.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "open list:RISC-V" <qemu-riscv@nongnu.org>, Bin Meng <bin.meng@windriver.com> Subject: Re: [PATCH 2/8] hw/riscv: virt: Switch to use qemu_fdt_setprop_string_array() helper Date: Wed, 31 Mar 2021 11:41:50 -0400 [thread overview] Message-ID: <CAKmqyKO-PEXM1D=WCT8=zq+cp9A_k0-Lrp7_oCKwg22iMQz3Pg@mail.gmail.com> (raw) In-Reply-To: <20210329170818.23139-2-bmeng.cn@gmail.com> On Mon, Mar 29, 2021 at 1:17 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array helper"), > we can use the new helper to set the compatible strings for the > SiFive test device node. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > hw/riscv/virt.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index c0dc69ff33..5d0c1e5903 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -395,8 +395,9 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap, > (long)memmap[VIRT_TEST].base); > qemu_fdt_add_subnode(fdt, name); > { > - const char compat[] = "sifive,test1\0sifive,test0\0syscon"; > - qemu_fdt_setprop(fdt, name, "compatible", compat, sizeof(compat)); > + const char *compat[3] = { "sifive,test1", "sifive,test0", "syscon" }; > + qemu_fdt_setprop_string_array(fdt, name, "compatible", (char **)&compat, > + ARRAY_SIZE(compat)); > } > qemu_fdt_setprop_cells(fdt, name, "reg", > 0x0, memmap[VIRT_TEST].base, > -- > 2.25.1 > >
next prev parent reply other threads:[~2021-03-31 15:48 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-29 17:08 [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper Bin Meng 2021-03-29 17:08 ` [PATCH 2/8] hw/riscv: virt: " Bin Meng 2021-03-31 15:41 ` Alistair Francis [this message] 2021-03-31 15:41 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 3/8] hw/riscv: Support the official CLINT DT bindings Bin Meng 2021-03-31 15:42 ` Alistair Francis 2021-03-31 15:42 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 4/8] hw/riscv: Support the official PLIC " Bin Meng 2021-03-31 15:43 ` Alistair Francis 2021-03-31 15:43 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 5/8] docs/system/riscv: Correct the indentation level of supported devices Bin Meng 2021-03-31 15:44 ` Alistair Francis 2021-03-31 15:44 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 6/8] docs/system/riscv: sifive_u: Document '-dtb' usage Bin Meng 2021-03-31 15:46 ` Alistair Francis 2021-03-31 15:46 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 7/8] hw/riscv: Use macros for BIOS image names Bin Meng 2021-03-31 15:44 ` Alistair Francis 2021-03-31 15:44 ` Alistair Francis 2021-03-29 17:08 ` [PATCH 8/8] hw/riscv: microchip_pfsoc: Support direct kernel boot Bin Meng 2021-03-31 15:50 ` Alistair Francis 2021-03-31 15:50 ` Alistair Francis 2021-03-31 15:40 ` [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper Alistair Francis 2021-03-31 15:40 ` Alistair Francis 2021-03-31 16:07 ` Richard Henderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKmqyKO-PEXM1D=WCT8=zq+cp9A_k0-Lrp7_oCKwg22iMQz3Pg@mail.gmail.com' \ --to=alistair23@gmail.com \ --cc=Alistair.Francis@wdc.com \ --cc=bin.meng@windriver.com \ --cc=bmeng.cn@gmail.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.