From: Alistair Francis <alistair23@gmail.com> To: Philipp Tomsich <philipp.tomsich@vrull.eu> Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>, Bin Meng <bin.meng@windriver.com>, Vineet Gupta <vineetg@rivosinc.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@wdc.com>, Palmer Dabbelt <palmer@dabbelt.com> Subject: Re: [PATCH] target/riscv: Fix position of 'experimental' comment Date: Fri, 7 Jan 2022 07:30:15 +1000 [thread overview] Message-ID: <CAKmqyKPcYRPsvLvCUs-kL6f+4YJPZBgcL02Eoegrmv=HLiAUrg@mail.gmail.com> (raw) In-Reply-To: <20220106134020.1628889-1-philipp.tomsich@vrull.eu> On Fri, Jan 7, 2022 at 12:30 AM Philipp Tomsich <philipp.tomsich@vrull.eu> wrote: > > When commit 0643c12e4b dropped the 'x-' prefix for Zb[abcs] and set > them to be enabled by default, the comment about experimental > extensions was kept in place above them. This moves it down a few > lines to only cover experimental extensions. > > References: 0643c12e4b ("target/riscv: Enable bitmanip Zb[abcs] instructions") > > Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > > --- > > target/riscv/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 6ef3314bce..e322e729d2 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -640,11 +640,12 @@ static Property riscv_cpu_properties[] = { > DEFINE_PROP_UINT16("vlen", RISCVCPU, cfg.vlen, 128), > DEFINE_PROP_UINT16("elen", RISCVCPU, cfg.elen, 64), > > - /* These are experimental so mark with 'x-' */ > DEFINE_PROP_BOOL("zba", RISCVCPU, cfg.ext_zba, true), > DEFINE_PROP_BOOL("zbb", RISCVCPU, cfg.ext_zbb, true), > DEFINE_PROP_BOOL("zbc", RISCVCPU, cfg.ext_zbc, true), > DEFINE_PROP_BOOL("zbs", RISCVCPU, cfg.ext_zbs, true), > + > + /* These are experimental so mark with 'x-' */ > DEFINE_PROP_BOOL("x-h", RISCVCPU, cfg.ext_h, false), > DEFINE_PROP_BOOL("x-j", RISCVCPU, cfg.ext_j, false), > /* ePMP 0.9.3 */ > -- > 2.33.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com> To: Philipp Tomsich <philipp.tomsich@vrull.eu> Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "open list:RISC-V" <qemu-riscv@nongnu.org>, Bin Meng <bin.meng@windriver.com>, Vineet Gupta <vineetg@rivosinc.com>, Alistair Francis <alistair.francis@wdc.com>, Palmer Dabbelt <palmer@dabbelt.com> Subject: Re: [PATCH] target/riscv: Fix position of 'experimental' comment Date: Fri, 7 Jan 2022 07:30:15 +1000 [thread overview] Message-ID: <CAKmqyKPcYRPsvLvCUs-kL6f+4YJPZBgcL02Eoegrmv=HLiAUrg@mail.gmail.com> (raw) In-Reply-To: <20220106134020.1628889-1-philipp.tomsich@vrull.eu> On Fri, Jan 7, 2022 at 12:30 AM Philipp Tomsich <philipp.tomsich@vrull.eu> wrote: > > When commit 0643c12e4b dropped the 'x-' prefix for Zb[abcs] and set > them to be enabled by default, the comment about experimental > extensions was kept in place above them. This moves it down a few > lines to only cover experimental extensions. > > References: 0643c12e4b ("target/riscv: Enable bitmanip Zb[abcs] instructions") > > Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > > --- > > target/riscv/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 6ef3314bce..e322e729d2 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -640,11 +640,12 @@ static Property riscv_cpu_properties[] = { > DEFINE_PROP_UINT16("vlen", RISCVCPU, cfg.vlen, 128), > DEFINE_PROP_UINT16("elen", RISCVCPU, cfg.elen, 64), > > - /* These are experimental so mark with 'x-' */ > DEFINE_PROP_BOOL("zba", RISCVCPU, cfg.ext_zba, true), > DEFINE_PROP_BOOL("zbb", RISCVCPU, cfg.ext_zbb, true), > DEFINE_PROP_BOOL("zbc", RISCVCPU, cfg.ext_zbc, true), > DEFINE_PROP_BOOL("zbs", RISCVCPU, cfg.ext_zbs, true), > + > + /* These are experimental so mark with 'x-' */ > DEFINE_PROP_BOOL("x-h", RISCVCPU, cfg.ext_h, false), > DEFINE_PROP_BOOL("x-j", RISCVCPU, cfg.ext_j, false), > /* ePMP 0.9.3 */ > -- > 2.33.1 > >
next prev parent reply other threads:[~2022-01-06 21:31 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-06 13:40 [PATCH] target/riscv: Fix position of 'experimental' comment Philipp Tomsich 2022-01-06 13:40 ` Philipp Tomsich 2022-01-06 14:50 ` Bin Meng 2022-01-06 14:50 ` Bin Meng 2022-01-06 19:51 ` Philippe Mathieu-Daudé 2022-01-06 19:51 ` Philippe Mathieu-Daudé 2022-01-06 21:30 ` Alistair Francis [this message] 2022-01-06 21:30 ` Alistair Francis 2022-01-06 22:17 ` Alistair Francis 2022-01-06 22:17 ` Alistair Francis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKmqyKPcYRPsvLvCUs-kL6f+4YJPZBgcL02Eoegrmv=HLiAUrg@mail.gmail.com' \ --to=alistair23@gmail.com \ --cc=alistair.francis@wdc.com \ --cc=bin.meng@windriver.com \ --cc=palmer@dabbelt.com \ --cc=philipp.tomsich@vrull.eu \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=vineetg@rivosinc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.