From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>, Nikunj Kela <nkela@quicinc.com>,
Prasad Sodagudi <psodagud@quicinc.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/13] firmware: arm_scmi: Align perf ops to use domain-id as in-parameter
Date: Thu, 21 Sep 2023 16:29:15 +0200 [thread overview]
Message-ID: <CAKohpoma56EGs=gTTQGyQ5jw8f1bZvd2tJYZjYTTnkAf4A58tA@mail.gmail.com> (raw)
In-Reply-To: <20230825112633.236607-5-ulf.hansson@linaro.org>
On Fri, 25 Aug 2023 at 13:27, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> Most scmi_perf_proto_ops are already using an "u32 domain" as an
> in-parameter to indicate what performance domain we shall operate upon.
> However, some of the ops are using a "struct device *dev", which means that
> an additional OF parsing is needed each time the perf ops gets called, to
> find the corresponding domain-id.
>
> To avoid the above, but also to make the code more consistent, let's
> replace the in-parameter "struct device *dev" with an "u32 domain". Note
> that, this requires us to make some corresponding changes to the scmi
> cpufreq driver, so let's do that too.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v3:
> - Re-based.
>
> ---
> drivers/cpufreq/scmi-cpufreq.c | 14 +++++++++-----
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>, Nikunj Kela <nkela@quicinc.com>,
Prasad Sodagudi <psodagud@quicinc.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/13] firmware: arm_scmi: Align perf ops to use domain-id as in-parameter
Date: Thu, 21 Sep 2023 16:29:15 +0200 [thread overview]
Message-ID: <CAKohpoma56EGs=gTTQGyQ5jw8f1bZvd2tJYZjYTTnkAf4A58tA@mail.gmail.com> (raw)
In-Reply-To: <20230825112633.236607-5-ulf.hansson@linaro.org>
On Fri, 25 Aug 2023 at 13:27, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> Most scmi_perf_proto_ops are already using an "u32 domain" as an
> in-parameter to indicate what performance domain we shall operate upon.
> However, some of the ops are using a "struct device *dev", which means that
> an additional OF parsing is needed each time the perf ops gets called, to
> find the corresponding domain-id.
>
> To avoid the above, but also to make the code more consistent, let's
> replace the in-parameter "struct device *dev" with an "u32 domain". Note
> that, this requires us to make some corresponding changes to the scmi
> cpufreq driver, so let's do that too.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v3:
> - Re-based.
>
> ---
> drivers/cpufreq/scmi-cpufreq.c | 14 +++++++++-----
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
next prev parent reply other threads:[~2023-09-21 14:30 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 11:26 [PATCH v3 00/13] arm_scmi/cpufreq: Add generic performance scaling support Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-08-25 11:26 ` [PATCH v3 01/13] firmware: arm_scmi: Extend perf protocol ops to get number of domains Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-08-25 11:26 ` [PATCH v3 02/13] firmware: arm_scmi: Extend perf protocol ops to get information of a domain Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-08-25 11:26 ` [PATCH v3 03/13] cpufreq: scmi: Prepare to move OF parsing of domain-id to cpufreq Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-21 14:28 ` Viresh Kumar
2023-09-21 14:28 ` Viresh Kumar
2023-08-25 11:26 ` [PATCH v3 04/13] firmware: arm_scmi: Align perf ops to use domain-id as in-parameter Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-21 14:29 ` Viresh Kumar [this message]
2023-09-21 14:29 ` Viresh Kumar
2023-08-25 11:26 ` [PATCH v3 05/13] firmware: arm_scmi: Drop redundant ->device_domain_id() from perf ops Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-08-25 11:26 ` [PATCH v3 06/13] cpufreq: scmi: Avoid one OF parsing in scmi_get_sharing_cpus() Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-21 14:29 ` Viresh Kumar
2023-09-21 14:29 ` Viresh Kumar
2023-08-25 11:26 ` [PATCH v3 07/13] cpufreq: scmi: Drop redundant ifdef in scmi_cpufreq_probe() Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-21 11:14 ` Sudeep Holla
2023-09-21 11:14 ` Sudeep Holla
2023-09-21 13:02 ` Ulf Hansson
2023-09-21 13:02 ` Ulf Hansson
2023-09-21 13:29 ` Sudeep Holla
2023-09-21 13:29 ` Sudeep Holla
2023-08-25 11:26 ` [PATCH v3 08/13] dt-bindings: arm: cpus: Add a power-domain-name for a performance-domain Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-11 13:20 ` Rob Herring
2023-09-11 13:20 ` Rob Herring
2023-09-21 11:11 ` Sudeep Holla
2023-09-21 11:11 ` Sudeep Holla
2023-09-21 13:22 ` Ulf Hansson
2023-09-21 13:22 ` Ulf Hansson
2023-09-21 13:35 ` Sudeep Holla
2023-09-21 13:35 ` Sudeep Holla
2023-08-25 11:26 ` [PATCH v3 09/13] dt-bindings: firmware: arm,scmi: Extend bindings for protocol@13 Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-11 13:20 ` Rob Herring
2023-09-11 13:20 ` Rob Herring
2023-08-25 11:26 ` [PATCH v3 10/13] dt-bindings: power: Clarify performance capabilities of power-domains Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-11 14:40 ` Rob Herring
2023-09-11 14:40 ` Rob Herring
2023-08-25 11:26 ` [PATCH v3 11/13] cpufreq: scmi: Add support to parse domain-id using #power-domain-cells Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-21 11:17 ` Sudeep Holla
2023-09-21 11:17 ` Sudeep Holla
2023-09-21 14:30 ` Viresh Kumar
2023-09-21 14:30 ` Viresh Kumar
2023-08-25 11:26 ` [PATCH v3 12/13] PM: domains: Allow genpd providers to manage OPP tables directly by its FW Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-21 11:20 ` Sudeep Holla
2023-09-21 11:20 ` Sudeep Holla
2023-09-21 13:05 ` Ulf Hansson
2023-09-21 13:05 ` Ulf Hansson
2023-09-21 13:30 ` Sudeep Holla
2023-09-21 13:30 ` Sudeep Holla
2023-08-25 11:26 ` [PATCH v3 13/13] genpd: arm: Add the SCMI performance domain Ulf Hansson
2023-08-25 11:26 ` Ulf Hansson
2023-09-14 22:45 ` [PATCH v3 00/13] arm_scmi/cpufreq: Add generic performance scaling support Ulf Hansson
2023-09-14 22:45 ` Ulf Hansson
2023-09-18 10:26 ` Sudeep Holla
2023-09-18 10:26 ` Sudeep Holla
2023-09-19 10:24 ` Ulf Hansson
2023-09-19 10:24 ` Ulf Hansson
2023-09-25 9:39 ` Sudeep Holla
2023-09-25 9:39 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpoma56EGs=gTTQGyQ5jw8f1bZvd2tJYZjYTTnkAf4A58tA@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nkela@quicinc.com \
--cc=nm@ti.com \
--cc=psodagud@quicinc.com \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.