From: Ard Biesheuvel <ard.biesheuvel@linaro.org> To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Michael Ellerman <mpe@ellerman.id.au>, jeyu@redhat.com Cc: Will Deacon <will.deacon@arm.com>, Rusty Russell <rusty@rustcorp.com.au>, Andrew Morton <akpm@linux-foundation.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, "paulus@samba.org" <paulus@samba.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org> Subject: Re: [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y Date: Fri, 4 Nov 2016 09:55:44 +0000 [thread overview] Message-ID: <CAKv+Gu8Yc9rUacE70mvZSR92g1OY6LYyN6zrd--omwZVqwg3TA@mail.gmail.com> (raw) In-Reply-To: <1477585631-18574-1-git-send-email-ard.biesheuvel@linaro.org> On 27 October 2016 at 17:27, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > This series is a followup to the single patch 'modversions: treat symbol > CRCs as 32 bit quantities on 64 bit archs', of which two versions have > been sent out so far [0][1] > > As pointed out by Michael, GNU ld behaves a bit differently between arm64 > and PowerPC64, and where the former gets rid of all runtime relocations > related to CRCs, the latter is not as easily convinced. > > Patch #1 fixes the issue where CRCs are corrupted by the runtime relocation > routines for 32-bit PowerPC, for which the original fix was effectively > reverted by commit 0e0ed6406e61 ("powerpc/modules: Module CRC relocation fix > causes perf issues") > > Patch #2 adds handling of R_PPC64_ADDR32 relocations against the NULL .dynsym > symbol entry to the PPC64 runtime relocation routines, so it is prepared to > deal with CRCs being emitted as 32-bit quantities. > > Patch #3 is the original patch from the v1 and v2 submissions. > > Changes since v2: > - added #1 and #2 > - updated #3 to deal with CRC entries being emitted from assembler > - added Rusty's ack (#3) > > Branch can be found here: > https://git.kernel.org/cgit/linux/kernel/git/ardb/linux.git/log/?h=kcrctab-reloc > > [0] http://marc.info/?l=linux-kernel&m=147652300207369&w=2 > [1] http://marc.info/?l=linux-kernel&m=147695629614409&w=2 > Ping? > Ard Biesheuvel (3): > powerpc/reloc32: fix corrupted modversion CRCs > powerpc/reloc64: add support for 32-bit CRC pseudo-symbols > modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs > > arch/powerpc/include/asm/module.h | 4 -- > arch/powerpc/kernel/module_64.c | 8 ---- > arch/powerpc/kernel/reloc_32.S | 36 +++++++++++++-- > arch/powerpc/kernel/reloc_64.S | 22 +++++++-- > arch/powerpc/relocs_check.sh | 3 +- > include/asm-generic/export.h | 7 +-- > include/linux/export.h | 8 ++++ > include/linux/module.h | 14 +++--- > kernel/module.c | 47 +++++++------------- > 9 files changed, 85 insertions(+), 64 deletions(-) > > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: ard.biesheuvel@linaro.org (Ard Biesheuvel) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y Date: Fri, 4 Nov 2016 09:55:44 +0000 [thread overview] Message-ID: <CAKv+Gu8Yc9rUacE70mvZSR92g1OY6LYyN6zrd--omwZVqwg3TA@mail.gmail.com> (raw) In-Reply-To: <1477585631-18574-1-git-send-email-ard.biesheuvel@linaro.org> On 27 October 2016 at 17:27, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > This series is a followup to the single patch 'modversions: treat symbol > CRCs as 32 bit quantities on 64 bit archs', of which two versions have > been sent out so far [0][1] > > As pointed out by Michael, GNU ld behaves a bit differently between arm64 > and PowerPC64, and where the former gets rid of all runtime relocations > related to CRCs, the latter is not as easily convinced. > > Patch #1 fixes the issue where CRCs are corrupted by the runtime relocation > routines for 32-bit PowerPC, for which the original fix was effectively > reverted by commit 0e0ed6406e61 ("powerpc/modules: Module CRC relocation fix > causes perf issues") > > Patch #2 adds handling of R_PPC64_ADDR32 relocations against the NULL .dynsym > symbol entry to the PPC64 runtime relocation routines, so it is prepared to > deal with CRCs being emitted as 32-bit quantities. > > Patch #3 is the original patch from the v1 and v2 submissions. > > Changes since v2: > - added #1 and #2 > - updated #3 to deal with CRC entries being emitted from assembler > - added Rusty's ack (#3) > > Branch can be found here: > https://git.kernel.org/cgit/linux/kernel/git/ardb/linux.git/log/?h=kcrctab-reloc > > [0] http://marc.info/?l=linux-kernel&m=147652300207369&w=2 > [1] http://marc.info/?l=linux-kernel&m=147695629614409&w=2 > Ping? > Ard Biesheuvel (3): > powerpc/reloc32: fix corrupted modversion CRCs > powerpc/reloc64: add support for 32-bit CRC pseudo-symbols > modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs > > arch/powerpc/include/asm/module.h | 4 -- > arch/powerpc/kernel/module_64.c | 8 ---- > arch/powerpc/kernel/reloc_32.S | 36 +++++++++++++-- > arch/powerpc/kernel/reloc_64.S | 22 +++++++-- > arch/powerpc/relocs_check.sh | 3 +- > include/asm-generic/export.h | 7 +-- > include/linux/export.h | 8 ++++ > include/linux/module.h | 14 +++--- > kernel/module.c | 47 +++++++------------- > 9 files changed, 85 insertions(+), 64 deletions(-) > > -- > 2.7.4 >
next prev parent reply other threads:[~2016-11-04 9:55 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-27 16:27 [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y Ard Biesheuvel 2016-10-27 16:27 ` Ard Biesheuvel 2016-10-27 16:27 ` [PATCH v3 1/3] powerpc/reloc32: fix corrupted modversion CRCs Ard Biesheuvel 2016-10-27 16:27 ` Ard Biesheuvel 2016-10-28 10:27 ` Suzuki K Poulose 2016-10-28 10:27 ` Suzuki K Poulose 2016-10-27 16:27 ` [PATCH v3 2/3] powerpc/reloc64: add support for 32-bit CRC pseudo-symbols Ard Biesheuvel 2016-10-27 16:27 ` Ard Biesheuvel 2016-11-25 11:29 ` Michael Ellerman 2016-11-25 11:29 ` Michael Ellerman 2016-11-25 12:48 ` Ard Biesheuvel 2016-11-25 12:48 ` Ard Biesheuvel 2016-12-01 9:39 ` Michael Ellerman 2016-12-01 9:39 ` Michael Ellerman 2016-12-01 9:45 ` Ard Biesheuvel 2016-12-01 9:45 ` Ard Biesheuvel 2016-12-01 16:28 ` Ard Biesheuvel 2016-12-01 16:28 ` Ard Biesheuvel 2016-10-27 16:27 ` [PATCH v3 3/3] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs Ard Biesheuvel 2016-10-27 16:27 ` Ard Biesheuvel 2016-11-04 9:55 ` Ard Biesheuvel [this message] 2016-11-04 9:55 ` [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y Ard Biesheuvel 2016-11-10 4:22 ` Michael Ellerman 2016-11-10 4:22 ` Michael Ellerman 2016-11-15 9:13 ` Ard Biesheuvel 2016-11-15 9:13 ` Ard Biesheuvel 2016-11-25 8:44 ` Ard Biesheuvel 2016-11-25 8:44 ` Ard Biesheuvel 2016-11-25 11:12 ` Michael Ellerman 2016-11-25 11:12 ` Michael Ellerman 2016-11-16 19:23 ` Uwe Kleine-König 2016-11-16 19:23 ` Uwe Kleine-König 2016-11-16 20:29 ` Ard Biesheuvel 2016-11-16 20:29 ` Ard Biesheuvel -- strict thread matches above, loose matches on Subject: below -- 2016-10-27 16:26 Ard Biesheuvel 2016-10-27 16:26 ` Ard Biesheuvel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKv+Gu8Yc9rUacE70mvZSR92g1OY6LYyN6zrd--omwZVqwg3TA@mail.gmail.com \ --to=ard.biesheuvel@linaro.org \ --cc=akpm@linux-foundation.org \ --cc=benh@kernel.crashing.org \ --cc=jeyu@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=rusty@rustcorp.com.au \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.