From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Michael Ellerman <mpe@ellerman.id.au>,
jeyu@redhat.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Will Deacon <will.deacon@arm.com>,
"paulus@samba.org" <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y
Date: Wed, 16 Nov 2016 20:29:13 +0000 [thread overview]
Message-ID: <CAKv+Gu-cjwOaNuQ-BJdcmr_0w3pfr7etN=T5CG_Sbj_tsomZhg@mail.gmail.com> (raw)
In-Reply-To: <20161116192331.2jwpewu33dwji3fa@pengutronix.de>
On 16 November 2016 at 19:23, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> On Thu, Oct 27, 2016 at 05:27:08PM +0100, Ard Biesheuvel wrote:
>> This series is a followup to the single patch 'modversions: treat symbol
>> CRCs as 32 bit quantities on 64 bit archs', of which two versions have
>> been sent out so far [0][1]
>>
>> As pointed out by Michael, GNU ld behaves a bit differently between arm64
>> and PowerPC64, and where the former gets rid of all runtime relocations
>> related to CRCs, the latter is not as easily convinced.
>>
>> Patch #1 fixes the issue where CRCs are corrupted by the runtime relocation
>> routines for 32-bit PowerPC, for which the original fix was effectively
>> reverted by commit 0e0ed6406e61 ("powerpc/modules: Module CRC relocation fix
>> causes perf issues")
>>
>> Patch #2 adds handling of R_PPC64_ADDR32 relocations against the NULL .dynsym
>> symbol entry to the PPC64 runtime relocation routines, so it is prepared to
>> deal with CRCs being emitted as 32-bit quantities.
>>
>> Patch #3 is the original patch from the v1 and v2 submissions.
>
> Is this related to me seeing
>
> [ 2.111424] mvneta: module verification failed: signature and/or required key missing - tainting kernel
> [ 2.126061] scsi_mod: no symbol version for _clear_bit
> [ 2.131257] scsi_mod: Unknown symbol _clear_bit (err -22)
> [ 2.138093] mvneta: no symbol version for _clear_bit
> [ 2.143117] mvneta: Unknown symbol _clear_bit (err -22)
> [ 2.144135] mvmdio: no symbol version for __gnu_mcount_nc
> [ 2.144138] mvmdio: Unknown symbol __gnu_mcount_nc (err -22)
> ...
>
> ? If so, this would be great to mention it in the commit log to make
> people searching for this issue actually find this patch set.
>
No, I don't think it is. My guess would be that it is caused by
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4dd1837d75
WARNING: multiple messages have this Message-ID (diff)
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y
Date: Wed, 16 Nov 2016 20:29:13 +0000 [thread overview]
Message-ID: <CAKv+Gu-cjwOaNuQ-BJdcmr_0w3pfr7etN=T5CG_Sbj_tsomZhg@mail.gmail.com> (raw)
In-Reply-To: <20161116192331.2jwpewu33dwji3fa@pengutronix.de>
On 16 November 2016 at 19:23, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
> On Thu, Oct 27, 2016 at 05:27:08PM +0100, Ard Biesheuvel wrote:
>> This series is a followup to the single patch 'modversions: treat symbol
>> CRCs as 32 bit quantities on 64 bit archs', of which two versions have
>> been sent out so far [0][1]
>>
>> As pointed out by Michael, GNU ld behaves a bit differently between arm64
>> and PowerPC64, and where the former gets rid of all runtime relocations
>> related to CRCs, the latter is not as easily convinced.
>>
>> Patch #1 fixes the issue where CRCs are corrupted by the runtime relocation
>> routines for 32-bit PowerPC, for which the original fix was effectively
>> reverted by commit 0e0ed6406e61 ("powerpc/modules: Module CRC relocation fix
>> causes perf issues")
>>
>> Patch #2 adds handling of R_PPC64_ADDR32 relocations against the NULL .dynsym
>> symbol entry to the PPC64 runtime relocation routines, so it is prepared to
>> deal with CRCs being emitted as 32-bit quantities.
>>
>> Patch #3 is the original patch from the v1 and v2 submissions.
>
> Is this related to me seeing
>
> [ 2.111424] mvneta: module verification failed: signature and/or required key missing - tainting kernel
> [ 2.126061] scsi_mod: no symbol version for _clear_bit
> [ 2.131257] scsi_mod: Unknown symbol _clear_bit (err -22)
> [ 2.138093] mvneta: no symbol version for _clear_bit
> [ 2.143117] mvneta: Unknown symbol _clear_bit (err -22)
> [ 2.144135] mvmdio: no symbol version for __gnu_mcount_nc
> [ 2.144138] mvmdio: Unknown symbol __gnu_mcount_nc (err -22)
> ...
>
> ? If so, this would be great to mention it in the commit log to make
> people searching for this issue actually find this patch set.
>
No, I don't think it is. My guess would be that it is caused by
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4dd1837d75
next prev parent reply other threads:[~2016-11-16 20:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 16:27 [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y Ard Biesheuvel
2016-10-27 16:27 ` Ard Biesheuvel
2016-10-27 16:27 ` [PATCH v3 1/3] powerpc/reloc32: fix corrupted modversion CRCs Ard Biesheuvel
2016-10-27 16:27 ` Ard Biesheuvel
2016-10-28 10:27 ` Suzuki K Poulose
2016-10-28 10:27 ` Suzuki K Poulose
2016-10-27 16:27 ` [PATCH v3 2/3] powerpc/reloc64: add support for 32-bit CRC pseudo-symbols Ard Biesheuvel
2016-10-27 16:27 ` Ard Biesheuvel
2016-11-25 11:29 ` Michael Ellerman
2016-11-25 11:29 ` Michael Ellerman
2016-11-25 12:48 ` Ard Biesheuvel
2016-11-25 12:48 ` Ard Biesheuvel
2016-12-01 9:39 ` Michael Ellerman
2016-12-01 9:39 ` Michael Ellerman
2016-12-01 9:45 ` Ard Biesheuvel
2016-12-01 9:45 ` Ard Biesheuvel
2016-12-01 16:28 ` Ard Biesheuvel
2016-12-01 16:28 ` Ard Biesheuvel
2016-10-27 16:27 ` [PATCH v3 3/3] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs Ard Biesheuvel
2016-10-27 16:27 ` Ard Biesheuvel
2016-11-04 9:55 ` [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y Ard Biesheuvel
2016-11-04 9:55 ` Ard Biesheuvel
2016-11-10 4:22 ` Michael Ellerman
2016-11-10 4:22 ` Michael Ellerman
2016-11-15 9:13 ` Ard Biesheuvel
2016-11-15 9:13 ` Ard Biesheuvel
2016-11-25 8:44 ` Ard Biesheuvel
2016-11-25 8:44 ` Ard Biesheuvel
2016-11-25 11:12 ` Michael Ellerman
2016-11-25 11:12 ` Michael Ellerman
2016-11-16 19:23 ` Uwe Kleine-König
2016-11-16 19:23 ` Uwe Kleine-König
2016-11-16 20:29 ` Ard Biesheuvel [this message]
2016-11-16 20:29 ` Ard Biesheuvel
-- strict thread matches above, loose matches on Subject: below --
2016-10-27 16:26 Ard Biesheuvel
2016-10-27 16:26 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-cjwOaNuQ-BJdcmr_0w3pfr7etN=T5CG_Sbj_tsomZhg@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=jeyu@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.