From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: David Howells <dhowells@redhat.com>
Cc: Mat Martineau <mathew.j.martineau@linux.intel.com>,
keyrings@vger.kernel.org,
Matthew Garrett <matthew.garrett@nebula.com>,
linux-security-module <linux-security-module@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/9] efi: Add EFI signature data types
Date: Mon, 21 Nov 2016 16:08:05 +0000 [thread overview]
Message-ID: <CAKv+Gu_WUG6VGEvkhDpY9nDExazhubYhvZ-j81+fbA=j5LQZJQ@mail.gmail.com> (raw)
In-Reply-To: <26198.1479375840@warthog.procyon.org.uk>
On 17 November 2016 at 09:44, David Howells <dhowells@redhat.com> wrote:
> Mat Martineau <mathew.j.martineau@linux.intel.com> wrote:
>
>> The trailing ';' on EFI_CERT_X509_SHA256_GUID could trip someone up later. As
>> long as you're fixing that, the spaces before the closing parens are
>> inconsistent with the other GUID definitions in this file.
>
> Fixed, thanks.
>
With the fix
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Mat Martineau
<mathew.j.martineau-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matthew Garrett
<matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>,
linux-security-module
<linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 6/9] efi: Add EFI signature data types
Date: Mon, 21 Nov 2016 16:08:05 +0000 [thread overview]
Message-ID: <CAKv+Gu_WUG6VGEvkhDpY9nDExazhubYhvZ-j81+fbA=j5LQZJQ@mail.gmail.com> (raw)
In-Reply-To: <26198.1479375840-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
On 17 November 2016 at 09:44, David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Mat Martineau <mathew.j.martineau-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
>
>> The trailing ';' on EFI_CERT_X509_SHA256_GUID could trip someone up later. As
>> long as you're fixing that, the spaces before the closing parens are
>> inconsistent with the other GUID definitions in this file.
>
> Fixed, thanks.
>
With the fix
Reviewed-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
next prev parent reply other threads:[~2016-11-21 16:08 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 18:10 [PATCH 0/9] KEYS: Blacklisting & UEFI database load David Howells
2016-11-16 18:10 ` David Howells
2016-11-16 18:10 ` [PATCH 1/9] KEYS: Add a system blacklist keyring David Howells
2016-11-16 18:10 ` [PATCH 2/9] X.509: Allow X.509 certs to be blacklisted David Howells
2016-11-16 18:11 ` [PATCH 3/9] PKCS#7: Handle blacklisted certificates David Howells
2016-11-16 18:11 ` [PATCH 4/9] KEYS: Allow unrestricted boot-time addition of keys to secondary keyring David Howells
2016-11-17 6:41 ` Petko Manolov
2016-11-17 9:56 ` David Howells
2016-11-17 10:22 ` Petko Manolov
2016-11-17 10:22 ` Petko Manolov
2016-11-17 11:18 ` David Howells
2016-11-17 11:18 ` David Howells
2016-11-21 14:04 ` Mimi Zohar
2016-11-21 14:04 ` Mimi Zohar
2016-11-21 15:17 ` David Howells
2016-11-21 16:24 ` Mimi Zohar
2016-11-16 18:11 ` [PATCH 5/9] efi: Add SHIM and image security database GUID definitions David Howells
2016-11-21 16:07 ` Ard Biesheuvel
2016-11-16 18:11 ` [PATCH 6/9] efi: Add EFI signature data types David Howells
2016-11-16 23:43 ` Mat Martineau
2016-11-17 9:44 ` David Howells
2016-11-17 9:44 ` David Howells
2016-11-21 16:08 ` Ard Biesheuvel [this message]
2016-11-21 16:08 ` Ard Biesheuvel
2016-11-16 18:11 ` [PATCH 7/9] efi: Add an EFI signature blob parser David Howells
2016-11-16 18:11 ` [PATCH 8/9] MODSIGN: Import certificates from UEFI Secure Boot David Howells
2016-11-21 16:16 ` Ard Biesheuvel
2016-11-21 16:25 ` Josh Boyer
2016-11-21 16:25 ` Josh Boyer
2016-11-24 19:22 ` James Bottomley
2016-11-24 19:22 ` James Bottomley
2016-11-24 19:17 ` James Bottomley
2016-11-24 19:17 ` James Bottomley
2016-12-02 18:57 ` James Bottomley
2016-12-02 20:18 ` Mimi Zohar
2016-11-16 18:11 ` [PATCH 9/9] MODSIGN: Allow the "db" UEFI variable to be suppressed David Howells
2016-11-21 16:18 ` Ard Biesheuvel
2016-11-21 16:18 ` Ard Biesheuvel
2016-11-21 16:26 ` Josh Boyer
2016-11-21 16:26 ` Josh Boyer
2016-11-21 16:42 ` Ard Biesheuvel
2016-11-21 16:42 ` Ard Biesheuvel
2016-11-21 19:05 ` Peter Jones
2016-11-21 19:05 ` Peter Jones
2016-11-21 19:06 ` Ard Biesheuvel
2016-11-21 19:18 ` Peter Jones
2016-11-21 19:33 ` Ard Biesheuvel
2018-03-06 14:05 ` [PATCH 0/9] KEYS: Blacklisting & UEFI database load Jiri Slaby
2018-03-06 14:05 ` Jiri Slaby
2018-03-06 14:05 ` Jiri Slaby
2018-03-07 13:18 ` Mimi Zohar
2018-03-07 13:18 ` Mimi Zohar
2018-03-07 13:18 ` Mimi Zohar
2018-03-07 15:28 ` James Bottomley
2018-03-07 15:28 ` James Bottomley
2018-03-07 15:28 ` James Bottomley
2018-03-11 3:20 ` joeyli
2018-03-11 3:20 ` joeyli
2018-03-11 3:20 ` joeyli
2018-03-19 14:12 ` Mimi Zohar
2018-03-19 14:12 ` Mimi Zohar
2018-03-19 14:12 ` Mimi Zohar
2018-03-27 11:08 ` joeyli
2018-03-27 11:08 ` joeyli
2018-03-27 11:08 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_WUG6VGEvkhDpY9nDExazhubYhvZ-j81+fbA=j5LQZJQ@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthew.garrett@nebula.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.