From: Nick Desaulniers <ndesaulniers@google.com> To: Andrey Konovalov <andreyknvl@google.com> Cc: marc.zyngier@arm.com, Sami Tolvanen <samitolvanen@google.com>, christoffer.dall@arm.com, Takahiro Akashi <takahiro.akashi@linaro.org>, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] arm64: kvm: use -fno-jump-tables with clang Date: Wed, 23 May 2018 10:47:43 -0700 [thread overview] Message-ID: <CAKwvOd=fqk2bQSiPBsUmVSQLGUEGYSUev3iWvico6HOpYs5YJA@mail.gmail.com> (raw) In-Reply-To: <CAAeHK+wk0hSH6iQcsLzrpjvsGocev-UZ6=z95ysecdFnAcHVSQ@mail.gmail.com> On Wed, May 23, 2018 at 4:54 AM Andrey Konovalov <andreyknvl@google.com> wrote: > On Tue, May 22, 2018 at 8:28 PM, Nick Desaulniers > <ndesaulniers@google.com> wrote: > > On Fri, May 18, 2018 at 11:13 AM Marc Zyngier <marc.zyngier@arm.com> wrote: > >> > - you have checked that with a released version of the compiler, you > > > > On Tue, May 22, 2018 at 10:58 AM Andrey Konovalov <andreyknvl@google.com > > wrote: > >> Tested-by: Andrey Konovalov <andreyknvl@google.com> > > > > Hi Andrey, > > Thank you very much for this report. Can you confirm as well the version > > of Clang that you were using? > I'm on 86852a40 ("[InstCombine] Calloc-ed strings optimizations"). > > If it's not a binary release (built from > > source), would you be able to re-confirm with a released version? > Sure. Which release should I try and how do I get it? Maybe clang-6.0 as the latest release (though I suspect you may run into the recently-fixed-in-clang-7.0 "S" constraint bug that you reported). I've had luck on debian based distributions installing from: http://apt.llvm.org/ (These can be added to your /etc/apt/sources.list, then a `sudo apt update` and `sudo apt install clang-6.0`) If you're not able to add remote repositories (some employers block this ;) ), then you can find releases for download for a few different platforms: https://releases.llvm.org/ For example, a quick: $ mkdir llvm-6.0 $ cd !$ $ wget https://releases.llvm.org/6.0.0/clang+llvm-6.0.0-x86_64-linux-gnu-debian8.tar.xz $ tar xvf clang+llvm-6.0.0-x86_64-linux-gnu-debian8.tar.xz $ ./clang+llvm-6.0.0-x86_64-linux-gnu-debian8/bin/clang-6.0 -v clang version 6.0.0 (tags/RELEASE_600/final) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: .../llvm-6.0/./clang+llvm-6.0.0-x86_64-linux-gnu-debian8/bin Found candidate GCC installation: ... Candidate multilib: .;@m64 Selected multilib: .;@m64 Seems to work. -- Thanks, ~Nick Desaulniers
WARNING: multiple messages have this Message-ID (diff)
From: ndesaulniers@google.com (Nick Desaulniers) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64: kvm: use -fno-jump-tables with clang Date: Wed, 23 May 2018 10:47:43 -0700 [thread overview] Message-ID: <CAKwvOd=fqk2bQSiPBsUmVSQLGUEGYSUev3iWvico6HOpYs5YJA@mail.gmail.com> (raw) In-Reply-To: <CAAeHK+wk0hSH6iQcsLzrpjvsGocev-UZ6=z95ysecdFnAcHVSQ@mail.gmail.com> On Wed, May 23, 2018 at 4:54 AM Andrey Konovalov <andreyknvl@google.com> wrote: > On Tue, May 22, 2018 at 8:28 PM, Nick Desaulniers > <ndesaulniers@google.com> wrote: > > On Fri, May 18, 2018 at 11:13 AM Marc Zyngier <marc.zyngier@arm.com> wrote: > >> > - you have checked that with a released version of the compiler, you > > > > On Tue, May 22, 2018 at 10:58 AM Andrey Konovalov <andreyknvl@google.com > > wrote: > >> Tested-by: Andrey Konovalov <andreyknvl@google.com> > > > > Hi Andrey, > > Thank you very much for this report. Can you confirm as well the version > > of Clang that you were using? > I'm on 86852a40 ("[InstCombine] Calloc-ed strings optimizations"). > > If it's not a binary release (built from > > source), would you be able to re-confirm with a released version? > Sure. Which release should I try and how do I get it? Maybe clang-6.0 as the latest release (though I suspect you may run into the recently-fixed-in-clang-7.0 "S" constraint bug that you reported). I've had luck on debian based distributions installing from: http://apt.llvm.org/ (These can be added to your /etc/apt/sources.list, then a `sudo apt update` and `sudo apt install clang-6.0`) If you're not able to add remote repositories (some employers block this ;) ), then you can find releases for download for a few different platforms: https://releases.llvm.org/ For example, a quick: $ mkdir llvm-6.0 $ cd !$ $ wget https://releases.llvm.org/6.0.0/clang+llvm-6.0.0-x86_64-linux-gnu-debian8.tar.xz $ tar xvf clang+llvm-6.0.0-x86_64-linux-gnu-debian8.tar.xz $ ./clang+llvm-6.0.0-x86_64-linux-gnu-debian8/bin/clang-6.0 -v clang version 6.0.0 (tags/RELEASE_600/final) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: .../llvm-6.0/./clang+llvm-6.0.0-x86_64-linux-gnu-debian8/bin Found candidate GCC installation: ... Candidate multilib: .;@m64 Selected multilib: .;@m64 Seems to work. -- Thanks, ~Nick Desaulniers
next prev parent reply other threads:[~2018-05-23 17:47 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-18 17:02 [PATCH] arm64: kvm: use -fno-jump-tables with clang Sami Tolvanen 2018-05-18 17:02 ` Sami Tolvanen 2018-05-18 17:30 ` Marc Zyngier 2018-05-18 17:30 ` Marc Zyngier 2018-05-18 17:40 ` Nick Desaulniers 2018-05-18 17:40 ` Nick Desaulniers 2018-05-18 17:41 ` Nick Desaulniers 2018-05-18 17:41 ` Nick Desaulniers 2018-05-18 17:45 ` Marc Zyngier 2018-05-18 17:45 ` Marc Zyngier 2018-05-18 17:56 ` Nick Desaulniers 2018-05-18 17:56 ` Nick Desaulniers 2018-05-18 18:13 ` Marc Zyngier 2018-05-18 18:13 ` Marc Zyngier 2018-05-18 18:31 ` Nick Desaulniers 2018-05-18 18:31 ` Nick Desaulniers 2018-05-19 10:44 ` Marc Zyngier 2018-05-19 10:44 ` Marc Zyngier 2018-05-22 17:58 ` Andrey Konovalov 2018-05-22 17:58 ` Andrey Konovalov 2018-05-22 18:28 ` Nick Desaulniers 2018-05-22 18:28 ` Nick Desaulniers 2018-05-23 11:54 ` Andrey Konovalov 2018-05-23 11:54 ` Andrey Konovalov 2018-05-23 17:47 ` Nick Desaulniers [this message] 2018-05-23 17:47 ` Nick Desaulniers 2018-05-23 18:57 ` Andrey Konovalov 2018-05-23 18:57 ` Andrey Konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKwvOd=fqk2bQSiPBsUmVSQLGUEGYSUev3iWvico6HOpYs5YJA@mail.gmail.com' \ --to=ndesaulniers@google.com \ --cc=andreyknvl@google.com \ --cc=christoffer.dall@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=samitolvanen@google.com \ --cc=takahiro.akashi@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.