From: Nick Desaulniers <ndesaulniers@google.com> To: marc.zyngier@arm.com Cc: Sami Tolvanen <samitolvanen@google.com>, christoffer.dall@arm.com, Takahiro Akashi <takahiro.akashi@linaro.org>, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, LKML <linux-kernel@vger.kernel.org>, Andrey Konovalov <andreyknvl@google.com> Subject: Re: [PATCH] arm64: kvm: use -fno-jump-tables with clang Date: Fri, 18 May 2018 11:31:50 -0700 [thread overview] Message-ID: <CAKwvOdk+=JKcQP1ieLEkZftRGf-pqCTTzEuYvT_45YNMkEw_wA@mail.gmail.com> (raw) In-Reply-To: <3fd89842-86cd-ee01-0c2c-5438dd2d5f2a@arm.com> On Fri, May 18, 2018 at 11:13 AM Marc Zyngier <marc.zyngier@arm.com> wrote: > What I'd really like is to apply that patch knowing that: > - you have checked that with a released version of the compiler, you > don't observe any absolute address in any of the objects that are going > to be executed at EL2 on a mainline kernel, To verify, we should disassemble objects from arch/arm64/kvm/hyp/*.o and make sure we don't see absolute addresses? I can work with Sami to get a sense of what the before and after of this patch looks like in disassembly, then verify those changes are pervasive. > - you have successfully run guests with a mainline kernel, I believe Andrey has already done this. If he can verify (maybe during working hours next week), then maybe we can add his Tested-by to this patches commit message? > - it works for a reasonable set of common kernel configurations > (defconfig and some of the most useful debug options), It's easy for us to test our kernel configs for Android, ChromeOS, and defconfig. I'd be curious to know the shortlist of "most useful debug options" just to be a better kernel developer, personally. > - I can reproduce your findings with the same released compiler. Lets wait for Andrey to confirm his test setup. On the Android side, I think you should be able to get by with a released version, but I'd be curious to hear from Andrey. > Is that the case? I don't think any of the above is completely outlandish. These are all reasonable. Thanks for the feedback. -- Thanks, ~Nick Desaulniers
WARNING: multiple messages have this Message-ID (diff)
From: ndesaulniers@google.com (Nick Desaulniers) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64: kvm: use -fno-jump-tables with clang Date: Fri, 18 May 2018 11:31:50 -0700 [thread overview] Message-ID: <CAKwvOdk+=JKcQP1ieLEkZftRGf-pqCTTzEuYvT_45YNMkEw_wA@mail.gmail.com> (raw) In-Reply-To: <3fd89842-86cd-ee01-0c2c-5438dd2d5f2a@arm.com> On Fri, May 18, 2018 at 11:13 AM Marc Zyngier <marc.zyngier@arm.com> wrote: > What I'd really like is to apply that patch knowing that: > - you have checked that with a released version of the compiler, you > don't observe any absolute address in any of the objects that are going > to be executed at EL2 on a mainline kernel, To verify, we should disassemble objects from arch/arm64/kvm/hyp/*.o and make sure we don't see absolute addresses? I can work with Sami to get a sense of what the before and after of this patch looks like in disassembly, then verify those changes are pervasive. > - you have successfully run guests with a mainline kernel, I believe Andrey has already done this. If he can verify (maybe during working hours next week), then maybe we can add his Tested-by to this patches commit message? > - it works for a reasonable set of common kernel configurations > (defconfig and some of the most useful debug options), It's easy for us to test our kernel configs for Android, ChromeOS, and defconfig. I'd be curious to know the shortlist of "most useful debug options" just to be a better kernel developer, personally. > - I can reproduce your findings with the same released compiler. Lets wait for Andrey to confirm his test setup. On the Android side, I think you should be able to get by with a released version, but I'd be curious to hear from Andrey. > Is that the case? I don't think any of the above is completely outlandish. These are all reasonable. Thanks for the feedback. -- Thanks, ~Nick Desaulniers
next prev parent reply other threads:[~2018-05-18 18:32 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-18 17:02 [PATCH] arm64: kvm: use -fno-jump-tables with clang Sami Tolvanen 2018-05-18 17:02 ` Sami Tolvanen 2018-05-18 17:30 ` Marc Zyngier 2018-05-18 17:30 ` Marc Zyngier 2018-05-18 17:40 ` Nick Desaulniers 2018-05-18 17:40 ` Nick Desaulniers 2018-05-18 17:41 ` Nick Desaulniers 2018-05-18 17:41 ` Nick Desaulniers 2018-05-18 17:45 ` Marc Zyngier 2018-05-18 17:45 ` Marc Zyngier 2018-05-18 17:56 ` Nick Desaulniers 2018-05-18 17:56 ` Nick Desaulniers 2018-05-18 18:13 ` Marc Zyngier 2018-05-18 18:13 ` Marc Zyngier 2018-05-18 18:31 ` Nick Desaulniers [this message] 2018-05-18 18:31 ` Nick Desaulniers 2018-05-19 10:44 ` Marc Zyngier 2018-05-19 10:44 ` Marc Zyngier 2018-05-22 17:58 ` Andrey Konovalov 2018-05-22 17:58 ` Andrey Konovalov 2018-05-22 18:28 ` Nick Desaulniers 2018-05-22 18:28 ` Nick Desaulniers 2018-05-23 11:54 ` Andrey Konovalov 2018-05-23 11:54 ` Andrey Konovalov 2018-05-23 17:47 ` Nick Desaulniers 2018-05-23 17:47 ` Nick Desaulniers 2018-05-23 18:57 ` Andrey Konovalov 2018-05-23 18:57 ` Andrey Konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKwvOdk+=JKcQP1ieLEkZftRGf-pqCTTzEuYvT_45YNMkEw_wA@mail.gmail.com' \ --to=ndesaulniers@google.com \ --cc=andreyknvl@google.com \ --cc=christoffer.dall@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=samitolvanen@google.com \ --cc=takahiro.akashi@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.