All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	jarkko.sakkinen@linux.intel.com, zohar@linux.vnet.ibm.com
Cc: David Howells <dhowells@redhat.com>,
	Nathan Chancellor <natechancellor@gmail.com>,
	David.Laight@aculab.com, denkenz@gmail.com, jmorris@namei.org,
	serge@hallyn.com, keyrings@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2] [PATCH] KEYS: trusted: fix -Wvarags warning
Date: Mon, 11 Feb 2019 18:36:51 +0000	[thread overview]
Message-ID: <CAKwvOdnhDin6TJfBVxm6xsCh_nJeBuA7GqbgJwgLnqc3PrJGxA@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdn+V8iFJ_V1vr3GBm-NwxzaDbcmK+nW1q3uVky7bRsB3w@mail.gmail.com>

On Mon, Oct 29, 2018 at 10:54 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Wed, Oct 24, 2018 at 1:37 AM Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > On Mon, 22 Oct 2018, ndesaulniers@google.com wrote:
> > > Fixes the warning reported by Clang:
> > > security/keys/trusted.c:146:17: warning: passing an object that
> > > undergoes default
> > >      argument promotion to 'va_start' has undefined behavior [-Wvarargs]
> > >        va_start(argp, h3);
> > >                       ^
> > > security/keys/trusted.c:126:37: note: parameter of type 'unsigned
> > > char' is declared here
> > > unsigned char *h2, unsigned char h3, ...)
> > >                               ^
> > > Specifically, it seems that both the C90 (4.8.1.1) and C11 (7.16.1.4)
> > > standards explicitly call this out as undefined behavior:
> > >
> > > The parameter parmN is the identifier of the rightmost parameter in
> > > the variable parameter list in the function definition (the one just
> > > before the ...). If the parameter parmN is declared with ... or with a
> > > type that is not compatible with the type that results after
> > > application of the default argument promotions, the behavior is
> > > undefined.
> > >
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/41
> > > Link: https://www.eskimo.com/~scs/cclass/int/sx11c.html
> > > Suggested-by: David Laight <David.Laight@aculab.com>
> > > Suggested-by: Denis Kenzior <denkenz@gmail.com>
> > > Suggested-by: James Bottomley <jejb@linux.vnet.ibm.com>
> > > Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > /Jarkko
>
> Bumping the maintainers if this isn't already picked up?

James, Jarkko, or Mimi, can you please pick this up (and let me know
what tree it lands in)?
https://lkml.org/lkml/2018/10/23/116
-- 
Thanks,
~Nick Desaulniers

WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com>
To: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	jarkko.sakkinen@linux.intel.com, zohar@linux.vnet.ibm.com
Cc: David Howells <dhowells@redhat.com>,
	Nathan Chancellor <natechancellor@gmail.com>,
	David.Laight@aculab.com, denkenz@gmail.com, jmorris@namei.org,
	serge@hallyn.com, keyrings@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2] [PATCH] KEYS: trusted: fix -Wvarags warning
Date: Mon, 11 Feb 2019 10:36:51 -0800	[thread overview]
Message-ID: <CAKwvOdnhDin6TJfBVxm6xsCh_nJeBuA7GqbgJwgLnqc3PrJGxA@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdn+V8iFJ_V1vr3GBm-NwxzaDbcmK+nW1q3uVky7bRsB3w@mail.gmail.com>

On Mon, Oct 29, 2018 at 10:54 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Wed, Oct 24, 2018 at 1:37 AM Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > On Mon, 22 Oct 2018, ndesaulniers@google.com wrote:
> > > Fixes the warning reported by Clang:
> > > security/keys/trusted.c:146:17: warning: passing an object that
> > > undergoes default
> > >      argument promotion to 'va_start' has undefined behavior [-Wvarargs]
> > >        va_start(argp, h3);
> > >                       ^
> > > security/keys/trusted.c:126:37: note: parameter of type 'unsigned
> > > char' is declared here
> > > unsigned char *h2, unsigned char h3, ...)
> > >                               ^
> > > Specifically, it seems that both the C90 (4.8.1.1) and C11 (7.16.1.4)
> > > standards explicitly call this out as undefined behavior:
> > >
> > > The parameter parmN is the identifier of the rightmost parameter in
> > > the variable parameter list in the function definition (the one just
> > > before the ...). If the parameter parmN is declared with ... or with a
> > > type that is not compatible with the type that results after
> > > application of the default argument promotions, the behavior is
> > > undefined.
> > >
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/41
> > > Link: https://www.eskimo.com/~scs/cclass/int/sx11c.html
> > > Suggested-by: David Laight <David.Laight@aculab.com>
> > > Suggested-by: Denis Kenzior <denkenz@gmail.com>
> > > Suggested-by: James Bottomley <jejb@linux.vnet.ibm.com>
> > > Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > /Jarkko
>
> Bumping the maintainers if this isn't already picked up?

James, Jarkko, or Mimi, can you please pick this up (and let me know
what tree it lands in)?
https://lkml.org/lkml/2018/10/23/116
-- 
Thanks,
~Nick Desaulniers

  reply	other threads:[~2019-02-11 18:36 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 22:11 undefined behavior (-Wvarargs) in security/keys/trusted.c#TSS_authhmac() Nick Desaulniers
2018-10-09 22:11 ` Nick Desaulniers
2018-10-11 16:02 ` Arnd Bergmann
2018-10-11 16:02   ` Arnd Bergmann
2018-10-11 16:10   ` James Bottomley
2018-10-11 16:10     ` James Bottomley
2018-10-11 20:31     ` [PATCH] KEYS: trusted: fix -Wvarags warning ndesaulniers
2018-10-11 20:31       ` ndesaulniers
2018-10-12  1:50       ` Nathan Chancellor
2018-10-12  1:50         ` Nathan Chancellor
2018-10-12 16:55         ` Nick Desaulniers
2018-10-12 16:55           ` Nick Desaulniers
2018-10-12 17:03           ` Nathan Chancellor
2018-10-12 17:03             ` Nathan Chancellor
2018-10-12 12:29       ` Denis Kenzior
2018-10-12 12:29         ` Denis Kenzior
2018-10-12 15:05         ` James Bottomley
2018-10-12 15:05           ` James Bottomley
2018-10-12 15:13           ` Denis Kenzior
2018-10-12 15:13             ` Denis Kenzior
2018-10-12 15:22             ` James Bottomley
2018-10-12 15:22               ` James Bottomley
2018-10-12 15:44               ` Denis Kenzior
2018-10-12 15:44                 ` Denis Kenzior
2018-10-12 15:46                 ` James Bottomley
2018-10-12 15:46                   ` James Bottomley
2018-10-12 15:53                   ` Denis Kenzior
2018-10-12 15:53                     ` Denis Kenzior
2018-10-12 16:01                     ` James Bottomley
2018-10-12 16:01                       ` James Bottomley
2018-10-12 17:14                       ` Nick Desaulniers
2018-10-12 17:14                         ` Nick Desaulniers
2018-10-12 15:25             ` James Bottomley
2018-10-12 15:25               ` James Bottomley
2018-10-12 17:05             ` Nick Desaulniers
2018-10-12 17:05               ` Nick Desaulniers
2018-10-12 17:17               ` Nick Desaulniers
2018-10-12 17:17                 ` Nick Desaulniers
2018-10-12 17:27               ` Denis Kenzior
2018-10-12 17:27                 ` Denis Kenzior
2018-10-12 18:39                 ` Nick Desaulniers
2018-10-12 18:39                   ` Nick Desaulniers
2018-10-12 17:02         ` Nick Desaulniers
2018-10-12 17:02           ` Nick Desaulniers
2018-10-12 17:15           ` Denis Kenzior
2018-10-12 17:15             ` Denis Kenzior
2018-10-15  9:26       ` David Laight
2018-10-15  9:26         ` David Laight
2018-10-15  9:26         ` David Laight
2018-10-15 21:53         ` Nick Desaulniers
2018-10-15 21:53           ` Nick Desaulniers
2018-10-16  8:13           ` David Laight
2018-10-16  8:13             ` David Laight
2018-10-16  8:13             ` David Laight
2018-10-22 23:43             ` [PATCH v2] " ndesaulniers
2018-10-22 23:43               ` ndesaulniers
2018-10-23  0:00               ` Nathan Chancellor
2018-10-23  0:00                 ` Nathan Chancellor
2018-10-24  8:36               ` Jarkko Sakkinen
2018-10-24  8:36                 ` Jarkko Sakkinen
2018-10-29 17:54                 ` Nick Desaulniers
2018-10-29 17:54                   ` Nick Desaulniers
2019-02-11 18:36                   ` Nick Desaulniers [this message]
2019-02-11 18:36                     ` Nick Desaulniers
2019-02-12 23:12                     ` Jarkko Sakkinen
2019-02-12 23:12                       ` Jarkko Sakkinen
2019-02-14 10:52                       ` Jarkko Sakkinen
2019-02-14 10:52                         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwvOdnhDin6TJfBVxm6xsCh_nJeBuA7GqbgJwgLnqc3PrJGxA@mail.gmail.com \
    --to=ndesaulniers@google.com \
    --cc=David.Laight@aculab.com \
    --cc=denkenz@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=serge@hallyn.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.