From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: dhowells@redhat.com, jejb@linux.vnet.ibm.com,
natechancellor@gmail.com, David.Laight@aculab.com,
denkenz@gmail.com,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2] [PATCH] KEYS: trusted: fix -Wvarags warning
Date: Wed, 24 Oct 2018 08:36:57 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1810241136130.3525@jsakkine-mobl1> (raw)
In-Reply-To: <20181022234357.82217-1-ndesaulniers@google.com>
On Mon, 22 Oct 2018, ndesaulniers@google.com wrote:
> Fixes the warning reported by Clang:
> security/keys/trusted.c:146:17: warning: passing an object that
> undergoes default
> argument promotion to 'va_start' has undefined behavior [-Wvarargs]
> va_start(argp, h3);
> ^
> security/keys/trusted.c:126:37: note: parameter of type 'unsigned
> char' is declared here
> unsigned char *h2, unsigned char h3, ...)
> ^
> Specifically, it seems that both the C90 (4.8.1.1) and C11 (7.16.1.4)
> standards explicitly call this out as undefined behavior:
>
> The parameter parmN is the identifier of the rightmost parameter in
> the variable parameter list in the function definition (the one just
> before the ...). If the parameter parmN is declared with ... or with a
> type that is not compatible with the type that results after
> application of the default argument promotions, the behavior is
> undefined.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/41
> Link: https://www.eskimo.com/~scs/cclass/int/sx11c.html
> Suggested-by: David Laight <David.Laight@aculab.com>
> Suggested-by: Denis Kenzior <denkenz@gmail.com>
> Suggested-by: James Bottomley <jejb@linux.vnet.ibm.com>
> Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: dhowells@redhat.com, jejb@linux.vnet.ibm.com,
natechancellor@gmail.com, David.Laight@aculab.com,
denkenz@gmail.com,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2] [PATCH] KEYS: trusted: fix -Wvarags warning
Date: Wed, 24 Oct 2018 11:36:57 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1810241136130.3525@jsakkine-mobl1> (raw)
In-Reply-To: <20181022234357.82217-1-ndesaulniers@google.com>
On Mon, 22 Oct 2018, ndesaulniers@google.com wrote:
> Fixes the warning reported by Clang:
> security/keys/trusted.c:146:17: warning: passing an object that
> undergoes default
> argument promotion to 'va_start' has undefined behavior [-Wvarargs]
> va_start(argp, h3);
> ^
> security/keys/trusted.c:126:37: note: parameter of type 'unsigned
> char' is declared here
> unsigned char *h2, unsigned char h3, ...)
> ^
> Specifically, it seems that both the C90 (4.8.1.1) and C11 (7.16.1.4)
> standards explicitly call this out as undefined behavior:
>
> The parameter parmN is the identifier of the rightmost parameter in
> the variable parameter list in the function definition (the one just
> before the ...). If the parameter parmN is declared with ... or with a
> type that is not compatible with the type that results after
> application of the default argument promotions, the behavior is
> undefined.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/41
> Link: https://www.eskimo.com/~scs/cclass/int/sx11c.html
> Suggested-by: David Laight <David.Laight@aculab.com>
> Suggested-by: Denis Kenzior <denkenz@gmail.com>
> Suggested-by: James Bottomley <jejb@linux.vnet.ibm.com>
> Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2018-10-24 8:36 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 22:11 undefined behavior (-Wvarargs) in security/keys/trusted.c#TSS_authhmac() Nick Desaulniers
2018-10-09 22:11 ` Nick Desaulniers
2018-10-11 16:02 ` Arnd Bergmann
2018-10-11 16:02 ` Arnd Bergmann
2018-10-11 16:10 ` James Bottomley
2018-10-11 16:10 ` James Bottomley
2018-10-11 20:31 ` [PATCH] KEYS: trusted: fix -Wvarags warning ndesaulniers
2018-10-11 20:31 ` ndesaulniers
2018-10-12 1:50 ` Nathan Chancellor
2018-10-12 1:50 ` Nathan Chancellor
2018-10-12 16:55 ` Nick Desaulniers
2018-10-12 16:55 ` Nick Desaulniers
2018-10-12 17:03 ` Nathan Chancellor
2018-10-12 17:03 ` Nathan Chancellor
2018-10-12 12:29 ` Denis Kenzior
2018-10-12 12:29 ` Denis Kenzior
2018-10-12 15:05 ` James Bottomley
2018-10-12 15:05 ` James Bottomley
2018-10-12 15:13 ` Denis Kenzior
2018-10-12 15:13 ` Denis Kenzior
2018-10-12 15:22 ` James Bottomley
2018-10-12 15:22 ` James Bottomley
2018-10-12 15:44 ` Denis Kenzior
2018-10-12 15:44 ` Denis Kenzior
2018-10-12 15:46 ` James Bottomley
2018-10-12 15:46 ` James Bottomley
2018-10-12 15:53 ` Denis Kenzior
2018-10-12 15:53 ` Denis Kenzior
2018-10-12 16:01 ` James Bottomley
2018-10-12 16:01 ` James Bottomley
2018-10-12 17:14 ` Nick Desaulniers
2018-10-12 17:14 ` Nick Desaulniers
2018-10-12 15:25 ` James Bottomley
2018-10-12 15:25 ` James Bottomley
2018-10-12 17:05 ` Nick Desaulniers
2018-10-12 17:05 ` Nick Desaulniers
2018-10-12 17:17 ` Nick Desaulniers
2018-10-12 17:17 ` Nick Desaulniers
2018-10-12 17:27 ` Denis Kenzior
2018-10-12 17:27 ` Denis Kenzior
2018-10-12 18:39 ` Nick Desaulniers
2018-10-12 18:39 ` Nick Desaulniers
2018-10-12 17:02 ` Nick Desaulniers
2018-10-12 17:02 ` Nick Desaulniers
2018-10-12 17:15 ` Denis Kenzior
2018-10-12 17:15 ` Denis Kenzior
2018-10-15 9:26 ` David Laight
2018-10-15 9:26 ` David Laight
2018-10-15 9:26 ` David Laight
2018-10-15 21:53 ` Nick Desaulniers
2018-10-15 21:53 ` Nick Desaulniers
2018-10-16 8:13 ` David Laight
2018-10-16 8:13 ` David Laight
2018-10-16 8:13 ` David Laight
2018-10-22 23:43 ` [PATCH v2] " ndesaulniers
2018-10-22 23:43 ` ndesaulniers
2018-10-23 0:00 ` Nathan Chancellor
2018-10-23 0:00 ` Nathan Chancellor
2018-10-24 8:36 ` Jarkko Sakkinen [this message]
2018-10-24 8:36 ` Jarkko Sakkinen
2018-10-29 17:54 ` Nick Desaulniers
2018-10-29 17:54 ` Nick Desaulniers
2019-02-11 18:36 ` Nick Desaulniers
2019-02-11 18:36 ` Nick Desaulniers
2019-02-12 23:12 ` Jarkko Sakkinen
2019-02-12 23:12 ` Jarkko Sakkinen
2019-02-14 10:52 ` Jarkko Sakkinen
2019-02-14 10:52 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1810241136130.3525@jsakkine-mobl1 \
--to=jarkko.sakkinen@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=denkenz@gmail.com \
--cc=dhowells@redhat.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=serge@hallyn.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.