From: Dillon Min <dillon.minfei@gmail.com> To: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, mchehab+huawei@kernel.org, ezequiel@collabora.com, gnurou@gmail.com, Pi-Hsun Shih <pihsun@chromium.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre TORGUE <alexandre.torgue@foss.st.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, gabriel.fernandez@st.com, gabriel.fernandez@foss.st.com, Patrice CHOTARD <patrice.chotard@foss.st.com>, hugues.fruchet@foss.st.com, linux-media <linux-media@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-stm32@st-md-mailman.stormreply.com, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [PATCH v5 09/10] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell Date: Mon, 18 Oct 2021 17:58:57 +0800 [thread overview] Message-ID: <CAL9mu0+wdQ-QGJEfjvc+x4vF--9HdvfG3W+5L3FWR9ij85YvTQ@mail.gmail.com> (raw) In-Reply-To: <1159ec06-cf36-efef-e87a-5d826b6b44d3@xs4all.nl> Hi Hans On Mon, 18 Oct 2021 at 17:37, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > > Hi Dillon, > > On 18/10/2021 07:04, dillon.minfei@gmail.com wrote: > > From: Dillon Min <dillon.minfei@gmail.com> > > > > stm32's clk driver register two ltdc gate clk to clk core by > > clk_hw_register_gate() and clk_hw_register_composite() > > > > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. > > second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver > > > > both of them point to the same offset of stm32's RCC register. after > > kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' > > is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. > > > > stm32f469/746/769 have the same issue, fix it. > > > > Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > Just to double check (I asked as well when v1 was posted, but that's a long time ago): > I can ignore this patch, right? If so, then make sure you follow up on this in the clk > subsystem since it is not yet merged in mainline. > > If you DO want me to pick it up, then I see that the clk maintainer has already Acked > it, so I take it as well. Appreciate, please help to pick it up. Thanks & Regards Dillon > > Regards, > > Hans > > > Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-send-email-dillon.minfei@gmail.com/ > > Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDUjqFFwkOeQeFDg@mail.gmail.com/ > > Signed-off-by: Dillon Min <dillon.minfei@gmail.com> > > --- > > v5: no change. > > > > drivers/clk/clk-stm32f4.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c > > index af46176ad053..473dfe632cc5 100644 > > --- a/drivers/clk/clk-stm32f4.c > > +++ b/drivers/clk/clk-stm32f4.c > > @@ -129,7 +129,6 @@ static const struct stm32f4_gate_data stm32f429_gates[] __initconst = { > > { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > > }; > > > > static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { > > @@ -211,7 +210,6 @@ static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { > > { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > > }; > > > > static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { > > @@ -286,7 +284,6 @@ static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { > > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" }, > > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > > }; > > > > static const struct stm32f4_gate_data stm32f769_gates[] __initconst = { > > @@ -364,7 +361,6 @@ static const struct stm32f4_gate_data stm32f769_gates[] __initconst = { > > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" }, > > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 30, "mdio", "apb2_div" }, > > }; > > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Dillon Min <dillon.minfei@gmail.com> To: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, mchehab+huawei@kernel.org, ezequiel@collabora.com, gnurou@gmail.com, Pi-Hsun Shih <pihsun@chromium.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre TORGUE <alexandre.torgue@foss.st.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, gabriel.fernandez@st.com, gabriel.fernandez@foss.st.com, Patrice CHOTARD <patrice.chotard@foss.st.com>, hugues.fruchet@foss.st.com, linux-media <linux-media@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-stm32@st-md-mailman.stormreply.com, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [PATCH v5 09/10] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell Date: Mon, 18 Oct 2021 17:58:57 +0800 [thread overview] Message-ID: <CAL9mu0+wdQ-QGJEfjvc+x4vF--9HdvfG3W+5L3FWR9ij85YvTQ@mail.gmail.com> (raw) In-Reply-To: <1159ec06-cf36-efef-e87a-5d826b6b44d3@xs4all.nl> Hi Hans On Mon, 18 Oct 2021 at 17:37, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > > Hi Dillon, > > On 18/10/2021 07:04, dillon.minfei@gmail.com wrote: > > From: Dillon Min <dillon.minfei@gmail.com> > > > > stm32's clk driver register two ltdc gate clk to clk core by > > clk_hw_register_gate() and clk_hw_register_composite() > > > > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. > > second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver > > > > both of them point to the same offset of stm32's RCC register. after > > kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' > > is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. > > > > stm32f469/746/769 have the same issue, fix it. > > > > Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > Just to double check (I asked as well when v1 was posted, but that's a long time ago): > I can ignore this patch, right? If so, then make sure you follow up on this in the clk > subsystem since it is not yet merged in mainline. > > If you DO want me to pick it up, then I see that the clk maintainer has already Acked > it, so I take it as well. Appreciate, please help to pick it up. Thanks & Regards Dillon > > Regards, > > Hans > > > Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-send-email-dillon.minfei@gmail.com/ > > Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDUjqFFwkOeQeFDg@mail.gmail.com/ > > Signed-off-by: Dillon Min <dillon.minfei@gmail.com> > > --- > > v5: no change. > > > > drivers/clk/clk-stm32f4.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c > > index af46176ad053..473dfe632cc5 100644 > > --- a/drivers/clk/clk-stm32f4.c > > +++ b/drivers/clk/clk-stm32f4.c > > @@ -129,7 +129,6 @@ static const struct stm32f4_gate_data stm32f429_gates[] __initconst = { > > { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > > }; > > > > static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { > > @@ -211,7 +210,6 @@ static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { > > { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > > }; > > > > static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { > > @@ -286,7 +284,6 @@ static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { > > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" }, > > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > > }; > > > > static const struct stm32f4_gate_data stm32f769_gates[] __initconst = { > > @@ -364,7 +361,6 @@ static const struct stm32f4_gate_data stm32f769_gates[] __initconst = { > > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" }, > > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > > { STM32F4_RCC_APB2ENR, 30, "mdio", "apb2_div" }, > > }; > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-18 9:59 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-18 5:04 [PATCH v5 00/10] Add support for DMA2D of STMicroelectronics STM32 Soc series dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 01/10] media: admin-guide: add stm32-dma2d description dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 02/10] media: dt-bindings: media: add document for STM32 DMA2d bindings dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 03/10] ARM: dts: stm32: Add DMA2D support for STM32F429 series soc dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 04/10] ARM: dts: stm32: Enable DMA2D on STM32F469-DISCO board dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 05/10] media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 06/10] media: videobuf2: Fix the size printk format dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 07/10] media: v4l2-ctrls: Add V4L2_CID_COLORFX_CBCR max setting dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 08/10] media: v4l2-ctrls: Add RGB color effects control dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 5:04 ` [PATCH v5 09/10] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 9:37 ` Hans Verkuil 2021-10-18 9:37 ` Hans Verkuil 2021-10-18 9:58 ` Dillon Min [this message] 2021-10-18 9:58 ` Dillon Min 2021-10-18 5:04 ` [PATCH v5 10/10] media: stm32-dma2d: STM32 DMA2D driver dillon.minfei 2021-10-18 5:04 ` dillon.minfei 2021-10-18 9:30 ` Hans Verkuil 2021-10-18 9:30 ` Hans Verkuil 2021-10-18 10:25 ` Dillon Min 2021-10-18 10:25 ` Dillon Min 2021-10-19 2:30 ` Dillon Min 2021-10-19 2:30 ` Dillon Min 2021-10-19 7:20 ` Hans Verkuil 2021-10-19 7:20 ` Hans Verkuil 2021-10-25 19:37 ` [PATCH v5 00/10] Add support for DMA2D of STMicroelectronics STM32 Soc series Nicolas Dufresne 2021-10-25 19:37 ` Nicolas Dufresne 2021-10-25 22:20 ` Dillon Min 2021-10-25 22:20 ` Dillon Min
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAL9mu0+wdQ-QGJEfjvc+x4vF--9HdvfG3W+5L3FWR9ij85YvTQ@mail.gmail.com \ --to=dillon.minfei@gmail.com \ --cc=alexandre.torgue@foss.st.com \ --cc=devicetree@vger.kernel.org \ --cc=ezequiel@collabora.com \ --cc=gabriel.fernandez@foss.st.com \ --cc=gabriel.fernandez@st.com \ --cc=gnurou@gmail.com \ --cc=hugues.fruchet@foss.st.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mchehab+huawei@kernel.org \ --cc=mchehab@kernel.org \ --cc=mcoquelin.stm32@gmail.com \ --cc=mturquette@baylibre.com \ --cc=patrice.chotard@foss.st.com \ --cc=pihsun@chromium.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.