From: Andy Lutomirski <luto@kernel.org> To: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Andrew Lutomirski <luto@kernel.org>, Will Deacon <will.deacon@arm.com>, Rick Edgecombe <rick.p.edgecombe@intel.com>, Nadav Amit <nadav.amit@gmail.com>, LKML <linux-kernel@vger.kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Jessica Yu <jeyu@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Alexei Starovoitov <ast@kernel.org>, Linux-MM <linux-mm@kvack.org>, Jann Horn <jannh@google.com>, "Dock, Deneen T" <deneen.t.dock@intel.com>, Peter Zijlstra <peterz@infradead.org>, Kristen Carlson Accardi <kristen@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@redhat.com>, Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, Kernel Hardening <kernel-hardening@lists.openwall.com>, Masami Hiramatsu <mhiramat@kernel.org>, "Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>, "David S. Miller" <davem@davemloft.net>, Network Development <netdev@vger.kernel.org>, Dave Hansen <dave.hansen@intel.com> Subject: Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages Date: Thu, 6 Dec 2018 11:20:51 -0800 [thread overview] Message-ID: <CALCETrUUe+X6dAfcqkL=Lncy5RyDHx6m4s1g9QgMWPE9kOBoVw@mail.gmail.com> (raw) In-Reply-To: <CAKv+Gu_Fo3qG1DaA2T1MZZau_7e6rzZQY7eJ49FQDQe0QnOgHg@mail.gmail.com> On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski <luto@kernel.org> wrote: > > > > That’s not totally nuts. Do we ever have code that expects __va() to > > work on module data? Perhaps crypto code trying to encrypt static > > data because our APIs don’t understand virtual addresses. I guess if > > highmem is ever used for modules, then we should be fine. > > > > The crypto code shouldn't care, but I think it will probably break hibernate :-( How so? Hibernate works (or at least should work) on x86 PAE, where __va doesn't work on module data, and, on x86, the direct map has some RO parts with where the module is, so hibernate can't be writing to the memory through the direct map with its final permissions.
WARNING: multiple messages have this Message-ID (diff)
From: Andy Lutomirski <luto@kernel.org> To: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Andrew Lutomirski <luto@kernel.org>, Will Deacon <will.deacon@arm.com>, Rick Edgecombe <rick.p.edgecombe@intel.com>, Nadav Amit <nadav.amit@gmail.com>, LKML <linux-kernel@vger.kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Jessica Yu <jeyu@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Alexei Starovoitov <ast@kernel.org>, Linux-MM <linux-mm@kvack.org>, Jann Horn <jannh@google.com>, "Dock, Deneen T" <deneen.t.dock@intel.com>, Peter Zijlstra <peterz@infradead.org>, Kristen Carlson Accardi <kristen@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@redhat.com>, Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, Kernel Hardening <kernel-hardening@lists.openwall.com>, Masami Hiramatsu <mhiramat@kernel.org>, Subject: Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages Date: Thu, 6 Dec 2018 11:20:51 -0800 [thread overview] Message-ID: <CALCETrUUe+X6dAfcqkL=Lncy5RyDHx6m4s1g9QgMWPE9kOBoVw@mail.gmail.com> (raw) In-Reply-To: <CAKv+Gu_Fo3qG1DaA2T1MZZau_7e6rzZQY7eJ49FQDQe0QnOgHg@mail.gmail.com> On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski <luto@kernel.org> wrote: > > > > That’s not totally nuts. Do we ever have code that expects __va() to > > work on module data? Perhaps crypto code trying to encrypt static > > data because our APIs don’t understand virtual addresses. I guess if > > highmem is ever used for modules, then we should be fine. > > > > The crypto code shouldn't care, but I think it will probably break hibernate :-( How so? Hibernate works (or at least should work) on x86 PAE, where __va doesn't work on module data, and, on x86, the direct map has some RO parts with where the module is, so hibernate can't be writing to the memory through the direct map with its final permissions.
next prev parent reply other threads:[~2018-12-06 19:21 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-28 0:07 [PATCH 0/2] Don’t leave executable TLB entries to freed pages Rick Edgecombe 2018-11-28 0:07 ` [PATCH 1/2] vmalloc: New flag for flush before releasing pages Rick Edgecombe 2018-12-04 0:04 ` Edgecombe, Rick P 2018-12-04 0:04 ` Edgecombe, Rick P 2018-12-04 0:04 ` Edgecombe, Rick P 2018-12-04 0:04 ` Edgecombe, Rick P 2018-12-04 1:43 ` Nadav Amit 2018-12-04 16:03 ` Will Deacon 2018-12-04 20:02 ` Edgecombe, Rick P 2018-12-04 20:02 ` Edgecombe, Rick P 2018-12-04 20:02 ` Edgecombe, Rick P 2018-12-04 20:02 ` Edgecombe, Rick P 2018-12-04 20:09 ` Andy Lutomirski 2018-12-04 20:09 ` Andy Lutomirski 2018-12-04 23:52 ` Edgecombe, Rick P 2018-12-04 23:52 ` Edgecombe, Rick P 2018-12-04 23:52 ` Edgecombe, Rick P 2018-12-05 1:57 ` Andy Lutomirski 2018-12-05 1:57 ` Andy Lutomirski 2018-12-05 1:57 ` Andy Lutomirski 2018-12-05 11:41 ` Will Deacon 2018-12-05 11:41 ` Will Deacon 2018-12-05 23:16 ` Andy Lutomirski 2018-12-05 23:16 ` Andy Lutomirski 2018-12-06 7:29 ` Ard Biesheuvel 2018-12-06 7:29 ` Ard Biesheuvel 2018-12-06 11:10 ` Will Deacon 2018-12-06 11:10 ` Will Deacon 2018-12-06 18:53 ` Andy Lutomirski 2018-12-06 18:53 ` Andy Lutomirski 2018-12-06 19:01 ` Tycho Andersen 2018-12-06 19:01 ` Tycho Andersen 2018-12-06 19:19 ` Andy Lutomirski 2018-12-06 19:19 ` Andy Lutomirski 2018-12-06 19:39 ` Nadav Amit 2018-12-06 19:39 ` Nadav Amit 2018-12-06 20:17 ` Andy Lutomirski 2018-12-06 20:17 ` Andy Lutomirski 2018-12-06 23:08 ` Nadav Amit 2018-12-06 23:08 ` Nadav Amit 2018-12-07 3:06 ` Edgecombe, Rick P 2018-12-07 3:06 ` Edgecombe, Rick P 2018-12-07 3:06 ` Edgecombe, Rick P 2018-12-06 20:19 ` Edgecombe, Rick P 2018-12-06 20:19 ` Edgecombe, Rick P 2018-12-06 20:19 ` Edgecombe, Rick P 2018-12-06 20:26 ` Andy Lutomirski 2018-12-06 20:26 ` Andy Lutomirski 2018-12-06 19:04 ` Ard Biesheuvel 2018-12-06 19:04 ` Ard Biesheuvel 2018-12-06 19:20 ` Andy Lutomirski [this message] 2018-12-06 19:20 ` Andy Lutomirski 2018-12-06 19:23 ` Ard Biesheuvel 2018-12-06 19:23 ` Ard Biesheuvel 2018-12-06 19:31 ` Will Deacon 2018-12-06 19:31 ` Will Deacon 2018-12-06 19:36 ` Ard Biesheuvel 2018-12-06 19:36 ` Ard Biesheuvel 2018-12-04 20:36 ` Nadav Amit 2018-12-04 20:36 ` Nadav Amit 2018-12-04 20:36 ` Nadav Amit 2018-12-04 23:51 ` Edgecombe, Rick P 2018-12-04 23:51 ` Edgecombe, Rick P 2018-12-05 0:01 ` Nadav Amit 2018-12-05 0:01 ` Nadav Amit 2018-12-05 0:01 ` Nadav Amit 2018-12-05 0:29 ` Edgecombe, Rick P 2018-12-05 0:29 ` Edgecombe, Rick P 2018-12-05 0:29 ` Edgecombe, Rick P 2018-12-05 0:53 ` Nadav Amit 2018-12-05 0:53 ` Nadav Amit 2018-12-05 0:53 ` Nadav Amit 2018-12-05 1:45 ` Edgecombe, Rick P 2018-12-05 1:45 ` Edgecombe, Rick P 2018-12-05 1:45 ` Edgecombe, Rick P 2018-12-05 2:09 ` Nadav Amit 2018-12-05 2:09 ` Nadav Amit 2018-12-05 2:09 ` Nadav Amit 2018-12-04 18:56 ` Andy Lutomirski 2018-12-04 18:56 ` Andy Lutomirski 2018-12-04 19:44 ` Nadav Amit 2018-12-04 19:44 ` Nadav Amit 2018-12-04 19:48 ` Andy Lutomirski 2018-12-04 19:48 ` Andy Lutomirski 2018-12-04 22:48 ` Nadav Amit 2018-12-04 22:48 ` Nadav Amit 2018-12-04 23:27 ` Andy Lutomirski 2018-12-04 23:27 ` Andy Lutomirski 2018-12-04 23:34 ` Nadav Amit 2018-12-04 23:34 ` Nadav Amit 2018-12-05 1:09 ` Edgecombe, Rick P 2018-12-05 1:09 ` Edgecombe, Rick P 2018-12-05 1:09 ` Edgecombe, Rick P 2018-12-05 1:45 ` Nadav Amit 2018-12-05 1:45 ` Nadav Amit 2018-12-05 1:45 ` Nadav Amit 2018-11-28 0:07 ` [PATCH 2/2] x86/modules: Make x86 allocs to flush when free Rick Edgecombe 2018-11-28 23:11 ` Andrew Morton 2018-11-29 0:02 ` Edgecombe, Rick P 2018-11-29 0:02 ` Edgecombe, Rick P 2018-11-29 0:02 ` Edgecombe, Rick P 2018-11-29 1:40 ` Andy Lutomirski 2018-11-29 1:40 ` Andy Lutomirski 2018-11-29 6:14 ` Edgecombe, Rick P 2018-11-29 6:14 ` Edgecombe, Rick P 2018-11-29 6:14 ` Edgecombe, Rick P 2018-11-28 1:06 ` [PATCH 0/2] Don’t leave executable TLB entries to freed pages Nadav Amit 2018-11-28 1:21 ` Nadav Amit 2018-11-28 9:57 ` Will Deacon 2018-11-28 18:29 ` Nadav Amit 2018-11-29 14:06 ` Masami Hiramatsu 2018-11-29 18:49 ` Edgecombe, Rick P 2018-11-29 18:49 ` Edgecombe, Rick P 2018-11-29 18:49 ` Edgecombe, Rick P 2018-11-29 23:19 ` Masami Hiramatsu 2018-11-29 23:19 ` Masami Hiramatsu 2018-11-29 23:19 ` Masami Hiramatsu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALCETrUUe+X6dAfcqkL=Lncy5RyDHx6m4s1g9QgMWPE9kOBoVw@mail.gmail.com' \ --to=luto@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=anil.s.keshavamurthy@intel.com \ --cc=ard.biesheuvel@linaro.org \ --cc=ast@kernel.org \ --cc=daniel@iogearbox.net \ --cc=dave.hansen@intel.com \ --cc=davem@davemloft.net \ --cc=deneen.t.dock@intel.com \ --cc=jannh@google.com \ --cc=jeyu@kernel.org \ --cc=kernel-hardening@lists.openwall.com \ --cc=kristen@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhiramat@kernel.org \ --cc=mingo@redhat.com \ --cc=nadav.amit@gmail.com \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=netdev@vger.kernel.org \ --cc=peterz@infradead.org \ --cc=rick.p.edgecombe@intel.com \ --cc=rostedt@goodmis.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.