* [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
@ 2015-04-20 23:15 ` Tyler Baker
0 siblings, 0 replies; 10+ messages in thread
From: Tyler Baker @ 2015-04-20 23:15 UTC (permalink / raw)
To: Shuah Khan
Cc: Andy Lutomirski, Kevin Hilman, John Stultz, Darren Hart,
David Herrmann, Michael Ellerman, linux-kernel, linux-arm-kernel,
Tyler Baker
If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
tools/testing/selftests/x86/Makefile | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index be93945..a5ca38b 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
+all:
+
UNAME_M := $(shell uname -m)
+ifeq ($(CROSS_COMPILE),)
# Always build 32-bit tests
all: all_32
-
# If we're on a 64-bit host, build 64-bit tests as well
ifeq ($(UNAME_M),x86_64)
all: all_64
endif
+else
+# No dependency on all when cross building
+all:
+endif
all_32: check_build32 $(BINARIES_32)
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
@ 2015-04-20 23:15 ` Tyler Baker
0 siblings, 0 replies; 10+ messages in thread
From: Tyler Baker @ 2015-04-20 23:15 UTC (permalink / raw)
To: linux-arm-kernel
If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
tools/testing/selftests/x86/Makefile | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index be93945..a5ca38b 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
+all:
+
UNAME_M := $(shell uname -m)
+ifeq ($(CROSS_COMPILE),)
# Always build 32-bit tests
all: all_32
-
# If we're on a 64-bit host, build 64-bit tests as well
ifeq ($(UNAME_M),x86_64)
all: all_64
endif
+else
+# No dependency on all when cross building
+all:
+endif
all_32: check_build32 $(BINARIES_32)
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
2015-04-20 23:15 ` Tyler Baker
@ 2015-04-20 23:22 ` Andy Lutomirski
-1 siblings, 0 replies; 10+ messages in thread
From: Andy Lutomirski @ 2015-04-20 23:22 UTC (permalink / raw)
To: Tyler Baker
Cc: Shuah Khan, Kevin Hilman, John Stultz, Darren Hart,
David Herrmann, Michael Ellerman, linux-kernel, linux-arm-kernel
On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> tools/testing/selftests/x86/Makefile | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> index be93945..a5ca38b 100644
> --- a/tools/testing/selftests/x86/Makefile
> +++ b/tools/testing/selftests/x86/Makefile
> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>
> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>
> +all:
> +
This...
> UNAME_M := $(shell uname -m)
>
> +ifeq ($(CROSS_COMPILE),)
> # Always build 32-bit tests
> all: all_32
> -
> # If we're on a 64-bit host, build 64-bit tests as well
> ifeq ($(UNAME_M),x86_64)
> all: all_64
> endif
> +else
> +# No dependency on all when cross building
> +all:
...is redundant with this. If you delete the "else" and "all:" here, then:
Acked-by: Andy Lutomirski <luto@kernel.org>
> +endif
>
> all_32: check_build32 $(BINARIES_32)
>
> --
> 2.1.4
>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
@ 2015-04-20 23:22 ` Andy Lutomirski
0 siblings, 0 replies; 10+ messages in thread
From: Andy Lutomirski @ 2015-04-20 23:22 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> tools/testing/selftests/x86/Makefile | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> index be93945..a5ca38b 100644
> --- a/tools/testing/selftests/x86/Makefile
> +++ b/tools/testing/selftests/x86/Makefile
> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>
> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>
> +all:
> +
This...
> UNAME_M := $(shell uname -m)
>
> +ifeq ($(CROSS_COMPILE),)
> # Always build 32-bit tests
> all: all_32
> -
> # If we're on a 64-bit host, build 64-bit tests as well
> ifeq ($(UNAME_M),x86_64)
> all: all_64
> endif
> +else
> +# No dependency on all when cross building
> +all:
...is redundant with this. If you delete the "else" and "all:" here, then:
Acked-by: Andy Lutomirski <luto@kernel.org>
> +endif
>
> all_32: check_build32 $(BINARIES_32)
>
> --
> 2.1.4
>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
2015-04-20 23:22 ` Andy Lutomirski
@ 2015-04-20 23:34 ` Tyler Baker
-1 siblings, 0 replies; 10+ messages in thread
From: Tyler Baker @ 2015-04-20 23:34 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Shuah Khan, Kevin Hilman, John Stultz, Darren Hart,
David Herrmann, Michael Ellerman, linux-kernel, linux-arm-kernel
On 20 April 2015 at 16:22, Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>>
>> Cc: Andy Lutomirski <luto@amacapital.net>
>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>> ---
>> tools/testing/selftests/x86/Makefile | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
>> index be93945..a5ca38b 100644
>> --- a/tools/testing/selftests/x86/Makefile
>> +++ b/tools/testing/selftests/x86/Makefile
>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>>
>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>>
>> +all:
>> +
>
> This...
>
>> UNAME_M := $(shell uname -m)
>>
>> +ifeq ($(CROSS_COMPILE),)
>> # Always build 32-bit tests
>> all: all_32
>> -
>> # If we're on a 64-bit host, build 64-bit tests as well
>> ifeq ($(UNAME_M),x86_64)
>> all: all_64
>> endif
>> +else
>> +# No dependency on all when cross building
>> +all:
>
> ...is redundant with this. If you delete the "else" and "all:" here, then:
Ok, I will remove these bits from this patch. However, the else will
need to be added back in the next patch of the series to override the
default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok
with that.
>
> Acked-by: Andy Lutomirski <luto@kernel.org>
>
>> +endif
>>
>> all_32: check_build32 $(BINARIES_32)
>>
>> --
>> 2.1.4
>>
>
>
>
> --
> Andy Lutomirski
> AMA Capital Management, LLC
Tyler
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
@ 2015-04-20 23:34 ` Tyler Baker
0 siblings, 0 replies; 10+ messages in thread
From: Tyler Baker @ 2015-04-20 23:34 UTC (permalink / raw)
To: linux-arm-kernel
On 20 April 2015 at 16:22, Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>>
>> Cc: Andy Lutomirski <luto@amacapital.net>
>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>> ---
>> tools/testing/selftests/x86/Makefile | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
>> index be93945..a5ca38b 100644
>> --- a/tools/testing/selftests/x86/Makefile
>> +++ b/tools/testing/selftests/x86/Makefile
>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>>
>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>>
>> +all:
>> +
>
> This...
>
>> UNAME_M := $(shell uname -m)
>>
>> +ifeq ($(CROSS_COMPILE),)
>> # Always build 32-bit tests
>> all: all_32
>> -
>> # If we're on a 64-bit host, build 64-bit tests as well
>> ifeq ($(UNAME_M),x86_64)
>> all: all_64
>> endif
>> +else
>> +# No dependency on all when cross building
>> +all:
>
> ...is redundant with this. If you delete the "else" and "all:" here, then:
Ok, I will remove these bits from this patch. However, the else will
need to be added back in the next patch of the series to override the
default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok
with that.
>
> Acked-by: Andy Lutomirski <luto@kernel.org>
>
>> +endif
>>
>> all_32: check_build32 $(BINARIES_32)
>>
>> --
>> 2.1.4
>>
>
>
>
> --
> Andy Lutomirski
> AMA Capital Management, LLC
Tyler
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
2015-04-20 23:34 ` Tyler Baker
@ 2015-04-20 23:47 ` Andy Lutomirski
-1 siblings, 0 replies; 10+ messages in thread
From: Andy Lutomirski @ 2015-04-20 23:47 UTC (permalink / raw)
To: Tyler Baker
Cc: Shuah Khan, Kevin Hilman, John Stultz, Darren Hart,
David Herrmann, Michael Ellerman, linux-kernel, linux-arm-kernel
On Mon, Apr 20, 2015 at 4:34 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
> On 20 April 2015 at 16:22, Andy Lutomirski <luto@amacapital.net> wrote:
>> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
>>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>>>
>>> Cc: Andy Lutomirski <luto@amacapital.net>
>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>>> ---
>>> tools/testing/selftests/x86/Makefile | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
>>> index be93945..a5ca38b 100644
>>> --- a/tools/testing/selftests/x86/Makefile
>>> +++ b/tools/testing/selftests/x86/Makefile
>>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>>>
>>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>>>
>>> +all:
>>> +
>>
>> This...
>>
>>> UNAME_M := $(shell uname -m)
>>>
>>> +ifeq ($(CROSS_COMPILE),)
>>> # Always build 32-bit tests
>>> all: all_32
>>> -
>>> # If we're on a 64-bit host, build 64-bit tests as well
>>> ifeq ($(UNAME_M),x86_64)
>>> all: all_64
>>> endif
>>> +else
>>> +# No dependency on all when cross building
>>> +all:
>>
>> ...is redundant with this. If you delete the "else" and "all:" here, then:
>
> Ok, I will remove these bits from this patch. However, the else will
> need to be added back in the next patch of the series to override the
> default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok
> with that.
I'm fine with that, unless you or Shuah want to fix lib.mk.
--Andy
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
@ 2015-04-20 23:47 ` Andy Lutomirski
0 siblings, 0 replies; 10+ messages in thread
From: Andy Lutomirski @ 2015-04-20 23:47 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 20, 2015 at 4:34 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
> On 20 April 2015 at 16:22, Andy Lutomirski <luto@amacapital.net> wrote:
>> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
>>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>>>
>>> Cc: Andy Lutomirski <luto@amacapital.net>
>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>>> ---
>>> tools/testing/selftests/x86/Makefile | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
>>> index be93945..a5ca38b 100644
>>> --- a/tools/testing/selftests/x86/Makefile
>>> +++ b/tools/testing/selftests/x86/Makefile
>>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>>>
>>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>>>
>>> +all:
>>> +
>>
>> This...
>>
>>> UNAME_M := $(shell uname -m)
>>>
>>> +ifeq ($(CROSS_COMPILE),)
>>> # Always build 32-bit tests
>>> all: all_32
>>> -
>>> # If we're on a 64-bit host, build 64-bit tests as well
>>> ifeq ($(UNAME_M),x86_64)
>>> all: all_64
>>> endif
>>> +else
>>> +# No dependency on all when cross building
>>> +all:
>>
>> ...is redundant with this. If you delete the "else" and "all:" here, then:
>
> Ok, I will remove these bits from this patch. However, the else will
> need to be added back in the next patch of the series to override the
> default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok
> with that.
I'm fine with that, unless you or Shuah want to fix lib.mk.
--Andy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
2015-04-20 23:47 ` Andy Lutomirski
@ 2015-04-21 2:51 ` Tyler Baker
-1 siblings, 0 replies; 10+ messages in thread
From: Tyler Baker @ 2015-04-21 2:51 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Shuah Khan, Kevin Hilman, John Stultz, Darren Hart,
David Herrmann, Michael Ellerman, linux-kernel, linux-arm-kernel
On 20 April 2015 at 16:47, Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Apr 20, 2015 at 4:34 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
>> On 20 April 2015 at 16:22, Andy Lutomirski <luto@amacapital.net> wrote:
>>> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
>>>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>>>>
>>>> Cc: Andy Lutomirski <luto@amacapital.net>
>>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>>>> ---
>>>> tools/testing/selftests/x86/Makefile | 8 +++++++-
>>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
>>>> index be93945..a5ca38b 100644
>>>> --- a/tools/testing/selftests/x86/Makefile
>>>> +++ b/tools/testing/selftests/x86/Makefile
>>>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>>>>
>>>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>>>>
>>>> +all:
>>>> +
>>>
>>> This...
>>>
>>>> UNAME_M := $(shell uname -m)
>>>>
>>>> +ifeq ($(CROSS_COMPILE),)
>>>> # Always build 32-bit tests
>>>> all: all_32
>>>> -
>>>> # If we're on a 64-bit host, build 64-bit tests as well
>>>> ifeq ($(UNAME_M),x86_64)
>>>> all: all_64
>>>> endif
>>>> +else
>>>> +# No dependency on all when cross building
>>>> +all:
>>>
>>> ...is redundant with this. If you delete the "else" and "all:" here, then:
>>
>> Ok, I will remove these bits from this patch. However, the else will
>> need to be added back in the next patch of the series to override the
>> default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok
>> with that.
>
> I'm fine with that, unless you or Shuah want to fix lib.mk.
I will send a follow up series to address this issue.
>
> --Andy
Tyler
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building
@ 2015-04-21 2:51 ` Tyler Baker
0 siblings, 0 replies; 10+ messages in thread
From: Tyler Baker @ 2015-04-21 2:51 UTC (permalink / raw)
To: linux-arm-kernel
On 20 April 2015 at 16:47, Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Apr 20, 2015 at 4:34 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
>> On 20 April 2015 at 16:22, Andy Lutomirski <luto@amacapital.net> wrote:
>>> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote:
>>>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>>>>
>>>> Cc: Andy Lutomirski <luto@amacapital.net>
>>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>>>> ---
>>>> tools/testing/selftests/x86/Makefile | 8 +++++++-
>>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
>>>> index be93945..a5ca38b 100644
>>>> --- a/tools/testing/selftests/x86/Makefile
>>>> +++ b/tools/testing/selftests/x86/Makefile
>>>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>>>>
>>>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>>>>
>>>> +all:
>>>> +
>>>
>>> This...
>>>
>>>> UNAME_M := $(shell uname -m)
>>>>
>>>> +ifeq ($(CROSS_COMPILE),)
>>>> # Always build 32-bit tests
>>>> all: all_32
>>>> -
>>>> # If we're on a 64-bit host, build 64-bit tests as well
>>>> ifeq ($(UNAME_M),x86_64)
>>>> all: all_64
>>>> endif
>>>> +else
>>>> +# No dependency on all when cross building
>>>> +all:
>>>
>>> ...is redundant with this. If you delete the "else" and "all:" here, then:
>>
>> Ok, I will remove these bits from this patch. However, the else will
>> need to be added back in the next patch of the series to override the
>> default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok
>> with that.
>
> I'm fine with that, unless you or Shuah want to fix lib.mk.
I will send a follow up series to address this issue.
>
> --Andy
Tyler
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-04-21 2:51 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-20 23:15 [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building Tyler Baker
2015-04-20 23:15 ` Tyler Baker
2015-04-20 23:22 ` Andy Lutomirski
2015-04-20 23:22 ` Andy Lutomirski
2015-04-20 23:34 ` Tyler Baker
2015-04-20 23:34 ` Tyler Baker
2015-04-20 23:47 ` Andy Lutomirski
2015-04-20 23:47 ` Andy Lutomirski
2015-04-21 2:51 ` Tyler Baker
2015-04-21 2:51 ` Tyler Baker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.