* [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius
@ 2017-07-12 20:06 Eddie James
2017-07-13 1:04 ` Joel Stanley
0 siblings, 1 reply; 5+ messages in thread
From: Eddie James @ 2017-07-12 20:06 UTC (permalink / raw)
To: openbmc; +Cc: joel, Edward A. James
From: "Edward A. James" <eajames@us.ibm.com>
Missing label, properties, and include file.
Signed-off-by: Edward A. James <eajames@us.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
index c620015..750ec12 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
@@ -71,10 +71,10 @@
};
};
- gpio-fsi {
+ fsi: gpio-fsi {
compatible = "fsi-master-gpio", "fsi-master";
-
- status = "okay";
+ #address-cells = <2>;
+ #size-cells = <0>;
/*
* These 2 GPIOs are set per board revision in aspeed.c.
@@ -96,6 +96,8 @@
};
};
+#include "ibm-power9-cfam.dtsi"
+
&fmc {
status = "okay";
flash@0 {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius
2017-07-12 20:06 [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius Eddie James
@ 2017-07-13 1:04 ` Joel Stanley
2017-07-14 12:26 ` Andrew Geissler
2017-07-14 22:54 ` Xo Wang
0 siblings, 2 replies; 5+ messages in thread
From: Joel Stanley @ 2017-07-13 1:04 UTC (permalink / raw)
To: Eddie James, Xo Wang; +Cc: OpenBMC Maillist, Edward A. James
On Thu, Jul 13, 2017 at 5:36 AM, Eddie James <eajames@linux.vnet.ibm.com> wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> Missing label, properties, and include file.
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
Hey Xo, can I get an ack on this?
Cheers,
Joel
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> index c620015..750ec12 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> @@ -71,10 +71,10 @@
> };
> };
>
> - gpio-fsi {
> + fsi: gpio-fsi {
> compatible = "fsi-master-gpio", "fsi-master";
> -
> - status = "okay";
> + #address-cells = <2>;
> + #size-cells = <0>;
>
> /*
> * These 2 GPIOs are set per board revision in aspeed.c.
> @@ -96,6 +96,8 @@
> };
> };
>
> +#include "ibm-power9-cfam.dtsi"
> +
> &fmc {
> status = "okay";
> flash@0 {
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius
2017-07-13 1:04 ` Joel Stanley
@ 2017-07-14 12:26 ` Andrew Geissler
2017-07-14 22:54 ` Xo Wang
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Geissler @ 2017-07-14 12:26 UTC (permalink / raw)
To: Joel Stanley; +Cc: Eddie James, Xo Wang, Edward A. James, OpenBMC Maillist
On Wed, Jul 12, 2017 at 8:04 PM, Joel Stanley <joel@jms.id.au> wrote:
> On Thu, Jul 13, 2017 at 5:36 AM, Eddie James <eajames@linux.vnet.ibm.com> wrote:
>> From: "Edward A. James" <eajames@us.ibm.com>
>>
>> Missing label, properties, and include file.
>>
>> Signed-off-by: Edward A. James <eajames@us.ibm.com>
>
> Hey Xo, can I get an ack on this?
>
> Cheers,
>
> Joel
>
>> ---
>> arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> index c620015..750ec12 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> @@ -71,10 +71,10 @@
>> };
>> };
>>
>> - gpio-fsi {
>> + fsi: gpio-fsi {
>> compatible = "fsi-master-gpio", "fsi-master";
>> -
>> - status = "okay";
>> + #address-cells = <2>;
>> + #size-cells = <0>;
>>
>> /*
>> * These 2 GPIOs are set per board revision in aspeed.c.
>> @@ -96,6 +96,8 @@
>> };
>> };
>>
>> +#include "ibm-power9-cfam.dtsi"
>> +
>> &fmc {
>> status = "okay";
>> flash@0 {
>> --
>> 1.8.3.1
>>
Verified that this with https://gerrit.openbmc-project.xyz/#/c/5258/
allowed me to get the occ thermal sensors via phosphor-hwmon.
Tested-by: Andrew Geissler <geissonator@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius
2017-07-13 1:04 ` Joel Stanley
2017-07-14 12:26 ` Andrew Geissler
@ 2017-07-14 22:54 ` Xo Wang
2017-07-19 9:11 ` Joel Stanley
1 sibling, 1 reply; 5+ messages in thread
From: Xo Wang @ 2017-07-14 22:54 UTC (permalink / raw)
To: Joel Stanley; +Cc: Eddie James, OpenBMC Maillist, Edward A. James
On Wed, Jul 12, 2017 at 6:04 PM, Joel Stanley <joel@jms.id.au> wrote:
> On Thu, Jul 13, 2017 at 5:36 AM, Eddie James <eajames@linux.vnet.ibm.com> wrote:
>> From: "Edward A. James" <eajames@us.ibm.com>
>>
>> Missing label, properties, and include file.
>>
>> Signed-off-by: Edward A. James <eajames@us.ibm.com>
>
> Hey Xo, can I get an ack on this?
>
> Cheers,
>
> Joel
>
Ah, missed this.
Thanks.
Acked-by: Xo Wang <xow@google.com>
>> ---
>> arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> index c620015..750ec12 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> @@ -71,10 +71,10 @@
>> };
>> };
>>
>> - gpio-fsi {
>> + fsi: gpio-fsi {
>> compatible = "fsi-master-gpio", "fsi-master";
>> -
>> - status = "okay";
>> + #address-cells = <2>;
>> + #size-cells = <0>;
>>
>> /*
>> * These 2 GPIOs are set per board revision in aspeed.c.
>> @@ -96,6 +96,8 @@
>> };
>> };
>>
>> +#include "ibm-power9-cfam.dtsi"
>> +
>> &fmc {
>> status = "okay";
>> flash@0 {
>> --
>> 1.8.3.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius
2017-07-14 22:54 ` Xo Wang
@ 2017-07-19 9:11 ` Joel Stanley
0 siblings, 0 replies; 5+ messages in thread
From: Joel Stanley @ 2017-07-19 9:11 UTC (permalink / raw)
To: Xo Wang; +Cc: Eddie James, OpenBMC Maillist, Edward A. James
On Sat, Jul 15, 2017 at 8:24 AM, Xo Wang <xow@google.com> wrote:
> On Wed, Jul 12, 2017 at 6:04 PM, Joel Stanley <joel@jms.id.au> wrote:
>> On Thu, Jul 13, 2017 at 5:36 AM, Eddie James <eajames@linux.vnet.ibm.com> wrote:
>>> From: "Edward A. James" <eajames@us.ibm.com>
>>>
>>> Missing label, properties, and include file.
>>>
>>> Signed-off-by: Edward A. James <eajames@us.ibm.com>
>>
>> Hey Xo, can I get an ack on this?
>>
>> Cheers,
>>
>> Joel
>>
>
> Ah, missed this.
>
> Thanks.
>
> Acked-by: Xo Wang <xow@google.com>
Applied to dev-4.10.
Cheers,
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-19 9:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-12 20:06 [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius Eddie James
2017-07-13 1:04 ` Joel Stanley
2017-07-14 12:26 ` Andrew Geissler
2017-07-14 22:54 ` Xo Wang
2017-07-19 9:11 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.