All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Aradhya Bhatia <a-bhatia1@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Conor Dooley <conor+dt@kernel.org>, Will Deacon <will@kernel.org>,
	Francesco Dolcini <francesco@dolcini.it>,
	Devicetree List <devicetree@vger.kernel.org>,
	Linux Kernel List <linux-kernel@vger.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Rahul T R <r-ravikumar@ti.com>, Devarsh Thakkar <devarsht@ti.com>,
	Jai Luthra <j-luthra@ti.com>,
	Jayesh Choudhary <j-choudhary@ti.com>
Subject: Re: [PATCH v5 4/6] arm64: dts: ti: am62x-sk: Add overlay for HDMI audio
Date: Fri, 8 Sep 2023 17:13:27 -0500	[thread overview]
Message-ID: <CAL_Jsq+GR3hP6hFvFn2z5aXvSXnh9butD3aKZ-y_XJgx0_YPTw@mail.gmail.com> (raw)
In-Reply-To: <20230809084559.17322-5-a-bhatia1@ti.com>

On Wed, Aug 9, 2023 at 3:46 AM Aradhya Bhatia <a-bhatia1@ti.com> wrote:
>
> From: Jai Luthra <j-luthra@ti.com>
>
> Enable audio output over HDMI instead of the 3.5mm jack.
>
> A FET switch (U65) on the EVM muxes serial audio lines coming from McASP
> between the codec (tlv320aic3106) and the HDMI bridge (sii9022).
>
> By default it uses the codec, but it can be toggled to use the HDMI
> bridge by shorting a (J24) header on the board.
>
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> [a-bhatia1: Cosmetic changes]
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
>  arch/arm64/boot/dts/ti/Makefile               |  3 ++
>  .../boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso   | 40 +++++++++++++++++++
>  2 files changed, 43 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso
>
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index 437a3d7e8e3a..e3eadf69d43b 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dahlia.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dev.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-yavia.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk.dtb
> +dtb-$(CONFIG_ARCH_K3) += k3-am62x-sk-hdmi-audio.dtbo

Overlays need to be applied to something. That's done like this:

foo-dtbs := base.dtb k3-am62x-sk-hdmi-audio.dtbo
dtb-y += foo.dtb

Please send a fix for this.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Aradhya Bhatia <a-bhatia1@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Conor Dooley <conor+dt@kernel.org>,
	 Will Deacon <will@kernel.org>,
	Francesco Dolcini <francesco@dolcini.it>,
	 Devicetree List <devicetree@vger.kernel.org>,
	 Linux Kernel List <linux-kernel@vger.kernel.org>,
	 Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	 Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Rahul T R <r-ravikumar@ti.com>,
	 Devarsh Thakkar <devarsht@ti.com>, Jai Luthra <j-luthra@ti.com>,
	Jayesh Choudhary <j-choudhary@ti.com>
Subject: Re: [PATCH v5 4/6] arm64: dts: ti: am62x-sk: Add overlay for HDMI audio
Date: Fri, 8 Sep 2023 17:13:27 -0500	[thread overview]
Message-ID: <CAL_Jsq+GR3hP6hFvFn2z5aXvSXnh9butD3aKZ-y_XJgx0_YPTw@mail.gmail.com> (raw)
In-Reply-To: <20230809084559.17322-5-a-bhatia1@ti.com>

On Wed, Aug 9, 2023 at 3:46 AM Aradhya Bhatia <a-bhatia1@ti.com> wrote:
>
> From: Jai Luthra <j-luthra@ti.com>
>
> Enable audio output over HDMI instead of the 3.5mm jack.
>
> A FET switch (U65) on the EVM muxes serial audio lines coming from McASP
> between the codec (tlv320aic3106) and the HDMI bridge (sii9022).
>
> By default it uses the codec, but it can be toggled to use the HDMI
> bridge by shorting a (J24) header on the board.
>
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> [a-bhatia1: Cosmetic changes]
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
>  arch/arm64/boot/dts/ti/Makefile               |  3 ++
>  .../boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso   | 40 +++++++++++++++++++
>  2 files changed, 43 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso
>
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index 437a3d7e8e3a..e3eadf69d43b 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dahlia.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dev.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-yavia.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk.dtb
> +dtb-$(CONFIG_ARCH_K3) += k3-am62x-sk-hdmi-audio.dtbo

Overlays need to be applied to something. That's done like this:

foo-dtbs := base.dtb k3-am62x-sk-hdmi-audio.dtbo
dtb-y += foo.dtb

Please send a fix for this.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-08 22:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09  8:45 [PATCH v5 0/6] arm64: ti: k3-am62: Add display support Aradhya Bhatia
2023-08-09  8:45 ` Aradhya Bhatia
2023-08-09  8:45 ` [PATCH v5 1/6] arm64: dts: ti: k3-am62x-sk-common: Update main-i2c1 frequency Aradhya Bhatia
2023-08-09  8:45   ` Aradhya Bhatia
2023-08-09  8:45 ` [PATCH v5 2/6] arm64: dts: ti: k3-am62-main: Add node for DSS Aradhya Bhatia
2023-08-09  8:45   ` Aradhya Bhatia
2023-08-09  8:45 ` [PATCH v5 3/6] arm64: dts: ti: k3-am62x-sk-common: Add HDMI support Aradhya Bhatia
2023-08-09  8:45   ` Aradhya Bhatia
2023-08-09  8:45 ` [PATCH v5 4/6] arm64: dts: ti: am62x-sk: Add overlay for HDMI audio Aradhya Bhatia
2023-08-09  8:45   ` Aradhya Bhatia
2023-09-08 22:13   ` Rob Herring [this message]
2023-09-08 22:13     ` Rob Herring
2023-08-09  8:45 ` [PATCH v5 5/6] arm64: dts: ti: k3-am625-beagleplay: Add HDMI support Aradhya Bhatia
2023-08-09  8:45   ` Aradhya Bhatia
2023-08-09  8:45 ` [PATCH v5 6/6] arm64: defconfig: Enable ITE_IT66121 HDMI transmitter Aradhya Bhatia
2023-08-09  8:45   ` Aradhya Bhatia
2023-08-09 14:40 ` [PATCH v5 0/6] arm64: ti: k3-am62: Add display support Nishanth Menon
2023-08-09 14:40   ` Nishanth Menon
2023-08-09 17:01   ` Andrew Davis
2023-08-09 17:01     ` Andrew Davis
2023-08-09 17:59     ` Nishanth Menon
2023-08-09 17:59       ` Nishanth Menon
2023-08-11 22:32 ` Nishanth Menon
2023-08-11 22:32   ` Nishanth Menon
2023-08-14 10:41   ` Aradhya Bhatia
2023-08-14 10:41     ` Aradhya Bhatia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_Jsq+GR3hP6hFvFn2z5aXvSXnh9butD3aKZ-y_XJgx0_YPTw@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=a-bhatia1@ti.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco@dolcini.it \
    --cc=j-choudhary@ti.com \
    --cc=j-luthra@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=r-ravikumar@ti.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vigneshr@ti.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.