Re: [PATCH 3/5] dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy

From: Rob Herring <robh+dt@kernel.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, linux-clk <linux-clk@vger.kernel.org>,
	soc@kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy
Date: Tue, 7 Jan 2020 16:20:56 -0600	[thread overview]
Message-ID: <CAL_Jsq+LduJhf_LawZ+Ofu-70J3c1L3NuqAw3_jzYpC0Gy3x0A@mail.gmail.com> (raw)
In-Reply-To: <20191220065314.237624-4-lkundrak@v3.sk>

On Fri, Dec 20, 2019 at 1:01 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> This is the PHY chip for USB HSIC on MMP3 platform.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../bindings/phy/marvell,mmp3-hsic-phy.yaml   | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml

Seems this is already in -next, but it breaks dt_binding_check.

>
> diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
> new file mode 100644
> index 0000000000000..7917a95cda78d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later

Dual license new bindings:

(GPL-2.0-only OR BSD-2-Clause)

> +# Copyright 2019 Lubomir Rintel <lkundrak@v3.sk>
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/marvell,mmp3-hsic-phy.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Marvell MMP3 HSIC PHY
> +
> +maintainers:
> +  - Lubomir Rintel <lkundrak@v3.sk>
> +
> +properties:
> +  compatible:
> +    const: marvell,mmp3-hsic-phy
> +
> +  reg:
> +    maxItems: 1
> +    description: base address of the device

Drop description. That's *every* 'reg' property.

> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: GPIO connected to reset
> +
> +  "#phy-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +  - "#phy-cells"
> +
> +examples:
> +  - |
> +    hsic-phy@f0001800 {
> +            compatible = "marvell,mmp3-hsic-phy";
> +            reg = <0xf0001800 0x40>;
> +            reset-gpios = <&gpio 63 GPIO_ACTIVE_HIGH>;

Examples are built now and this one doesn't. You need the include for
the define. Check with 'make dt_binding_check'.

> +            #phy-cells = <0>;
> +    };
> --
> 2.24.1
>